From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E55E3E832B for ; Wed, 19 Aug 2026 10:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136771; cv=none; b=mN+cib39/Cr3/m1tSa3pmFqMIwodJplJJT5CJwdf6x+U9YRr3uAoSTsTIkWZv9oaCNNIrhOBrQp5Urx46YA53MyvreK+xkXutdw7JT+mzjIdrwJ1TIst/Y0K3/UiRLcaz/HPetSufDBDLYQutWOuK+7G2nFx3lxLG4WBVwPzIv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136771; c=relaxed/simple; bh=0va3WFlSC6WHbkfOdYWUCNkm6pgNY44JTkg3gjhyJWE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ROW2ambuo+P3L7rwvupXfR5z+LosXSkqXXAS4S7uWTKKI8DDRTxpD6qCqoyEaw6bkYqwQnhSND6Cpt6BgpjSB7C+V5tlcwgLT0CV4BYhG+xnlDjBbNtoBL6pBJOytlkrmlFQ7CaTRMrwgCtQg9EpCEyU9C4owQHChSGTNo/ESzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cnqJiIda; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cnqJiIda" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-4798bea72f9so467843f8f.1 for ; Wed, 19 Aug 2026 03:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136768; x=1787741568; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9bdVdt7FL/tihS7EYxxhgHwIGgHm7ch/dQjPbge2b/w=; b=cnqJiIdaLkBNnyt70KJkNw1NB7Im9EPDNFM/M0Pt7oxfz8lyrLOhS5+vU67gv+qAZp iigXTHn3vTml4mOclVTR5boGG3nPZFrRMl11aPsVWKxUrAqntBSC5srtehveysb7Y73S DeYBWjhDZcKtRZF95/erO7mxhe1siKl5/lhDcOmHZj/HuTt1FBfa/W2nbWk2E3gt6Wbs FHkoVa9gMk7ko1ejnMJe/hOVmrDOJnZoszg++2HUKJ4FbmJyukTwENom3D/yWbU5t7fN c0EYE3nEFUfG8RgYMKXdo2w3L2WAcFXtJjd2Qew88JJMtvLe3KFN973gI0KBkDiZRLwD RIwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136768; x=1787741568; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9bdVdt7FL/tihS7EYxxhgHwIGgHm7ch/dQjPbge2b/w=; b=VLsSRx4IpMNN0SgreBdc8HjQFYK3gyXCd3bfyjiKH6Y8CiKVx5M+7LEUu8X+LqRReY DXvLyVld895yMt+phEVQ9Btk1uDL0t+MbIY7kEpHgDFiJChqXQ9941TnhZAMKip1P74N K9mnuLFkCGow96nw5HoSMvz2YT7L0RiTuUVoUyul/EumAP7ea07mKIUvdq/IW6dQGXXr 73JYgh5WyOT78N7gKrndmmVhBk7n194phj9ey/DYvincoH+EeRrMGYcRH2zTQkruN7OW 57NuMCahteWI0++bVJRsC1DXq6OGUoP8602h4Dz2KwWHebe0nS7m20jAPKLnxIHBlS5H 98Rw== X-Forwarded-Encrypted: i=1; AHgh+RqusklQ/Ha7cbl6nOj3xn3cIWc6iRoIMSGy1VFXJvXIk0CSB/TNbE2HrmqErhlzgkbL0FMHo1z/FDaUuqM=@vger.kernel.org X-Gm-Message-State: AFuF++k3zBqPRqmcu+Qj5L7Npo8XGAoqMOwVgktG0yTwrD9wUI6/t0Qz qGTPx+4H/G+ipXXnCrrq8Yl4G2bVO8QPRRM8I9i3BImxjtv4pZLiMDea9bceUQ== X-Gm-Gg: AR+sD12qSq5itrpc85CrwriErYU3/luXqR9GN9CF4f20MnJqoHOC6O6WCfbCZ6Z/rKq qemUJgfp51SEZ9P79Ie43SU17Q6u5DU6YS1yAGhAjnSHobkAwGb3Z0bJVePw9t2JVmyQn3jgGDu /zUdU5sv2B9GWgjcdEkLWPR0J3L2f5xLCkr40X3ae/o3D16K9Gy76pU19jNhGz6FQefCDcAzZBz aVQffZZtCBovbrqOB5CivgViPwumU/JBZQ+ZHO+2VDyYHFH/YBzyNf8EbzYOyEC0Z3/DPk2WyDK tSSop0cRnYn8uKO+CQ79Mf7DrcLsF5bDGUcYPH+0cR9OD4MsYwyML4zQG2Zlt+/gqNtrBIwpTfb GA89iusjTYP/WXRsVvVJSeWmWuJPA7mrYUdUDgEWCcuKDX5E746gLp2ZnboXnZuskiyCUlOh5Qb ffF/DHE04j2jO5lajPwYkoOW+TlTR/nsy7Jl45sSAhyjT1JTQQG6YJj67CHAabx2PmgZrQSps79 gK4eoeFKfgFwH2dqcjiOPEmjdaqcDEgmegbn8NlsiJz5bd1 X-Received: by 2002:adf:e19c:0:b0:47f:9ac6:ca60 with SMTP id ffacd0b85a97d-482b1e1bc3dmr6597802f8f.0.1787136768341; Wed, 19 Aug 2026 03:52:48 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14c46f2sm6091273f8f.29.2026.08.19.03.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:52:47 -0700 (PDT) Date: Wed, 19 Aug 2026 13:52:46 +0300 From: Michail Tatas To: amit@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org Cc: virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] virtio_console: Put device on failure Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline If dma_alloc_coherent() fails, the buffer is freed but not the reference which is acquired before calling dma_alloc_coherent(). Fix by calling put_device in the error path. Fixes: 1b6370463e88 ("virtio_console: Add support for remoteproc serial") Signed-off-by: Michail Tatas --- drivers/char/virtio_console.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 62eecfa61646..de83a8a61a8f 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -451,18 +451,22 @@ static struct port_buffer *alloc_buf(struct virtio_device *vdev, size_t buf_size /* Increase device refcnt to avoid freeing it */ get_device(buf->dev); buf->buf = dma_alloc_coherent(buf->dev, buf_size, &buf->dma, gfp); + if (!buf->buf) + goto free_buf_and_put_dev; } else { buf->dev = NULL; buf->buf = kmalloc(buf_size, gfp); + if (!buf->buf) + goto free_buf; } - if (!buf->buf) - goto free_buf; buf->len = 0; buf->offset = 0; buf->size = buf_size; return buf; +free_buf_and_put_dev: + put_device(buf->dev); free_buf: kfree(buf); fail: -- 2.43.0