From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-a6-smtp.messagingengine.com (flow-a6-smtp.messagingengine.com [103.168.172.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 333AA3AA1BD for ; Wed, 19 Aug 2026 14:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787150859; cv=none; b=qKlA4uKwNz5gGK1kGsUDSLMduDo/pSVlgJ2x2U0NjClHZ4bnUJOyKiZGBHtK/WLj2Z1BAHQkZnl28VdXiRvwithBG2BURIzleIPST0Ea/dwz1evMOdnjN6ihfmVFHubCSHyq2kH6/sPaJ/78z1kxcbQR+RrjJk8bGgOLPZp/tew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787150859; c=relaxed/simple; bh=Lpc1pYigKk28/WdFthuH69B84/RKUYjkt5MKwUkrQog=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nGA565OZmCLJ0HSP2m6KpJdnTNUVEuItF4rYSh+Ni4xMm4mwSg9ddYURrgNLm/sh7hnA/sRwhlo1h9ihgsIG41BgOa57CG/n2A9fQTyTZiyAt7hA2RBhlT3uEqwP9BYv8W1vP821QIYoWjsLzvYXcWAypFifGywfbi50lb2EMhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name; spf=pass smtp.mailfrom=shutemov.name; dkim=pass (2048-bit key) header.d=shutemov.name header.i=@shutemov.name header.b=VtH5Myjf; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=WMISdAPi; arc=none smtp.client-ip=103.168.172.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shutemov.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shutemov.name header.i=@shutemov.name header.b="VtH5Myjf"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="WMISdAPi" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailflow.phl.internal (Postfix) with ESMTP id 125371380212; Wed, 19 Aug 2026 10:47:36 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 19 Aug 2026 10:47:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1787150856; x=1787158056; bh=UonL2h5MQ2AxCpmdIS2MMrVR/omeEZrC xIjmbzCsxdk=; b=VtH5MyjfZERrSnlCK/tHd76sNRNLWsBcJQ6EZUJryrrjzPAm nc3FtmqnXPUTOQZLuqNA/Jr2SQUhhb4kmnyCdXBT+kSirnErt+E6LoYdcroMbH1s 9kjw+FrA43VoSEu1dEIqgdkvmqkFg4FyBsixflIbhZ6/hB1tMfXBldUG7CBp94Q9 6lg8A/hXVDFC9Oon4+LMKgYAr+/PC7CmmBK/B0MadIxblEzL80/p6unj4ryRap8d uOOA+AtNLDAKMq1vAJiUzX9x9VxM7GIvU5UZIxhkVjNs0zOwKG5xjYswqDYUoRFI drJmX7pAG8DtWqgkaBb9uncX1w0pGGbJEXt+lA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1787150856; x= 1787158056; bh=UonL2h5MQ2AxCpmdIS2MMrVR/omeEZrCxIjmbzCsxdk=; b=W MISdAPic10bsGcEIlkzD91PsB26EFyQC3R8WpmyiYMoZBCBghS0dgJbk0Bc78hAF cTB3oAyj6zFjpGMuYE28HwfeQ/qNhmolmVgRI2/Gpvgbs0H9J4wYuqUaYsoZIq26 fLLT/BPNKdQktCAokCJqBtTfJdwfpxOEReX2N04e/HMJDBwW17g0yzzkGlcMMdUB JogKJNZClDvB5Vs3aHz7jzmq/0dgoYS/nzfxhUwFANr7+3d6pdPorVGTinK/uR35 pr4gov4b+l0YgYPWDO++SbxNvqMl4v19dPa41AWWZaCGZllMLY58+0rRnHT4fGHQ 8PBtRistOXlOzTF6SDeEA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTG4UQS/DVUAK5X00HSGpN6xmMu8uBi5bskMhLAP0oEuwAkNxTjLWFc3XzHZWIojDa s6HUbu4KlljgoIHpmjjTOx4CskWkaz7H+bLQyr6BFagYbQ5ilNbxpyk92OO/wSomoPYLSu alFr2PpG5Tgpfykgu2ThxJDFTikEpxo1DG0ZXxsvjS2CBtvS207bGrONdLVrlkZIpNIgZy Cys6AQnVD7k1LeiOWl8R1+zfKatmgbdACZjUwLulVROccyM2RRCINtUhMKfYPJuqXePvdH KEu67YHmszJuxP4JkxeKwBoZQB24kQIiPlGXynhOfDWu+wNDbKwex7TQYI+4bJDJ1+Z9Kv mxAA8RzQ7ay6y+WsDyCh0749nUMJHjutpz/uYHRyuyvzFeXSVfCRqtOSFD59kMpzjNxvHB auLWTsdK/mG1rmryINKYTezrVxxu/VXB97HFl9yBsTeYVjc+qTLgjd7kaTem6vQEAcwAG1 lMStUDjJTdaDvrtdT4Wu3csq8jGvSkPkKXhhNKSDf/zoau7PF+y5KB2PF5oREXov+OVi7V 64dKi0h/MLf5D7wsE1ZgxlcY0EJtYF6C3XdD6hEIvGAtkO554SPq0Ve4O3p7EVkKdoxtS9 NaRUyWBfTJunetDnecaSNHIj7D7nFJmdwaW8w9bH3UT0IDMWQOChbjkWMXSg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Aug 2026 10:47:34 -0400 (EDT) Date: Wed, 19 Aug 2026 15:47:33 +0100 From: Kiryl Shutsemau To: Barry Song Cc: akpm@linux-foundation.org, chrisl@kernel.org, kasong@tencent.com, ljs@kernel.org, shikemeng@huaweicloud.com, nphamcs@gmail.com, baoquan.he@linux.dev, youngjun.park@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] mm: include swap.h in swapops.h Message-ID: References: <20260818115026.656406-1-kirill@shutemov.name> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Aug 19, 2026 at 01:26:07PM +0800, Barry Song wrote: > On Tue, Aug 18, 2026 at 7:50 PM Kiryl Shutsemau wrote: > > > > From: "Kiryl Shutsemau (Meta)" > > > > swapops.h uses MAX_SWAPFILES_SHIFT, SWP_MIGRATION_READ and SWP_PTE_MARKER, > > all of which swap.h defines, but does not include swap.h. It compiles only > > where the translation unit pulled swap.h in first. leafops.h includes > > swapops.h on the line above swap.h, so a file whose include list reaches > > leafops.h before swap.h gets: > > > > In file included from include/linux/leafops.h:11: > > include/linux/swapops.h:88:21: error: use of undeclared > > identifier 'MAX_SWAPFILES_SHIFT' > > > > A header that uses a definition has to include the header that provides it. > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202608181757.mza9RRj7-lkp@intel.com/ > > Signed-off-by: Kiryl Shutsemau (Meta) > > --- > > Basically, is this preparing for the patchset below? > > https://lore.kernel.org/linux-mm/20260816224609.308019-1-kirill@shutemov.name/ My patchset just triggered inert bug. > Reviewed-by: Barry Song Thanks! -- Kiryl Shutsemau / Kirill A. Shutemov