From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AA4E3A48E3 for ; Wed, 19 Aug 2026 15:32:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787153548; cv=none; b=jMpZgFfswStjMPzX6Sq+yzB0B9l78uq4FjdgJ4gTyxO3sIowIaqar4uDnFw04rbSnZCGET24iyohkhGqMIRnEXotI8CfBCTkK8ITq9LXU2ZDRJ7P4eofIjLIGXu9tCRslT+q7xSn7s7WRA4i6jQwWBUI3VFeQj99wqja+jGwlhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787153548; c=relaxed/simple; bh=WlsbvXpIHhObvIL8fONtVZLrCj5SVxmqZ7LKRIEZGjA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fedYusrujRkx2Vorxxt0nw0/6SG6tQvmvZl/1ipJ/YkpkqL8e8ffZpSpt2/dO93yvOaHV1X0kaAyVzJ6+oDHh8O4q5HZ01PmxOwvNzDuqJLse0Fmomw4ffbCgqpioyCZoL5QIScTVTdUhu2w2abLZnxnZEQQTz5QCIQXwnF5FlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ksX2KKDB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ksX2KKDB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FF391F000E9; Wed, 19 Aug 2026 15:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787153547; bh=ewKOz5SEkfcTwwQGB2UX2B+VSVTOT4ozicerKMh6CdA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ksX2KKDBevRjIArd5K+oDP+xXE64NaOZcoDHn57mmXP6WWGdCPv9ZRXJmeO4nWm/5 Fv3YZgHej98bbOnqAEM1erRVyXF1CMKhUENRKBeVorw1GSi229KF8G8Xt6xqFk5ybN zsGwJV/5M7o38gYcyhmE9zLMSyTd2lSMPLQ5k5hGOWlw0Zt9yBMwitWRlTs5tspTUP 8HxBGvCO+QZoUgpsD624bDILD0ZnkbT9Wc+RHmQRBud5OxmGaMCWtLFoVR6F3sObW8 +czo1pROU9p06c+Hzrm+axPJdMHCf3ZkayAKH9Qm8ORxcyYXKq0Y5uBjIoErIJpXjQ P3ewdnP4eCn9Q== Date: Wed, 19 Aug 2026 16:32:23 +0100 From: "Lorenzo Stoakes (ARM)" To: Kiryl Shutsemau Cc: Barry Song , akpm@linux-foundation.org, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, baoquan.he@linux.dev, youngjun.park@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] mm: include swap.h in swapops.h Message-ID: References: <20260818115026.656406-1-kirill@shutemov.name> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Aug 19, 2026 at 03:47:33PM +0100, Kiryl Shutsemau wrote: > On Wed, Aug 19, 2026 at 01:26:07PM +0800, Barry Song wrote: > > On Tue, Aug 18, 2026 at 7:50 PM Kiryl Shutsemau wrote: > > > > > > From: "Kiryl Shutsemau (Meta)" > > > > > > swapops.h uses MAX_SWAPFILES_SHIFT, SWP_MIGRATION_READ and SWP_PTE_MARKER, > > > all of which swap.h defines, but does not include swap.h. It compiles only > > > where the translation unit pulled swap.h in first. leafops.h includes > > > swapops.h on the line above swap.h, so a file whose include list reaches > > > leafops.h before swap.h gets: > > > > > > In file included from include/linux/leafops.h:11: > > > include/linux/swapops.h:88:21: error: use of undeclared > > > identifier 'MAX_SWAPFILES_SHIFT' > > > > > > A header that uses a definition has to include the header that provides it. > > > > > > Reported-by: kernel test robot > > > Closes: https://lore.kernel.org/oe-kbuild-all/202608181757.mza9RRj7-lkp@intel.com/ > > > Signed-off-by: Kiryl Shutsemau (Meta) > > > --- > > > > Basically, is this preparing for the patchset below? > > > > https://lore.kernel.org/linux-mm/20260816224609.308019-1-kirill@shutemov.name/ > > My patchset just triggered inert bug. > > > Reviewed-by: Barry Song > > Thanks! > > -- > Kiryl Shutsemau / Kirill A. Shutemov Yeah, see my reply, but this is more like 'Lorenzo's unfinished work and a mistake in his includes' :) -- Cheers, Lorenzo