From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C9873BF67A
	for <linux-kernel@vger.kernel.org>; Wed, 19 Aug 2026 15:32:40 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787153561; cv=none; b=O57i5KBhNIKThXPYlU2hkANnJnnvnlTujAduOlr8C0AxEQrNi8nyvqSBxQF6D33FQIKD7JfvZi2nEjrslu3a/p1cQnm+bKn5/6b3dlANNHwL0Nh1AquJflu/Z4qaMRuS/Wx6GOCmgYQBOu7KBObDvqu6cgu7derVhQY/+qNzXeM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787153561; c=relaxed/simple;
	bh=+K8E+tKJfRQdSKDDzKazUvlUOuglMuKmo/189G2zCOU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=oEdCcCFGEiOvbrRY6TbXRzbxmpyiSHSi9CMPDmmiTTNwUhhFF+mqkUbrzjh0sprFd9XTb5Q4b3ZN8/LGo1WjWdchhyR2KV0lQgRiXS2JeiF5R4hPsVKEzGaB1VTqv/fmG5+s8nFk6WnriVq+P8JvNUmoCT1F2xiMXC6YjbW6TUo=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=chxjo6m9; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="chxjo6m9"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFF861F000E9;
	Wed, 19 Aug 2026 15:32:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1787153560;
	bh=wrMXArZNFCALMzEhrXwHCWwussw3Va1bj4J/QoBh5F0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=chxjo6m9o85EXi2m8nni5EnDclBBLo65qxKowm6388IMJZV+jYkqkiMlV+LxEBq1m
	 dMZyFLI+/XptattdLZRRnDCy0D8TxonGbsjdN5asJjPvTZHQnEu3Ctv770LgV3FcMR
	 oWkjpWJnImWaSFVdirW4XWGwg6IFT4ufUyPZ8fhxvI+kpdhZzjff9yLNAhqzTGLgaI
	 0ES9yVaQbz/zpjuuL+0wwRUhIh5uPxXYJ7YcRgKgK0bt3UCcSyP3nBdns0ryBPCm5F
	 2KW8iL7nJY32FrNgVkAu2ayNWlrch5wxr6jZWI12k7RNrJ37CIXwb/b6j1KIa3h4re
	 tmS4Y9cH1XC5Q==
Date: Wed, 19 Aug 2026 09:32:38 -0600
From: Keith Busch <kbusch@kernel.org>
To: Xixin Liu <liuxixin@kylinos.cn>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
	sagi@grimberg.me, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] nvme-rdma: fix -EIO cleanup order in queue_rq
Message-ID: <aoXMlj33ku943CHm@kbusch-mbp>
References: <nvme-rdma-queue-rq-eio-unmap.v1.git.liuxixin@kylinos.cn>
 <cover.v2.1787121041.git.liuxixin@kylinos.cn>
 <66b08bdf7d4d.v2.1787121041.git.liuxixin@kylinos.cn>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <66b08bdf7d4d.v2.1787121041.git.liuxixin@kylinos.cn>

On Wed, Aug 19, 2026 at 02:30:00PM +0800, Xixin Liu wrote:
> On -EIO, the RDMA queue_rq path reports a host path error and then
> still cleans up the command and unmaps the SQE DMA. The path error
> helper completes the request, so that is double cleanup and DMA unmap
> after the request is already complete.
> 
> Unmap the SQE first, then report the host path error. Skip the outer
> command cleanup on that path.

Thanks, applied to nvme-7.3.