From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F65E3C1081
	for <linux-kernel@vger.kernel.org>; Wed, 19 Aug 2026 15:33:25 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787153606; cv=none; b=YVL0+MlMdIz//tNzv1ABXea/t8m9yIvQ0rxsxnuOpHnEPw3n0bSHHhBZw2Uk7lILWkDQAuCED7gidiZm9iyHw6hW7NFlv2zx7I9lZWGnfYhxm7+T+NCzE0aJn3Uu8Ps6yMAzrpV7zinWgD0xeTIAZDuInsj2SpkBI1SvZz0/zuQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787153606; c=relaxed/simple;
	bh=X+j1pfF8KyM7bjk6U0gup6li9ZlAvYNWvCRImpb4oxk=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=ExnAEj3rPrNvwFNK1LanR3p3w/KlemR1rl22O38E3KQe1LJl9p6bEIKxI+KkbNsEguTKY9Qq8DYXozUMUjn0uz5EmlLou0qQgMW3xVPhmUF/nGiR4MN7qZq0QKTNqCDLNAnh5cQ3QUy4jtatb8BIiYAdctNlOGMDM0FrEoJVF2o=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mpcQJS/h; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mpcQJS/h"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13C2E1F00A3A;
	Wed, 19 Aug 2026 15:33:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1787153605;
	bh=pQCYldpdidsXXOH3YCXLuw/VRa5qzRh67OUMoesUWwE=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=mpcQJS/h/s66BxR7H38UX6GA0nB0tRtuhQ/u/3TLWcdXkWW+ncI0rZ1FBS+CDR/Ni
	 031ygE/vDq2sImrUAdISSDmASSqZmo0oHlgMHXEm3mnM3gNdbZ7VU0iFAkxkJJIlaH
	 zvk5+E5u0FD5YZMAcYNCXZhdJFktnz9mVCeestzE7tOA1m8qcHY3CVSQ/NDWhkv+GC
	 0ZPGsRe/jBufWFUJHDAKjuRPksEZ4nkSIDNTXYrOAacuY/qBm0slP1ClQYsWVzbdP8
	 wozvzqRF37gWhXwXtvQmJoiXx308KcWLg/8c6DGpHkTj4BwFURA+yBxG7j7/r+SHbY
	 n5M9bNhtJfmZA==
Date: Wed, 19 Aug 2026 09:33:23 -0600
From: Keith Busch <kbusch@kernel.org>
To: Mohamed Khalfella <mkhalfella@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: add opcode filtering for fault injection
Message-ID: <aoXMw1CKFlecrXU0@kbusch-mbp>
References: <20260811231152.1138761-1-mkhalfella@purestorage.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260811231152.1138761-1-mkhalfella@purestorage.com>

On Tue, Aug 11, 2026 at 04:11:52PM -0700, Mohamed Khalfella wrote:
> Currently NVMe fault injection applies to every command routed through
> nvme_should_fail(), which makes it hard to target a specific command
> type when reproducing an issue in error-handling paths.
> 
> Add an "opcode" debugfs attribute alongside the existing "status" and
> "dont_retry" knobs. It defaults to 0xffff, meaning "match any opcode"
> and preserving the previous behavior. When set to a valid opcode
> (<= 0xff), fault injection is only considered for commands whose opcode
> matches.

Thanks, applied to nvme-7.3.