mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Tao Cui <cui.tao@linux.dev>
Cc: void@manifault.com, arighi@nvidia.com, changwoo@igalia.com,
	suzhidao@xiaomi.com, sched-ext@lists.linux.dev,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	Tao Cui <cuitao@kylinos.cn>
Subject: Re: [PATCH v2] docs/sched_ext: document that cgroup CPU knobs are scheduler-dependent
Date: Wed, 19 Aug 2026 09:48:59 -1000	[thread overview]
Message-ID: <aoYIq-QwrSBagFB7@slm.duckdns.org> (raw)
In-Reply-To: <20260819012157.220932-1-cui.tao@linux.dev>

Hello,

On Wed, Aug 19, 2026 at 09:21:57AM +0800, Tao Cui wrote:
...
> +The fair class enforces cpu controller knobs such as ``cpu.max``,
> +``cpu.weight`` and ``cpu.idle`` in the kernel. sched_ext only passes
> +them to the BPF scheduler through ``ops.cgroup_set_weight()``,
> +``ops.cgroup_set_idle()``, ``ops.cgroup_set_bandwidth()`` and friends.
> +Whether and how a knob takes effect is up to the loaded scheduler: if
> +it doesn't implement the corresponding callback, the knob is ignored.
> +For example, none of scx_simple, scx_flatcg and scx_central implements
> +``ops.cgroup_set_bandwidth()``, so with them ``cpu.max`` has no effect
> +-- the cgroup runs at unlimited CPU with ``nr_throttled`` staying
> +at 0.

SCX doesn't have nr_throttled routing right now even for scheds that
implement cpu.max (scx_lavd is the only one right now AFAIK). I'd keep the
documentation more concise and generic. I don't think listing schedulers
that don't implement the feature or specifically pointing to nr_throttled is
all that useful given that most schedulers don't implement it right now.

Thanks.

-- 
tejun

      reply	other threads:[~2026-08-19 19:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19  1:21 Tao Cui
2026-08-19 19:48 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoYIq-QwrSBagFB7@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=bpf@vger.kernel.org \
    --cc=changwoo@igalia.com \
    --cc=cui.tao@linux.dev \
    --cc=cuitao@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=suzhidao@xiaomi.com \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®