From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C541A9F97 for ; Wed, 19 Aug 2026 21:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174479; cv=none; b=RXKIc4qsFTSKwvdBUoELapk/LomMO6c2Zw1afssmEU0I3a1gxbfFf/Sy3CLOK9XkgWC/27oapM6LiEq9hXCDtdjj0itrNIO5PLVUXVUiaqZLmj0srrPr+1GGhKywRuwooxg8a06RzEj76W3FXdl711hGGM+/X8M/51bEM03x4U0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174479; c=relaxed/simple; bh=1sm5DJvN9JZq6zFJ3rudO9ha47L7zEKKAdXSC02I0m4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uEYQQoZaUzApa0M1ORGLgv67CzfDD8MOsZX3XbFphnx0eq4Ir7PmpqK1lqsmkIFrIvjuJm3ye7fNsptWsCS5IDRgYLJ0Z/DYT1VPmWYuiIMvJ5Ob7AhADhPvGclxEdac3YSinLI6rYMYgDD1psP9zxZtas7oKFP0c8UaSF6t42k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gNDEQ7Yj; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=hZbf4DBG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gNDEQ7Yj"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="hZbf4DBG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787174476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CqgpeVGn0RSIV25AilpufRbxuFATmlWL+zdwTTPB/B0=; b=gNDEQ7Yj7uPQ54t5/YSnKU7vgJwKAHpBXumRH1iQZseluqtnzlzCLtu64c6Gi3enIHvEV1 ymfY+tGbZzsyTrv0CbiJKGboMlUxQUaZbTEsyq3u7M6gcbbT/j4awdTZC5UBoninSuImsy Va4d+9j0CYSrGldwqsjkI0+2ULIKTAM= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-LhFVosnxPregaaUG7Yt-_w-1; Wed, 19 Aug 2026 17:21:14 -0400 X-MC-Unique: LhFVosnxPregaaUG7Yt-_w-1 X-Mimecast-MFC-AGG-ID: LhFVosnxPregaaUG7Yt-_w_1787174474 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9309af14fd7so176158185a.1 for ; Wed, 19 Aug 2026 14:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787174474; x=1787779274; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=CqgpeVGn0RSIV25AilpufRbxuFATmlWL+zdwTTPB/B0=; b=hZbf4DBGYedr+3yZZYyeMRt3r5Aaohe8avIvv5fmQ/okL4NbmjAzqXyI3UPyiI2CbJ v+15mmfBBBPt0fXT1H2uXW1ZtxATaPVt8SznQ6ih7SIPJL7cZWHSyLXCCupwXXTnI1mx RZ3NwUlLrDOEgJkjf7BbqC3pG7FFsTFPZ09S1o3vgN3J7EQ6/oCDTPU/HtHPVoVrrHFs DMYXx9lThQeDV35VFqOtDtW8jg4FlxB24rcTaPD5/52zESGuVsT9nXNbPmSC0KGk5Njt HxbDuWhlNHOd4329n9s70c6AQzjQWq+XPUatwIOT4ydNkZpMRP2OH2Xnfjq8LIVkaP4u +wvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787174474; x=1787779274; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CqgpeVGn0RSIV25AilpufRbxuFATmlWL+zdwTTPB/B0=; b=tUztWOtO1zmY8pCNRuECwnM+yKT1Mymz92+QcOiPxG8vjb0BkmukafXNVmip/oV+Vm lnIcWctjg2F78FgKX8mvvCxJfPRELVWfgX/fQD+/uahZbC9uDbN44MiTSsk/WQVzQKcz 1ucozJPY25Ap96frEzwin3EMjJtMXTaVxDA4bET5pbE8yUWvHw8A41j2zYEefFxo9T/j 4+FRt++2aCzQ6Jlb02bQFzd03/Wwgzok+jBx/euxbToNKGUeZlGFm3ZRn7uDB96rzKaY borZOypQYSta5+R9N7DWOE6tAtEqlKmRZYTx5CHiXofvVZ04cmzCGt/2T9LaBs0QKVbu inRQ== X-Forwarded-Encrypted: i=1; AHgh+RoKzBPufXAs5lQ5KZZrpZCNyowH7YOI4EYMK2LuLFzeIzN9Zw0zNYjyDCd+8tYdhFcP7qlmPdCdJIZRBQI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8hqzv3AU3RBuD5KFNCzSVZsoq6NpQ3XP/dJR6mya6gNDUQQ+y aAHESrBfbMPBCTq7RD17qpP8HzQRND1iyIDo4PH1LY3xtl6czTfpRvUfxXgYxIk78tJ11oNOZcN p2jrwP8g0r3Bky2A5db4WN4ZF02td1ZKp9tI0zp3VHNvVNlPpSkn5bfbb7r1pzjbahw== X-Gm-Gg: AR+sD11ti+rl5dz7f4m96CH6EHFOyw/eaO7vap2bH1Ptwmv4IWSiJk4/pqYoDA4E4Hp Z/KKi0sJ5CVwIdsKGKzsNSmtrGmb2oqgw1BVr99xeJrKuvl2ISsrv2w6HaHw2noTXI1ZWtig7IB hHwme4QqJdWEisLffrk0T9f93LQGiZjcMss2Ss6Y3UkZnjs6QzsYwtswV9K3DTkOoD4HuXIjwwy ub+f2IDbbs26RqAUSQRCIdgQUen3owUckgCLhD8b/6iUaVUWuVCJhdLzXQ/n5QnO7udXwKvKvsq dVUaUrq0tyNF1FEAfKI9Qeq+znncQI+qY4RGW09R3z4DyNH/lhlJfJpkCNmk6eFeYwn51M/CDJt bL3/jeYYpkHR89WpnXmiWvsJQ5J3fGBLu7DA= X-Received: by 2002:a05:620a:6010:b0:937:139d:592c with SMTP id af79cd13be357-9371e67ddfemr822212485a.38.1787174473982; Wed, 19 Aug 2026 14:21:13 -0700 (PDT) X-Received: by 2002:a05:620a:6010:b0:937:139d:592c with SMTP id af79cd13be357-9371e67ddfemr822206085a.38.1787174473413; Wed, 19 Aug 2026 14:21:13 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93720582980sm222991885a.33.2026.08.19.14.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 14:21:12 -0700 (PDT) Date: Wed, 19 Aug 2026 17:21:10 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Tero Kristo , Stephen Boyd , Brian Masney , Jerome Brunet , Nobuhiro Iwamatsu , Nuno Sa , Guenter Roeck , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , Andy Shevchenko , Sunny Luo , Xianwei Zhao , Mark Brown , Kees Cook , Kevin Hilman , Mathieu Dubois-Briand , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux@analog.com, linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH treewide 1/5] clk: ti: Make sure clk_init_data is fully initialized Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) On Wed, Aug 19, 2026 at 09:05:15PM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > _register_mux() fills in init.parent_data, and assumes that > init.parent_names is NULL. However, the latter in uninitialized, and > thus may cause a crash. > > Make sure all members are fully initialized, to fix such bugs, and to > avoid future breakage when converting drivers to a different method for > specifying the parents. > > Fixes: 667f420c09f1417c ("clk: ti: mux: resolve parent clocks by DT index, not by name") > Closes: https://lore.kernel.org/CAMuHMdU3yVqoyHC4eNF2NuYo8wy+6ODLoYat4R71X99Mxc_=kw@mail.gmail.com > Signed-off-by: Geert Uytterhoeven Reviewed-by: Brian Masney