From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 772A83B774A for ; Wed, 19 Aug 2026 21:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174548; cv=none; b=MttDgk3OwrIy45uf0sFXeDcBiQlmxznxBtK/xsrgUEk4RTz5eeIeJwrV+0gyR/xQMsqXPxUWpdHlPIJkSGfp05d79Ln6deuhrULGDWKb4j2VIaMHNIZNQod3J4QXDcgaifkprlMmwZT+C8uosn4T7sOmADYB7s3bO5jezYOomoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174548; c=relaxed/simple; bh=ZzdoD++VvHeUKmBu7FDDxPK5u0C7i3uGZGCaEX/ePk8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=prva9kZH/7MQKi8j3r2BndS4gdqearlk/gwQx3m34+tNg+ahBkbPMmO1uOJkiOsN0EkfYPe55Plwh8JiCBLtHWVTveZ+ceux++HdCNo7dHyRjDZpkiaS4A6jgl3hUFUepSXR2JtbfuxUU/+zIIU2wPiPtjUcmijMP83p6vTcuBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YGbtxflr; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KNeaH5Nw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YGbtxflr"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KNeaH5Nw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787174544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/BxA7XcUttIdzHWbOyyyGM4mWiq1VkGr6i1wmE/8c1I=; b=YGbtxflrEAiN5u53REcAnLty3/aygblrS+je+E6lnhIrujhP1jZEKjttJ2C20LlJdyJKPF 43JDxQO4m5ubCS1TR2QJEJZPWhxzE/P8sHLcjwKH2IFlaTp9K3R3EPhN7zlMnhIcV78PDu mPr89cx5lG/Ith+ZFo6lVsVAC+8jHJc= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-Ubw7JCl8MomaEbpPYrZLxg-1; Wed, 19 Aug 2026 17:22:21 -0400 X-MC-Unique: Ubw7JCl8MomaEbpPYrZLxg-1 X-Mimecast-MFC-AGG-ID: Ubw7JCl8MomaEbpPYrZLxg_1787174540 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-52d28f8737eso24153441cf.2 for ; Wed, 19 Aug 2026 14:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787174540; x=1787779340; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=/BxA7XcUttIdzHWbOyyyGM4mWiq1VkGr6i1wmE/8c1I=; b=KNeaH5NwoTLtvwqOqMMCgUy92YE1e2DS49yaxNI6PWtSO30S50ithGGWkZbZBBS9kV crb9/uMkIWqF3hYy9Y4SQyWEimFnYxwdUteEmOZgXIaBaonRP7jamZovvT9GG3EMG6KX jE4gkeVYWTYywh99g/bYqOQk5FNRJXAMRYsJ+MgSG60xzePXd/zQp0y2paGQhLKgmdYr QM9tpzVQUAcGjLn71bvuK/dml08tlQuGJTJVGPfyYgHuAP9vbidIw402Dnq2VVG1JYLF 06Zd+LufUJVgntF5pSqH/Qmkg5/nQiv69ynA1iI7aMvQEW5AMkWgojY+IM9KtvDMWkdC TBNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787174540; x=1787779340; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/BxA7XcUttIdzHWbOyyyGM4mWiq1VkGr6i1wmE/8c1I=; b=guAvAyGmqJ0ubQ5xgsdB3JyYGceGXuUNH74rsLqLv0jGvDlgeptYQ7z9jbVLyASUnq eIErzcjRlkkcCCmvnPXJHTA1M7hM79I9ntD7PG4t4AEY1CiK58I2rr/UM2mavqUtsEVp SFNNs/a7OiROfCwQs0+N8hjVKC1KuZpv+t6AdQvvV+uU1vP5QnaqbuBWExfGxjlZO5th Dw6vec3I5xBP9L7ecbH50GYtQFLFxHBzYGJrqfenkYeDAbaejAIhVyHoCp5dpLFBjpog wT1kBum9iXgnzSnd8mrmm4zUQCo3c7aEmBeIg9MjyFfneP5C38xzD5Hqnk3wF0+ek3Vd pxDA== X-Forwarded-Encrypted: i=1; AHgh+RripHKejvFQYS4O03jGBZMcFx6pOuCJpsQesU1lNAzlRNzH8Ik90cJFk3ZKM/XkWtdFUIVD1gkP/oGHmHE=@vger.kernel.org X-Gm-Message-State: AOJu0YyfkyImZPPm71FsMH3hw/vvMrTMVH6kHDt5eYUReLsU9Duv5cS8 IzBtlotBW2q+M1qjOVbMo2JTTh4B0S3/A709WYx5Uk9Xcax1mWHV2oA9zaXIW8TaHw+Gojf1Gxp 8aSAk25t6o0mYoFBYUIOl+2TldEtDi53tf7YhCMt/SwgxpoG6MIP52PVBahvlJs2jKw== X-Gm-Gg: AR+sD11p4301V7bW1OyEbZ3Kci3CU9GK1acK+blum7DJA5irVLNurXwLJsXiu0a/Whk rtXihEVX2XA0kBmloeEFCXU2XsZ6vtCp3G2eRKONyc1FN80rH5jJ7czEiaEw8rJaaUNO6x4mngV ydgWEWR35Yf5T5xWcuHWMXqkOmFi9aJu5RH3C6X7r7qnFArkW1g0LjqbQBhsiLePW0D7SgKlvyg Q5r8ovx8grRQeQCg5jo/VdHXFMJw9lHOiOkE0lNpLw9pau3RTHndGcu2+O909QHsjfCBsMtucqI gW6QTWnDE2cUNgQHZwW3/o3mpPfhGWAys+qPSDIMtDKQx0v6g5IjnySz6H3T3Rj2NJqnku53EA+ IIkkXuy7IHxqBXct8gS+/VCPbqQt2lNfNchA= X-Received: by 2002:ac8:5d04:0:b0:516:e249:e30f with SMTP id d75a77b69052e-52dd5e05a70mr71524851cf.42.1787174540389; Wed, 19 Aug 2026 14:22:20 -0700 (PDT) X-Received: by 2002:ac8:5d04:0:b0:516:e249:e30f with SMTP id d75a77b69052e-52dd5e05a70mr71524431cf.42.1787174539914; Wed, 19 Aug 2026 14:22:19 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52dd857b36fsm18734791cf.5.2026.08.19.14.22.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 14:22:19 -0700 (PDT) Date: Wed, 19 Aug 2026 17:22:17 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Tero Kristo , Stephen Boyd , Brian Masney , Jerome Brunet , Nobuhiro Iwamatsu , Nuno Sa , Guenter Roeck , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , Andy Shevchenko , Sunny Luo , Xianwei Zhao , Mark Brown , Kees Cook , Kevin Hilman , Mathieu Dubois-Briand , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux@analog.com, linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH treewide 3/5] hwmon: (ltc4282) Make sure clk_init_data is fully initialized Message-ID: References: <8ec3c5cbd2df675a938f090470f5da5f22008517.1787165329.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ec3c5cbd2df675a938f090470f5da5f22008517.1787165329.git.geert+renesas@glider.be> User-Agent: Mutt/2.4.0 (2026-06-19) On Wed, Aug 19, 2026 at 09:05:17PM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > ltc428_clk_provider_setup() does not fill in any parent clocks, and > assumes that init.num_parents is NULL. However, the latter in > uninitialized, and thus may cause a crash. > > Make sure all members are fully initialized, to fix such bugs, and to > avoid future breakage when converting drivers to a different method for > specifying the parents. > > Fixes: cbc29538dbf7d740 ("hwmon: Add driver for LTC4282") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Brian Masney