From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22CF53BE644 for ; Wed, 19 Aug 2026 21:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174578; cv=none; b=Q4dveCdrb3xc0XSSjQYOOHEEw/NAoSkOq8og2/vrYcgyljgxX2ZXPQzrFDe7ql7rB7fkmSMhOlYJQitSuyWr35RP2MdiXLlZ0DRVkJeojaLx85IrnByJaF1rBKTZc4aWd5fv9rXan4Ch6YUSbNRurYyANZuXpa2M/n2kBZrLeiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174578; c=relaxed/simple; bh=SzUr6zig9u+8VJEkLvWpenZdKF09X36HV3SolVfmfk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AqFx/iEVtvMc572BHP1tQA0MkPQnwQgHZyF6hd0UxnOSWmkdAAbQUoWDev6wIz3wdO+zgMwi/zkq4iB3tJqzgD3AbxyEA/Sccj4h1lhqbmSlEwsloUmQeF73KP4J2qW9wFTYQIh4ylt0Y5DU3NeTimRS+miGzkNwHQ0E/ImWjCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DsJpC5O0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UHBonBcN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DsJpC5O0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UHBonBcN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787174573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rj/mRgeCj8M3kWXn8y1lXKamZftjeOSlfCZmQd+Kztk=; b=DsJpC5O0nK/u+Q+SyLbxCfvDwcbYL+sGN8WTWgjwu9DfMLV0ZHeUe1DT/1rKUi1XrvNCT2 2aChBieHyCd9IPLh9dRfG+miZ/gCoFu9e/VXpEMh2FIiL4O4aZ4zz5H38rxouDUHqFC38f FXlFt3oN88f6YwrtMQMDlHpECcEhrFU= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-4hdYrvFsN26XIFXNAgNXLA-1; Wed, 19 Aug 2026 17:22:45 -0400 X-MC-Unique: 4hdYrvFsN26XIFXNAgNXLA-1 X-Mimecast-MFC-AGG-ID: 4hdYrvFsN26XIFXNAgNXLA_1787174564 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-907b38aaad2so18409306d6.1 for ; Wed, 19 Aug 2026 14:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787174564; x=1787779364; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=rj/mRgeCj8M3kWXn8y1lXKamZftjeOSlfCZmQd+Kztk=; b=UHBonBcNHqyKboom6YYt+t+ZK9mcVmi9cN0KODqFWGxuCu8/KOdMY7Ohc22sQO7iuO M4nJ2EDKe2ByFEhvifdxSk1qngxDudfryBdKJtudp1SyQV0/R4cHe/AvPqEdaWI6VIL6 lgiF5sMDvLol52vny0cHgEwYNS2V2vB5S8Qkz6+ndaPUnxl/T3ncyKDFoszphPM5Ooud TGhQ2cLKd5ebRQ4gygtai7utvrZIHjVn2fczOjPvwY9xXqBigxAiHKzuOYYguQ0vrxEm OGUP5x6BkHENkSk8KHmla3HLPCF6dfoTBL8GnWF9ZS/plqAZMyjywbxEtn90ScpWc/3D 9bBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787174564; x=1787779364; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rj/mRgeCj8M3kWXn8y1lXKamZftjeOSlfCZmQd+Kztk=; b=EbsPETEVx201CISNk/faU/YhD8e+Kfja1gZbY0Ie8QZFQeUNP69+tFNDVGeZN5f6lS 7bTzWoykZIFWAn+EgZkdcZU1urpQizSKmM22nAd52A7KUobX6fzZJcwA1OPCw431arn7 szGLFyl9evC33rhhkrRHr/M1tyEoRWsWBWuw6Q/x77zrQy//YnOypdGOsJVS6oVTIhni Rm7K5X2HFnP+KdRoezy+yeJEODNAbGNJTJsiKa6ami9x2iQU1xaKcX1uHL6RBL1tWwfh Qt0HT+edhtUW3bcyIHdr5PifdttjOH78lv/8nKriv9wkB8DQHIWEW7t7Ef+dlUwJBBkQ R5JQ== X-Forwarded-Encrypted: i=1; AHgh+RpHiJDOjscf+K9+gmL3+HG4H9g9VJp3luylGvBgMdarTXgAbMVUBHf91ROFHuYMzGDPAYMr9czkiBUBTUs=@vger.kernel.org X-Gm-Message-State: AFuF++k4Apyjgc/VkfTrQeBoe3tlxT3eJ72ExBQXYejY9E30ZwaLoBoT K9IothtmtmRxLH3WpnmFPetBRCCp9vCctJ5l7/GCwokPZB00JkpMO021S1sKVv5skZRm32Zsfi+ GQABR9ydxmtt56Wz6N/0+eCBH9qSig5CB+BQCjoRqQxxpzw7i33kLVIKQOinMHHRd6w== X-Gm-Gg: AR+sD12CcCeXC8fRDuFp25wvcwrbwADLkgorFQJ3SvMUSKKKQZI0bzJyCYoWq0STjE8 HiebwROnXV2Y06rZM8S8rIpX2Pv+Eb8bxiNpBwOYvV+bDQi9Rn325RDC0p6WHpBJ2UrVu2oknoL bvpasYusFEu/AVty46Fd7jXoJjsHdTcB/PCFJvj8OJcLoI1IBQN1DL+pHnieZn0+I47yYNR0bI/ vwlXLnzppS7QegeEfpdbYD/V3/Om36x4gTEhbSlQp2PwjcBYp84c/RdPkkQrzuE0Pt4THuVkjjr F4OIYsT1V8u+m0nXzjyRoG7tHA9AAm4gv8X5iBRGiEBz+QEdG47Q5BkeQEL+N9g80LlrbyEPRnq xfX7ZFaBHQW5yNhwlprisOKViQdFlqc+Xi8I= X-Received: by 2002:ad4:5dcd:0:b0:8c4:edb4:a44a with SMTP id 6a1803df08f44-90c5eaabae3mr79736736d6.23.1787174564268; Wed, 19 Aug 2026 14:22:44 -0700 (PDT) X-Received: by 2002:ad4:5dcd:0:b0:8c4:edb4:a44a with SMTP id 6a1803df08f44-90c5eaabae3mr79735276d6.23.1787174563736; Wed, 19 Aug 2026 14:22:43 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c5eee16e0sm23636866d6.17.2026.08.19.14.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 14:22:43 -0700 (PDT) Date: Wed, 19 Aug 2026 17:22:41 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Tero Kristo , Stephen Boyd , Brian Masney , Jerome Brunet , Nobuhiro Iwamatsu , Nuno Sa , Guenter Roeck , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , Andy Shevchenko , Sunny Luo , Xianwei Zhao , Mark Brown , Kees Cook , Kevin Hilman , Mathieu Dubois-Briand , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux@analog.com, linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH treewide 4/5] iio: frequency: adf4377: Make sure clk_init_data is fully initialized Message-ID: References: <302584628c4c0699239a0218376fe1c11cdc8944.1787165329.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <302584628c4c0699239a0218376fe1c11cdc8944.1787165329.git.geert+renesas@glider.be> User-Agent: Mutt/2.4.0 (2026-06-19) On Wed, Aug 19, 2026 at 09:05:18PM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > adf4377_clk_register() fills in init.parent_data, and assumes that > init.parent_names is NULL. However, the latter in uninitialized, and > thus may cause a crash. > > Make sure all members are fully initialized, to fix such bugs, and to > avoid future breakage when converting drivers to a different method for > specifying the parents. > > Fixes: 60e5448ddbec2dc2 ("iio: frequency: adf4377: add clk provider support") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Brian Masney