From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7187437C0F0 for ; Wed, 19 Aug 2026 21:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174590; cv=none; b=WoeD7XPt3lmZjsPIT7marKk+RO8BIR/ZZVJiw9XYyZeXovRUocCkgKNLMZBolA398RbGtaW+nN0Q54CpE7ulP2uC9Y2qGL9N2PzZNMqpx3xbfwYRKGYGSMSpA7m2GGvoawobXXM4ScDxXhrj3jamovNp7msNvKC1Oha8KOjwECU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787174590; c=relaxed/simple; bh=e86+tyxRdQKzE4t52ZefcteM0bRE88sbIL68NZYIiAc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZME9cRcqLWTF8wWhm6JJMgOKdrCUjbIQ5B/CMySWaro7Cpgh4f7XyU5qg9iNXvA29iZhvgWdPcHKiOaOrlYu2I4XhFDTAWIR8HChPQmwUe754ADOYi19C1l/eOqSHZXcVZOU9FhX5yRSZpE+rTG36ATNvzNqFZE+PCMFZ0yg7sY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UNzU2lCM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=JCKAFLrZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UNzU2lCM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="JCKAFLrZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787174587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y2Nq6oWt/A+GglsE2R04tSZrXRfphvvWNtrnE+gHf8s=; b=UNzU2lCM8vGP/ynJu6UYWXGCk6w7dVDtbXs2Ew1fNbDLkeCPOIhcDCATa02P4Lr/I9uPYs JYUM4xPAGMT8/QeMWtuONz+/MZ83Pyg4nQUPdIILyPPeqtCkhUNLjXCpQYeKCRx+4tbu/d NxY/KmvxMtzjxg6jPMx4fJpI+bNtpyc= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-HkRmnJTMPrCMB8whpg9HSA-1; Wed, 19 Aug 2026 17:23:06 -0400 X-MC-Unique: HkRmnJTMPrCMB8whpg9HSA-1 X-Mimecast-MFC-AGG-ID: HkRmnJTMPrCMB8whpg9HSA_1787174586 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-907c59bd73bso27648046d6.3 for ; Wed, 19 Aug 2026 14:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787174586; x=1787779386; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Y2Nq6oWt/A+GglsE2R04tSZrXRfphvvWNtrnE+gHf8s=; b=JCKAFLrZWsJlDyDL0n3WLYXT63egpUnZ+e9sB2o8Cu52PYgoPA+qrgX0HMk/lPmuhg kcZ+OnAOPFAPoYKI9SfWNtt/wNFfb/l1B6Qdpjt9TXkwa43DK7+RdPkfUnPYcbSp4trw Y17ETv81mfJFnM6opMhSYQfXk50NGBWU+qwk2peJLmDw+Ewga6+okxmFUof/ZIMerVvb 1M+0Hzo+ltWLG+vER+nwoKKVNLyJN8Nnj9uBk8EtwVn/j5vuBSOg0S9tvxz0J4D9NJmo mhM/RptbedIlUzfhAEYhLCvT3YX9QmZVBkAYg7TGMhcQn3/sfMzWQIBbnVAkWKY11f4X qF+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787174586; x=1787779386; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Y2Nq6oWt/A+GglsE2R04tSZrXRfphvvWNtrnE+gHf8s=; b=XZKK1dDWCWUSCugmGkk4/1qAGpQpMdA/pAoP2B+VgwXkZ6I0ruP7nkf+/2qGpv/uct hkxXlJKxxCLAFiuAm3DiWcW1sVbBmuaj1nC3c3GLLwXzhxR/YErHyl4pzbDYqwDfd+e4 fKyldgbYZI7StAtmfvhXggMiQbBnrgv3lddQrwjn8U/+l6m0A0/iB46XyEo/a/s2itmq a4DGUa2+oBlYPLo77FzJbLdNuUK+HK5CRw7mvryXWpKRVu8Cw1kLvBD4OuTLOI6Vlzgy ZmNMZ0poD1usR4I/1LTj6L+9vtJSSMJLi9uEA/pknBurBwMEoAejPZsdtCe4sHqm4iA5 lMlQ== X-Forwarded-Encrypted: i=1; AHgh+RrOuLgiJCPcYjjB4y3OmBMgBTc+a27aiHqmUIY6jVZ0vY4GBjzaVXEdoX6KWEp61cl2MEQ7ml3Eg5XlEIM=@vger.kernel.org X-Gm-Message-State: AFuF++ln2njq+bNFv8wWGABZX74kilQMRf/RqPZ2mnilxkms75PwfpOn qDGSreyj6OM3JqnKHlCfZ3w3Uws0MBlReReTKNAimCLjzjt7zDbqqthugsoSs9FSF9byroeugEK qvyPpTEqRr1KgKRQRPPVMuoszbbOF55gx+sCPYSxYB9g/Fb0eeOkd48OqMiGJP9VpYA== X-Gm-Gg: AR+sD11XHfqbSfV3fQ301TurMoJ+cyWtuvIIPUVSQGgCEF002lQniiJ6nQ0LX2EE1iZ OfGU1aXt3+3kzeCUy2B6HnVBG7k4hDiRdH+dYxIO23yH5rivGROC5rp43ErmPMzm4XnXgx/YIKj LE+26VMpl4HUR/9P9RjujdS9I6ko3qa87kGCsFaZz7SL0n7EOMD/09DMiQ+A//jf0GeqNcOb8tJ 6/x9WQWUo0x/62DQqywSe7vvIy8YPyCnunzEElWnhokzeK5AqvI+JNgF1Rev2XXAlrs3XGhvqWb y1vSMKaYomct3tHsbb0uYpokrhejNYheXmSD0mAtMfcfc9c3UepvKnR0azdBK7JY2bGm5saLpjp GR3b5K/nF7Gb0DcqP+Qp7Ik65OEzgYCc4G1o= X-Received: by 2002:a05:6214:260f:b0:90a:804a:968e with SMTP id 6a1803df08f44-90c5eb8132fmr77665786d6.32.1787174585754; Wed, 19 Aug 2026 14:23:05 -0700 (PDT) X-Received: by 2002:a05:6214:260f:b0:90a:804a:968e with SMTP id 6a1803df08f44-90c5eb8132fmr77665056d6.32.1787174585342; Wed, 19 Aug 2026 14:23:05 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c5f2a1139sm23455876d6.34.2026.08.19.14.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 14:23:04 -0700 (PDT) Date: Wed, 19 Aug 2026 17:23:02 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Tero Kristo , Stephen Boyd , Brian Masney , Jerome Brunet , Nobuhiro Iwamatsu , Nuno Sa , Guenter Roeck , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , Andy Shevchenko , Sunny Luo , Xianwei Zhao , Mark Brown , Kees Cook , Kevin Hilman , Mathieu Dubois-Briand , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux@analog.com, linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH treewide 5/5] spi: amlogic-spisg: Make sure clk_init_data is fully initialized Message-ID: References: <9fb35ae0aedb7a6db0db6c78a8193c7602dd9d44.1787165329.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9fb35ae0aedb7a6db0db6c78a8193c7602dd9d44.1787165329.git.geert+renesas@glider.be> User-Agent: Mutt/2.4.0 (2026-06-19) On Wed, Aug 19, 2026 at 09:05:19PM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > aml_spisg_clk_init() fills in init.parent_data, and assumes that > init.parent_names is NULL. However, the latter in uninitialized, and > thus may cause a crash. > > Make sure all members are fully initialized, to fix such bugs, and to > avoid future breakage when converting drivers to a different method for > specifying the parents. > > Fixes: cef9991e04aed330 ("spi: Add Amlogic SPISG driver") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Brian Masney