From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4572257851 for ; Thu, 20 Aug 2026 01:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787188531; cv=none; b=jGLrN7T02NC4K/KMQWV4zWzQZGSA00yWqbXU2jIQW4s7Ld/KBJZrJRMWTuGndcIHFYu91mRg7X5k4ffyKmc/sEtGlfeC9wD6fR7vyHJfuXKFjOce1PEJx3Y61R2uAPDGfcBUYzPtxYjtgL/1DKMLARiAfFXxXOcqhDTYVyil3mM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787188531; c=relaxed/simple; bh=KgpEoJCO3Eql8ygiswoOd4H8Lz4ky8d1ZHRA9p6pq5M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kGRLURXemBmeEEZY3eLDvgFFRQ/mylYfuji9bdKa1MkLeeOrXkrRUHdM4kb1LntWiEOHwcuLwXOJ+/tcsJvbKdD7FbuBjDrAoAWAhs2NsE2NdW/GskqpwrmTV5d+F8sGvBQ0924AMRfpYxUWefFYsWtp+UQcB08C7RCBDQtV2o0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MeKx6M3q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=We7l0jZu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MeKx6M3q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="We7l0jZu" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JL7WLo2491880 for ; Thu, 20 Aug 2026 01:15:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=MS9HKp5HNfB/B1jknKQleKYL L0pHPk+xwxCKcprCl8k=; b=MeKx6M3qvHSHWxmCQEEMJUEe08q1oSBR/aAEnlDy 6tGwOF6rXdSOmGyUnMuL+CEGSlE1zepnyDUPT0gmGnBC9ncYD9uodcuD+Vg9L9iz TKTThhaDyTdJmJGxEbsJrKKwZHd5oZs213CKsWfElgUkNAhS7qnPAthDzJBdr5bL ssEqv93PHkszioOLbY2r20RheHiWxx1yhLLVrunDyFIS82kyVVD7IkrP3OcCIHnb sMlnPHa21mP82AXczK30qeOoyQRd22pvyDZedZkwpIgQQUWOLD6bxt9+Uu3eMugg LgCy9o4KWLp8l0dMnpHqAaDecVlF3Fzq1BZFiITJ6Ybj8w== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5e83tnh7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Aug 2026 01:15:29 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38e8e864ef0so3145938a91.0 for ; Wed, 19 Aug 2026 18:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787188528; x=1787793328; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MS9HKp5HNfB/B1jknKQleKYLL0pHPk+xwxCKcprCl8k=; b=We7l0jZu1/TNkxK+0BJ867Xd0QIkbIH2NkKOtYlFRCbfCusWJ3ZXx4EVIx2xhm0KY7 D5/MKk1uyOMMvxh4MrFuQeWbwUmnWBVPXMqjbIzvhirLiSUWRGcoccE9LIPp4v4/gMSJ iZ7d8XHJrJ7z8yGatgEIxpRBvKKWztOLYE0GqM+s/HQ7tw8dloAuUwhhu8NFhZLwdbU7 8kYIIdnUrKI22eo2uiOnBPK4mQSWIq7NieCo1+9gnUsQjJRCT305EL6Unm3FwvznwQ2k DwkWJutomvXn2CVLdMfEq18t+ISIfnpsYK0UZiFbTD/16vFRxn0C7nDpwiar/9q3ktX0 9fSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787188528; x=1787793328; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MS9HKp5HNfB/B1jknKQleKYLL0pHPk+xwxCKcprCl8k=; b=NiWBzZ7e+tVjXv74C2BpuDUZia9d8B1pNHlabZROU6QCcT+bhtHkQ60u/Du/QNLq29 U7JgIVEwp4JycEoTIKMZZKg0Is3G4hrz2/0nsUmyXWLb+EM5nexfDlhLR9scVz/eS6nt 8mNe2vA0rIig2u4ZEqshWj5Uh7nYrx414Iz/cvMgOR8wqXyprz5GIjaEwMzTeaGdQuf/ Qat9LEMNC5+vSKj/ZbgWrtTKOJpWfJyRWlHm/ICF80E12s5IlojtkOSrhbB4wbrQxnlk 96webRcYA7crETdcYFLiPKwUw32sB4EBJ4xvLyCj7EGkt10vFM9pDC/9hfNVigtwB6hu VFTw== X-Forwarded-Encrypted: i=1; AHgh+RpGLzMvVlwkGIW/ibjj/zrLBLFELZEgKFQs0v7gBpmuJTktP2wUZ00Iyh7SLsReybh0e96UPQQ/XCre5AM=@vger.kernel.org X-Gm-Message-State: AFuF++nd+t8lUCG1M65nF/UZP8FxVPAyNHRXAHRqMDMYmK+hLw3EZyrj A6rpPuCmjFxFSPvdxpEtaRnPiEO4puFqIlq0G7Xup2M9NE0+wQweHJabDQKHLICxpfGdFd0E2Zy wypdNLZ7OUeEajduTOq657VoMTpg/UgZaRVUegcKp3ULArw9Zgu9YOzq7fHQrWLbGkUM= X-Gm-Gg: AR+sD10T/Hiy19hUTRKDcE4U2ieapf7RpkaBmJboAMwfGXGTbCvHTUwULFxZQ6AeJRr stUZvhoVhaN72iRGo6Xucdp3L67b7/JVQHRXA5kKpHGtnmvsO/X9BzJ9pqRVMP2HKidZ8LpQeMF GgijYwsRCDqkGxKPcI5+GfEmceAF6TYuXHuhU0+Twfz7OjoujK8ndRJgAERMeVPQlh2Mz6dqPSU F5v52Dyb9z1OClj/RGab2dyShm0lAnAoSOnNNOCLt0ZoNBeSSutAml4qRifw7BgZ55S5E2B0czj 1NhMMbhpmwLcD3LNgO11Qw4G6jy+mm6TTI40Tdzjksalh9LFgbvrlJIIIU48nWVvB4Gc7xA3Dhc rZ9IWnKv66hObTbc1GIomN1J74yLSV8FGENVn9q7bW6A= X-Received: by 2002:a17:90b:3bcd:b0:395:4290:46e0 with SMTP id 98e67ed59e1d1-39580accbebmr16841133a91.5.1787188528299; Wed, 19 Aug 2026 18:15:28 -0700 (PDT) X-Received: by 2002:a17:90b:3bcd:b0:395:4290:46e0 with SMTP id 98e67ed59e1d1-39580accbebmr16841065a91.5.1787188527782; Wed, 19 Aug 2026 18:15:27 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1416ae5f1ffsm18684875c88.13.2026.08.19.18.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 18:15:27 -0700 (PDT) Date: Thu, 20 Aug 2026 09:15:21 +0800 From: Shawn Guo To: Konrad Dybcio Cc: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] pinctrl: qcom: nord: Split QUP1 SE2/SE3 into lane-pair functions Message-ID: References: <20260819152356.904023-1-shengchao.guo@oss.qualcomm.com> <000076bd-b3fd-42dc-bd43-96ee9492a638@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000076bd-b3fd-42dc-bd43-96ee9492a638@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwODIwMDAwNiBTYWx0ZWRfX7K/Q278fFAMu Ey1yq+ttYFusW7pIXX4rqSzwl9BsECSYgihDUMjhdsq9v04b9ooKX/AuxidzK5T7IJ42cUzkaY5 9E978ygjAylzccDYl8G+A2ToYrd9ICM= X-Proofpoint-GUID: NKJy2jg4HZjBwlASOIp7OTM-534cScE1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIwMDAwNiBTYWx0ZWRfX2aGibJ9AxllO xTpNhMMOMDW2apHZuoxIUU9DsXYBTNLCWvdn8hcMekQBkr3eEh+V7an5eFybBgqG85OYD4CBUwx XpZlBvWiguLyRMW8i+H6ZmZcZuw1L+q0ijXc1QpFr3iSQzQ1BzylKBeM5UbtbCx3TSc8p2lQb7P HRzZ2rNUU4hUl2eACbbcELW6UfmDiaWinqKMY32tUPTORdSt4MyyERAhqKhlqcZK2mlrR1uOpTK SDRXjqqM/HYDj9LeIi7Lep9JzJOmj70YlP+IloXGnhT7oJ884kTZv/zMQT9hJq70Mo3Pc1UQ9U7 fHMGP2wgocFTJAwDeoCdRgCQKP/qlexvrZwMbHafZX7jBSMheixmKOCkQPyoIc8J6aFQ+MGz/cG fFPAviHb8aPHfFSGzWCsYr2EVSUMyTODoycyWJ0USVrXcspiHksTVAAHlh/Xba9aC5u+rYQiNLk RI0X6Mf7Ru4R8aTY06Q== X-Authority-Analysis: v=2.4 cv=cvmrVV4i c=1 sm=1 tr=0 ts=6a865531 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=ScvHTCLV6CLG8ETh_pMA:9 a=CjuIK1q_8ugA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: NKJy2jg4HZjBwlASOIp7OTM-534cScE1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_06,2026-08-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608200006 On Wed, Aug 19, 2026 at 05:27:34PM +0200, Konrad Dybcio wrote: > On 8/19/26 5:23 PM, Shawn Guo wrote: > > QUP1 SE2 and SE3 pack all four of their lanes pair-wise onto only two > > pins each: lanes 0/1 (I2C SDA/SCL) at mux value 2 and lanes 2/3 (UART > > TX/RX) at mux value 1, on gpio127/gpio128 and gpio129/gpio130 > > respectively. > > [...] > > > + msm_mux_qup1_se2_01, > > other drivers where this is necessary stick an 'l' before the > lane indices, e.g. se2_l2, let's keep this I can see that for single lane function. But for lane-pair function, it's not a new thing with nord, and the naming convention seems to be without 'l', based on what I see from shikra, eliza, hawi and maili drivers. > > The bindings change must be separate I understand that's mandatory for new feature changes, but for such a bug fix where both binding and driver changes are closely coupled, it seems more reasonable to not split. Shawn