From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EF812D0C64 for ; Thu, 20 Aug 2026 05:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787202272; cv=none; b=mRNEgrdUEv0IY1QUyGqFawwEXjpeJpTx5E3l5f02BvMHobEpJnbFkv/NR/ZJomX2L/Ds15tQTKHUnawrI9pNwbhAVagzpK/YLIbH/6OSWaPZ0/FbdHyhsr9VwduWTJDowrsa9rR9wUeiAln5cZil/sKujtD44dscOQkRCQGdOnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787202272; c=relaxed/simple; bh=rWgyTn6rK4XbCJxZJD4LhM9i/3MU8BdRHuzZvLm9Sbs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DhLHoAn5XvuzhkU0JWe+0eO0MWQZEO7/0N9H+Q8fxbIiEsdr0HNvynKJOPEhyAaqM2qLshvva60uty1DkJUbruGSkosMZd9ayzj1x54G7VQlhDYu0y34KOur+NQiyVKGi4UTwHBHxi4fLNP/gl+IT/A3MJ8GFYQA6Qe4wAn1uwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=VbWKhDPI; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="VbWKhDPI" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4980dc26022so18331715e9.1 for ; Wed, 19 Aug 2026 22:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1787202268; x=1787807068; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rWgyTn6rK4XbCJxZJD4LhM9i/3MU8BdRHuzZvLm9Sbs=; b=VbWKhDPIUp1slH9Mc0e1/uE1RokaFsKGh+6VMH4XWr8wIZj54ZorI7TE+LUkCcCxRE SZqZ9vOMAR+f9g80p5KBvfcvHCef4L5we/FhG0toLfGrvfLpY9SaMGEFXVWRgVr3N6Ba TNKXRWj9Dz6PMLL0aC1T+6g+2rF3kTxoFRbZcq0JbT/me7g+1N27U3uOdMQgYYf30Bax rmth3YRZI0cQAg7XYR766zxZZAzG0aJrO+YpbHYHZuyJ+kf+kEHh20QPo5K/LfQzu2ov 6GxoyP13QVmcVV4yVQ1jqDUTMa1/CBZRsQn0w48DvzW1EMCEvTpdfrfuKYrS3JuNyxeM x22g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787202268; x=1787807068; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rWgyTn6rK4XbCJxZJD4LhM9i/3MU8BdRHuzZvLm9Sbs=; b=QCHl8wOm4q9z5vh41sQDlPTaGZIIeKGmbo/8WkeJ1N+hwC+SCZn1nno+9sDy/n5bU5 iJ9TuncFE49z7yekPahQzBha6YVZJycbiaz0gRgcMKFP2UwAoCzyC0N8GweZ+/enu/XH JR9dgbRcF6UOTQkqUqYVkK4f13mw9kFi/bdWB9r/BGzpgq1+0VcR69mgKLCetF1XaIX2 u40O/tAPwPXMGJUPqDRJ5jIlQa+PyuplkR/quV/Kk0HnIW1VrOdTkPvHqw4rApl6tAHO LIqeqq8MBAy6qCZjdWEVcdi2r4ZYhnrTxF5lAoSIm+fVnfdKiA3E5aye1flJv0WgGuKe r7wA== X-Forwarded-Encrypted: i=1; AHgh+RpD4ATfRyu53jKhX3wUu8Hs8wkDnyRAR2cdB3IXeqdJw8ubFZwkVAwjTNo8/bcVaPQ7XlZ9Cx5r4YQwMJE=@vger.kernel.org X-Gm-Message-State: AOJu0YxsWCmTxunh9qdkptmHye7nhrAKZEpGFc0EQAmWBIBwJ0QjpXqO NNiqvrNt1ZDaiWX75p2awM1m1S4I9N2pFJZ3pXlthwfaLlR6CSpbd8OHAudMxEed899sFz89XzY Wq16jvfM= X-Gm-Gg: AR+sD10QFeiSJkFFjjDv5EdMFg0jYSsYhklPrg62Y739mB9RsZhDVSRZgLazOPebcPX hlFw1LLsSxse9qmJzGJFIwUOYu4sdYlyqLDC07L33J7kixCpsDbvcipguyHYT5H+lNLUiDoujuu wHDfw3O7JmKNluj/uDjs75IgvF/wpxqmxhLGJA0FW27QwDJ/irARBp8v1zrdjf61+AiLEwjWUkv 9aeiVeF8e14CIGL96KX+lRSGNSQPJ0ztT+TRfWyy3NOPPzfuzkCKrZm2H7zttWjB5Zcvl2ZdKjV GLuz+C5dGsQattYXM5jKzPM61skTNK8nLSZb3KthePga4SgIYcr3yDhOs7z2xHfo1fBlTT85ta/ f4JFN3G+ZsDMDrpTMwdpH4KyfWw+ksJ6znQ75l13Qy9jmlkZNPbUBPDvYY1oOw2k4MlonlIXfAi OvmuGJem3bNNCfD2lMYpSnLt03ZMRKp1gVYEXXO2ogGgcug5B/HiWlmfv8Ab8SSXUYhA== X-Received: by 2002:a05:600c:46cb:b0:499:781e:25fc with SMTP id 5b1f17b1804b1-499aa17d75bmr139444565e9.3.1787202268196; Wed, 19 Aug 2026 22:04:28 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-499aca21c63sm122786465e9.0.2026.08.19.22.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 22:04:27 -0700 (PDT) Date: Thu, 20 Aug 2026 07:04:26 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Li Jun Cc: andy@kernel.org, geert@linux-m68k.org, fourier.thomas@gmail.com, bhelgaas@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management Message-ID: References: <20260820013826.1927061-1-lijun01@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uuls2gb2os77ohpb" Content-Disposition: inline In-Reply-To: <20260820013826.1927061-1-lijun01@kylinos.cn> --uuls2gb2os77ohpb Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management MIME-Version: 1.0 hello, On Thu, Aug 20, 2026 at 09:38:26AM +0800, Li Jun wrote: > Replace the manually defined dev_pm_ops structure with the > DEFINE_SIMPLE_DEV_PM_OPS macro to simplify the power management code. > This macro automatically handles CONFIG_PM_SLEEP configuration > and generates freeze/thaw/poweroff/restore callbacks, reducing > boilerplate code. >=20 > Changes: > -Replace SIMPLE-DEV-PM-OPS() in v1 v2 with DEFINE_SIMPLE_deV_PM-OPS() for= pm. It only matters a little, but it's DEFINE_SIMPLE_DEV_PM_OPS(). > -Corrected grammar errors in v1 comment. The description of changes between different revisions of the seris should be located after the tripple-dash below to not let it go into git when applied. I fail to see what changed for v3, the changelog seems to match that of v2. Also there is already a v4 before you got any feedback for v3, even before someone had a chance to give feedback. Maintainer-Opinions differ about the minimal interval between revisions, but three submissions within a day is too much for any maintainer I think. Additionally Andy requested the use of pm_sleep_ptr() which isn't even in v4. I think the same is needed for your firmware/arm_scmi patch and also for the bluetooth one. The usage of DEFINE_SIMPLE_DEV_PM_OPS() is an improvement, but now you have (at least) three series in flight and the trivial feedback you received here applies to all three. As someone who also sends many patches, I recommend to get up to speed slowly. Work on a single patch first, and only once you get that in---or at least positive feedback on it---address one or two further drivers. When you have a handful of patches in, you can speed up. But as it is now, you only occupy many people finding the same issues in your patches. :-\ Best regards Uwe --uuls2gb2os77ohpb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqGitcACgkQj4D7WH0S /k4GXwf+PBUiEnK/O/gv5HmrL0sfuqbjJ9ttvJM13PxVsci5xfOv7AL9F4rRPU92 JNcs2d7GZappgB9Zuq50OHnZCpHQ02pX9HYg5VujnMm6OcdTrcO6FRKfB2tEPWAL IQPsGotpyBtGnp3GiW/6iL/rHr/h/fWMiRN4UgtI2wbQczQdtgK9HFoy0aSmcbcK aAY7CCJHfJU35zlOhDlGU5YDzirEcalYYtv2sbVCEe0uVV3kreoNYr6Iww+XE/kj 345o6mDsi77XMvXDXApqd8TlIeBz/0n3ffd2BilhdLXZCREUsxyIoFW/YegYpVTW DAgXpEiYzUH7cyFjdHmSCa0waDnajw== =c2n2 -----END PGP SIGNATURE----- --uuls2gb2os77ohpb--