From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B19ED2E8B67 for ; Thu, 20 Aug 2026 06:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787208193; cv=none; b=Q31jyGBUiGXx72dKZQMq91uoenNgXpTuaa/CjSih3jSvr/pNHc27wvH4r6EiqeFnTWJC4rWRyMsmu4FE7UmIBrtliXkRu2xdcggo508y5aZpjCHI8YWRPvbHmAUcebDQljsdbyf69fwH1n5f5wXi4FjRDxc3BuKJPAX1Mo3I3a8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787208193; c=relaxed/simple; bh=nBbH/zDNMjwoP8ZNra58595y9Ef6/C662sl+FvLqUNs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jn2bMXfBXSHPE7HLSS3ZWYzWjYLgb53YhanFil/gqrVGyl4Rm3K0KLQCexE6+48umc/UoSki+gfT60HF2oTbu7qu/pWJDqhl5cXbxfHFtUdk3p+IYAGx7TWdTyRgzeoUgLlc+jktgQGnCLpfmBOZjZpM1ti9U3HovAzfsKH6HAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZluCD3ME; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZluCD3ME" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787208192; x=1818744192; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nBbH/zDNMjwoP8ZNra58595y9Ef6/C662sl+FvLqUNs=; b=ZluCD3ME/oY+G3ksy552TOxojghFpGCFwx4U/eAqZaDnWTT1EsmY0ChE uPIUba2peFBKkYt5hG6DZ4B4teH/izdQyU6/OS6r3rLWaIpqQgPoi/xcw cqmYhcE0Yd24xt382R8N3hx6szwnusEOMND23U/DVq6ITe+My3uAfLL2w a+a2xr/BPoKwsZPa+0BJekMizpT7xRFV/yeQlV2yWy3KREF52HhNF/BiC TVsvVVB8F2emCewJryt2hJM7+wuNSJf+bBky1JvsWWGbOVOuz7co0UTyL mOJcXIu28dARbm9YS5/q14/g61A1JJyAJ/TDIQ/KnUjb16aQDo4sKi/Hr g==; X-CSE-ConnectionGUID: sdMeEEjWTvCcj2o5kM9A4Q== X-CSE-MsgGUID: 6OyD/yBnSAeWUGQ4szVqsg== X-IronPort-AV: E=McAfee;i="6800,10657,11880"; a="91543522" X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="91543522" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 23:43:11 -0700 X-CSE-ConnectionGUID: oMcto3KBQhe1mSrh/zR0nA== X-CSE-MsgGUID: ZPqSGz7CQK+g2wYsOjZY1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="262085384" Received: from rvuia-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.1]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 23:43:07 -0700 Date: Thu, 20 Aug 2026 09:43:05 +0300 From: Andy Shevchenko To: Dmitry Antipov Cc: Andy Shevchenko , Kees Cook , Julia Lawall , Nicolas Palix , David Rhodes , Richard Fitzgerald , Tony Nguyen , Przemek Kitszel , Adrian Hunter , Ulf Hansson , Edward Cree , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] ice: use string choice helpers Message-ID: References: <20260820061113.4176623-1-dmantipov@yandex.ru> <20260820061113.4176623-4-dmantipov@yandex.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260820061113.4176623-4-dmantipov@yandex.ru> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Aug 20, 2026 at 09:11:11AM +0300, Dmitry Antipov wrote: > Prefer 'str_locked_unlocked()', 'str_on_off()' and 'str_true_false()' > string choice helpers over hardcoded strings where appropriate. ... > +++ b/drivers/net/ethernet/intel/ice/ice.h > @@ -35,6 +35,7 @@ > #include > #include > #include > +#include > #include > #include > #include This is a mess. I think they have to think (start thinking) about IWYU principle. So, please add this include to the each file you touch with this patch. Left the rest to the ICE developers to amend. With that being done, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko