From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 240D53AFD12 for ; Thu, 20 Aug 2026 06:39:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787207954; cv=none; b=fySOmMS7qk8OsApXTrxZFg3g1ukh4EEcq3ZhuMFPZa0XuEaN9xZ+3xmt0dErpCqjswDxBvE/JLF3ix/z65qadhYhvp4trDk/rEkARfcIFLGDxBJDD6/81guvEfOGKCrVdXEV3+BELtHapEd4a7eKXuaVT88L0tEoyoM2sSAWTpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787207954; c=relaxed/simple; bh=kIiBwig6j9yDAHCqmErWpTgnvM72ADiCUwb6sqGEplE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tEq66i1dwqF+WnOZc4nKcIkiHdfkzDuztkJhN1TW1HbR+GdTy6QZDn7szqJrudg6BSp1OXCkqwVJydYocU5z7+ZEbbxlZFnlk/91+C31z1TKr/SJg9HA/0l83urQIpH3wXALPwdTFQZ4d/zUjY5YDU3yAijx/Kp41C3FWSB4DsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XWRY3/Ne; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XWRY3/Ne" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787207954; x=1818743954; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kIiBwig6j9yDAHCqmErWpTgnvM72ADiCUwb6sqGEplE=; b=XWRY3/NeggdhA/IU63SYJ7hVfaHf453CMyz5Z0rQulEzZXgfVRMHD42x 8JR+HN4bIR8ad+13yW+Nf62v8+SI1PXuV6/kL1NkarsfOMmkCBTfXEJlU lTtxePMkARIUC8G0sqFewpqVS59INNbq4hZAUYxojTPaGqgpVN9yeggcy 2fWjDeYJI7cPaMhRYv97JzD9QALJ3ZRpmKPoMVwBIxMot3jNfjPMq6YDI FPYhY0HukYoPyqizpX14uSBtiglEdUvojZsTlPR02LBFShxXOtQ/nm3j9 cRFoUqeSiXzdXJT5YxCHY6sW8GFIs5bqZa6wM6SGoGxl4fRPdr+ZHeMFf w==; X-CSE-ConnectionGUID: 81oFpB2ZTmGFVsDG26aCGQ== X-CSE-MsgGUID: B0UnRe6lSFaLiAFeRJj1YQ== X-IronPort-AV: E=McAfee;i="6800,10657,11880"; a="99257605" X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="99257605" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 23:39:13 -0700 X-CSE-ConnectionGUID: KxHLThz7RyeJlvnFiPfrJA== X-CSE-MsgGUID: zU4DVn8CSqWhSxunoysgkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="266490397" Received: from rvuia-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.1]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 23:39:09 -0700 Date: Thu, 20 Aug 2026 09:39:07 +0300 From: Andy Shevchenko To: Dmitry Antipov Cc: Andy Shevchenko , Kees Cook , Julia Lawall , Nicolas Palix , David Rhodes , Richard Fitzgerald , Tony Nguyen , Przemek Kitszel , Adrian Hunter , Ulf Hansson , Edward Cree , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] ASoC: cs48l32: use str_lock_unlock() helper Message-ID: References: <20260820061113.4176623-1-dmantipov@yandex.ru> <20260820061113.4176623-3-dmantipov@yandex.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260820061113.4176623-3-dmantipov@yandex.ru> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Aug 20, 2026 at 09:11:10AM +0300, Dmitry Antipov wrote: > In 'cs48l32_wait_for_fll()', prefer 'str_lock_unlock()' choice > helper over hardcoded strings. ... > #include > #include > #include > +#include > #include > #include > #include If you keep in order you will see that this is already there :-) ... > - cs48l32_fll_warn(fll, "Timed out waiting for %s\n", requested ? "lock" : "unlock"); > + cs48l32_fll_warn(fll, "Timed out waiting for %s\n", > + str_lock_unlock(requested)); I would leave it on the single line, it will be shorter anyway than the original code. ... You need a cover letter and explain there how to merge. I believe the idea is to merge it via Kees' string/hardening tree. -- With Best Regards, Andy Shevchenko