From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEF32387371 for ; Thu, 20 Aug 2026 06:47:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787208456; cv=none; b=DuJzeRIUkFDyj4FulPRiK0J1adR35Or1N+ozM0HxhbbU4CW1JLFgeAvKIT3MQwAleJivUMpBx11/NAqkJ6iSZMcGwzLaLfJD/2R0Qenl2oxBgsJpqXGC9cDQMGG8J7nbdNc8oPaa9ClislPTJeHugngLEM5HHo7DfVv+knPryQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787208456; c=relaxed/simple; bh=GSJa1a/tv/fyEUKD0pmrULkbkXqiCbwCXGevjaf8pKA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DK6Abrwg6FXBw0BWpe6G4CLv8ThmCiLPiF60wt4oDEH2qcT1UsXqT0U0KrzK5urHFpzJvGHGClZZV/xQMg7k2ceAxg7AYzbDFj816mSMLHH/5aQLh6H/J26DppwnCGJ+kxCtF91TvoB/puta3n46r6UO/WDb5WqgPSMj7JGL868= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZF4+jaLQ; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZF4+jaLQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787208455; x=1818744455; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GSJa1a/tv/fyEUKD0pmrULkbkXqiCbwCXGevjaf8pKA=; b=ZF4+jaLQoePeus2aCkMTlpHonkbGwDN0Ra0FhkfOyjHyhiqr6yYTdoVV ICNNazfK4/pDCsF/XIkRFq2xlWIMw+gpkBe3BExG5RIJJ5+zjb5KnZymT JSvsMqHFKvs6+MlK+EVdFmMhCq23aHN8K/Jg2CHLTTJdyV12yl+RM+cEU PGOUFxqnc4DufXQ5rkqU3p8meFwAOI8GIsHgP+emrQtesw8JEu4fOvCG6 FpCfhVhFnNHu0b4fPm1eGwU7JgnSgwNTZp9GRgRW2y2LEeVL7c5saBAIA hSD5BHfcHSuYtb6zZ3lE+PIquP+5cVuh2CAVuvUPaKFzvcOUpOXZZH+Dt Q==; X-CSE-ConnectionGUID: a/kHoWFwR3qpj6RcwDAYcg== X-CSE-MsgGUID: Y5yRlEZrQjWYrlpT1Q8Qmw== X-IronPort-AV: E=McAfee;i="6800,10657,11880"; a="99258397" X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="99258397" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 23:47:34 -0700 X-CSE-ConnectionGUID: gvJtiHhqTm29XkpBdDBkyw== X-CSE-MsgGUID: C9bT3+o4RNuT6JttU9qELA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="266494661" Received: from rvuia-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.1]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 23:47:30 -0700 Date: Thu, 20 Aug 2026 09:47:27 +0300 From: Andy Shevchenko To: Dmitry Antipov Cc: Andy Shevchenko , Kees Cook , Julia Lawall , Nicolas Palix , David Rhodes , Richard Fitzgerald , Tony Nguyen , Przemek Kitszel , Adrian Hunter , Ulf Hansson , Edward Cree , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] net: sfc: use string choice helpers Message-ID: References: <20260820061113.4176623-1-dmantipov@yandex.ru> <20260820061113.4176623-6-dmantipov@yandex.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260820061113.4176623-6-dmantipov@yandex.ru> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Aug 20, 2026 at 09:11:13AM +0300, Dmitry Antipov wrote: > Prefer 'str_failed_passed()' and 'str_off_on()' choice helpers > over hardcoded strings where appropriate. ... > netif_info(efx, drv, efx->net_dev, "%s %sline self-tests\n", > - rc == 0 ? "passed" : "failed", > - (test->flags & ETH_TEST_FL_OFFLINE) ? "off" : "on"); > + str_failed_passed(rc), > + str_off_on(test->flags & ETH_TEST_FL_OFFLINE)); This should be str_offline_online(). So, either add those, or drop misleading str_off_on() in this patch. ... Same for all cases in this patch. -- With Best Regards, Andy Shevchenko