From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2F913D3D07 for ; Thu, 20 Aug 2026 09:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787217201; cv=none; b=ORPJK/FSy1t1iFYQKUhwyteUMZIZw036MqqAww3q/GOgsunF4n2My+3UXr+vUmpzgIwpkGqpQkRdk5bosrJ8ibqLSGfDoKdaQ2MNjGjXwXrBBEkTD4x8jCLdy69bwWFAcZnYKSKNpYJeNlVHu/3/9qTVSG4yt0bFC/rsYXdT3fA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787217201; c=relaxed/simple; bh=hPrJc7tLhkydvuvGvf8xRiI2Fvb0aBBPRteZTc4WY1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fr2R6FjUmwCoGI0xzK64CUNF+EwOW1RzJhWCwT9ONGwM9YwueHSWPKXKMMpF7la0Ykij+HdNlv1U0l0/fLIl0D8n5X2W52dKOA1zTTSvYv9sLL4XihelZPHR0qEWvgjgFiazCLRid0xaItj/yu5ncTVgRYl9YQU+22gQu3TWVvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QGE/vZTp; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=N59eC3mC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QGE/vZTp"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="N59eC3mC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787217199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DPZmMm/W2rtjcsEXGt7ZjhaQKZ8JdwFQHJlaLZYMDpQ=; b=QGE/vZTpNy9ze6qD4UHE0CSVAytNORTnHK5CItipGYYG7H6snHrBtnbtJYPB5w0Rk6IXB+ tE2MZ+gLXBIA/gsIMo0MVv6EDVv3iNdYFU4Hb6ec2O8s6x/l7Ap3/wc7oCqQBwqV2Nf4pf OGh57LaynZlPmZHjphgGIhEDDeEHJJE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-Wh5TPMs_MOeoirwu6nUu-g-1; Thu, 20 Aug 2026 05:13:16 -0400 X-MC-Unique: Wh5TPMs_MOeoirwu6nUu-g-1 X-Mimecast-MFC-AGG-ID: Wh5TPMs_MOeoirwu6nUu-g_1787217195 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-496bbcf7d1eso15890555e9.0 for ; Thu, 20 Aug 2026 02:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787217195; x=1787821995; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DPZmMm/W2rtjcsEXGt7ZjhaQKZ8JdwFQHJlaLZYMDpQ=; b=N59eC3mCXAMklYF9sZ4EJKksVRbp7AFM8jX118dP49W+Ub8CQNg2d3HeJy5MdUlJ40 h4Jpjo2XY5JS8ccSaI6qYO9qS6oMdfzqj9js+WRC+iC7W2fw77LMDtB7JZ5o7zBbL7EF I+db5Oc0KHyyLK7jrYw3ilCeABIV1+MjvQ0Y10PEGQbut1BkJVUEupAFj/pI0TBtn5yl hLyS3vKWtOxHjYc1ddLsC69knx3NNWq84p9GelJFiGHux0IH+wqWsctmDsAjcTP8CLYI bryeYJP5iW4oQZvuAk3CFvnRYAx3aJPPDY955xzMGC6y7aqE+DKMiWcKQ8Kqre6pSPsD kXyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787217195; x=1787821995; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DPZmMm/W2rtjcsEXGt7ZjhaQKZ8JdwFQHJlaLZYMDpQ=; b=M2SAzARZ12dKweGg7778YXoliDsIFPrEQWpvYAeurjvpThSPlHejncFsfORwIoSlg4 2mqYmT2JTyJ9hJKYLnKb4/WjthrNlt02ZlOyTDVsap7FUVLcU5BbXxSavdoZC8/A7Xxn zTNPMX/C8X24lou0PemtExerpcBYRFIIb2ggLuS7Ge7E44D8qZ5b/1De/jH5xfa1VthM qtkVo40JIQ0YDXpjvHPIwH8yRIC+l9+asvLhsgNV6rFGTLr/8a9mtaU8eJi4VPEeyWaS KqM7u6SdhFEDaIW8uXE+E2U1i6PwYa3r5d8HVjDDepwPwHOdxtGSCJlZ9xLzOMv4IY82 ZASw== X-Forwarded-Encrypted: i=1; AHgh+Rr3FiCTitUVKWh45QD03rOiyKuSkAxmSXLRwwWhxiaTg7AtRNPPcNPCyZ0UooE/ACMroAJXrO+6WHZxSCM=@vger.kernel.org X-Gm-Message-State: AOJu0YweM48BZWeAh6IyhnmOam0w9zvAmnh14wqFx65cv5QqOfmAQxM2 +vqEnwVco/Eg0U8JqncuIfxw0ArkimKw0YEFDZ8kk558QnILwpcS3N7cDcn/K6bexryYaFyEy0x EugYepgebwXD8LtNww967WnfbVMd/qqkQ8gYegLktY2hWRXtAc15tlMm8U92DtFCNcw== X-Gm-Gg: AR+sD127arxirH3RD5vITln7eaJVxph9DSg2kuuhmvdkjqtO8aoxDv9qioilGV08j29 Ph+elBB7VnwSN5nCkKNKlT2ML0ClsDxo0qczalTEHN+kt/qhd1jFPLjP6ug97WylPM4Tps05ao8 AWvjpMzJU+kPM73npsPmxkbNJ3svbHZMmMLEDvdTSvNK0PR/6OubYQCcfdJ+hjbwtLCOgf0KDiH hmdGK3/wRvngSeojsNUwGEt6lmmyFFrhSHeeqof1zNRpr/voABThzYgL6NsuhVoMLx+6OF+YnQ/ WI+XWNyvvy4ioYQ3soEwWhBD47KE1ABA4jzM0vVWgyurRAOXF/eTRVI3gw3wtuZ45qlpVk1nLXg 0IVXSdvPLNBOlV2ksxZWL0+inElRL0ppPkqITwyIkmJ2JggLmyZda X-Received: by 2002:a05:600c:3ba2:b0:495:4d88:e630 with SMTP id 5b1f17b1804b1-499aa1a93fbmr209390545e9.10.1787217195303; Thu, 20 Aug 2026 02:13:15 -0700 (PDT) X-Received: by 2002:a05:600c:3ba2:b0:495:4d88:e630 with SMTP id 5b1f17b1804b1-499aa1a93fbmr209389755e9.10.1787217194814; Thu, 20 Aug 2026 02:13:14 -0700 (PDT) Received: from sgarzare-redhat (host-82-53-135-154.retail.telecomitalia.it. [82.53.135.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aa0fd7a9sm164548055e9.2.2026.08.20.02.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 02:13:14 -0700 (PDT) Date: Thu, 20 Aug 2026 11:13:09 +0200 From: Stefano Garzarella To: Jia Jia Cc: stefanha@redhat.com, mst@redhat.com, jasowangio@gmail.com, eperezma@redhat.com, weiyj.lk@gmail.com, kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 2/3] vhost/vsock: discard IOTLB when ACCESS_PLATFORM is cleared Message-ID: References: <20260820080332.313933-1-physicalmtea@gmail.com> <20260820080332.313933-3-physicalmtea@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260820080332.313933-3-physicalmtea@gmail.com> On Thu, Aug 20, 2026 at 04:03:31PM +0800, Jia Jia wrote: >Clear the device IOTLB when userspace clears VIRTIO_F_ACCESS_PLATFORM. >Otherwise descriptor translation can continue to use mappings installed >before the feature change. > >The common helper invalidates cached vring access and applies the >transition even while a backend is attached. The backend remains attached, >but userspace must configure the vring addresses for the new address mode >after a successful live transition. > >Fixes: e13a6915a03f ("vhost/vsock: add IOTLB API support") >Suggested-by: Michael S. Tsirkin >Signed-off-by: Jia Jia >--- > drivers/vhost/vsock.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c >index 9aaab6bb8061..e1e9d002d6ae 100644 >--- a/drivers/vhost/vsock.c >+++ b/drivers/vhost/vsock.c >@@ -865,9 +865,11 @@ static int vhost_vsock_set_features(struct vhost_vsock *vsock, u64 features) > goto err; > } > >- if ((features & (1ULL << VIRTIO_F_ACCESS_PLATFORM))) { >+ if (features & (1ULL << VIRTIO_F_ACCESS_PLATFORM)) { Unrelated change... I think I've already pointed something like this in previous versions: for a patch that fixes a specific issue, these unrelated changes should be avoided. Please keep this in mind. Stefano > if (vhost_init_device_iotlb(&vsock->dev)) > goto err; >+ } else { >+ vhost_clear_device_iotlb(&vsock->dev); > } > > vsock->seqpacket_allow = features & (1ULL << VIRTIO_VSOCK_F_SEQPACKET); >-- >2.34.1 >