From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D65347ECF2 for ; Thu, 20 Aug 2026 17:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248223; cv=none; b=CrYCUrmKPX42i4SLK1jCUg53XpXwNFfFnZg1jIuhCRqR2+F31hZ7WRVdpBltFmzrMdScoJ2vgN7Y3pVmIwSHDJDlPZrRoUhtyqrkFsnx2/t9/G/bIpT7MQBxZg3NdqXLk7pfNWT6P/aq66FRGTrK7IMDN+FgxbKysEXT9Zy3ZqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248223; c=relaxed/simple; bh=azL6pMfssI+o4ECBFo82B22ejlVXeit8z7j5FK+aJfA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FjCNstcnFOSBMtBn7fSahwXa6Co6vTNDz1j3AjDaRPLpaoEOxkjUpZlh0WUDNrImUnXIGXajssIInWmO2CITi8rikoFllx+mQzO2gZ3aJX5SYfZdsR4bCiu+MnMbaXDRsgcAVT2nYV73qM8bLIjpzaPC5aCfHfju54d49rDp42o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EKXuBNHU; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EKXuBNHU" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5b01146b205so72272e87.2 for ; Thu, 20 Aug 2026 10:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787248219; x=1787853019; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9jFMUvzYyyAGffP4UVV5ruK5O8NFOvkXY87WGr65ihE=; b=EKXuBNHUhQabJzXgvkEafdwQxBYUfaB8PCYxTWoXW5+SJTPQcDSJiAaOiE8TwcPI2G 9GQBntgiatGHZQtjpC72sClJe6UldGgTDYyUaZHl7VSRmZEs4pUZBzCynYn373dRpH4/ whSIPpmNh+WmH7i1BE/lCxCa08LLJYjs4hU4MZOWn2NnTUUpglQXeuCPmsmFKQp+FjT6 RfpJGHoXV3wrnR/v+R9/UeCcZoWDCjkm2w/d/jiqM2n5lQduGxTF+lvT6/RtVGt9YYx7 B0qWRE/80rP1a9GvBEU1Xuk2AtFtBrT/w5dRchJsouqdFuA+cHJhP9rMygbb6PagM4hS 3I6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787248219; x=1787853019; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9jFMUvzYyyAGffP4UVV5ruK5O8NFOvkXY87WGr65ihE=; b=QvSYA4cn2naoGkj7kkpXIMo4Nyu4D45rFhjkWLscFT9jBy/OGN/GWXWLpYw9h81w85 9iCjiyAWNtiEuXZLJOW95fNOu8s21gO1P130qicXps7mNPK0z2rOCxpRyGSiBrgPNEo3 dwNUDLi3e7p9xBYT49sk8pdPktDdTTLYksfQ3M1/atN9NkneE/l2QEH3hvncFYn1bwrA V3u0suyNHuWNUf6QNUD36tGtzJML7hT8jMIelgJVJiYFUlSprhW0Iq7b8og4y4jIx215 juOs8wU9dyYtDYcolk8zq/aR4qH1JosQJpMl1taFuXoJJw5EENu4vC6n+lJNpkZRWq7L NGqA== X-Forwarded-Encrypted: i=1; AHgh+Rp+x/f8Lnah9Mz5xtRcPivPRw2MgXUzDIMYsfTzcCB4TSe4m9hIaCiKuZZwGisYjqZYw1q4NRLNkOEjLUw=@vger.kernel.org X-Gm-Message-State: AFuF++lrTUQgu2NZreitcwMQR8s0jryvI5WroblZ2eJLL8bD6gRRY8WJ JzDu+nO0WMHKmPJE0jZzWL6vcqUPfYE8mAsdmRKmh070zgc46DP06mL9 X-Gm-Gg: AR+sD11HWeMfIoddDKQwK1gks+b7dHjY0aY9VVL5ImUNLaiihhlb6X47SlnTSmhNWta ttBjA8a26j2nfZsmnnCvifnYFjG4oV0hWzrvxrzk9LSAvZ+Da5yjjCuKKznwg55zVAL4xX+mvZ2 kTe14LW1E/JbKaysjttTNpUC7Gupz//RZXXbz0K3S+hVsTlSKQMJ4r7DFJA7hnQVKWRWGKpfomi /KaiV0V5Nk5FV97CwmsH4/LdapjEkzDJWSmfsFgwtB7FKxbFRY7y75UaeC8ZfWiEdPRE9RayhPW s4b9ReyrwLVSMTAEU1VZUqYv2bEFcQg6Hdsb68YBOFzZPsXHAaR3/38uUdCK8xndkMWJJmmOaha msaaO3bLEDfkprxjkp1LzQ49O/fiLGvfcrhYv2xegMT9jZP6mumxcYcJfvpFueBUZm94Niu0O+f TKzvxu+oSuVv8YKT6PDpvs3da/M9VeOmh3CmakBWkBE4oZWjgjZDuw3dJ7JwqBqITwWwXj7cp1Z fcox1z+1Ja98VyAdmp3H0Rl+drNSgMU9/rJxaeA25b7B00+G70eDGtd6vnx3rqrQ/L3EU4m82bo qLC/ZJLNwZbXuFQ1rY0Bhd4SoBk4VmtlvQ1mWvOpiWujm7KtQvvrIPf0SLhAscCLwqvdXTM= X-Received: by 2002:a05:6512:304e:b0:5b0:22a6:6b13 with SMTP id 2adb3069b0e04-5b48408197amr57328e87.0.1787248219056; Thu, 20 Aug 2026 10:50:19 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-a476-1a01-141e-2b69-987c-d72d.310.pool.telefonica.de. [2a02:3100:a476:1a01:141e:2b69:987c:d72d]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b478860c85sm1419706e87.35.2026.08.20.10.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 10:50:18 -0700 (PDT) Date: Thu, 20 Aug 2026 19:50:16 +0200 From: Karl Mehltretter To: Amir Goldstein Cc: selinux@vger.kernel.org, Paul Moore , Stephen Smalley , Ondrej Mosnacek , Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Christian Brauner Subject: Re: [PATCH] selinux: preserve user SID across nested backing files Message-ID: References: <20260820061349.10542-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 20, 2026 at 04:32:28PM +0100, Amir Goldstein wrote: > Sigh, this is so confusing. > > The fix looks correct to me but I would use a helper selinux_user_file() akin > to file_user_path() instead of open coding the condition above. > Good idea. I initially had a helper and should have kept it. I'll send a v2. Thanks, Karl