From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE8437E5CB for ; Thu, 20 Aug 2026 15:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787238582; cv=none; b=XoKDU+UH09fxHsAKrYGZYepD/F3gm7YbD6XnP57417RpbfZxDrOyLkW3ek9Zc2vGyWYS//5kwR3OfCMGHxhS1Vq+wfkFUDlQuObNAM0Bzt+ypJ7MjV0eK/uq51THaqNTnTE5eAme1ly+HVdMgyIHkn2nVyJ+m/PECZAN+bgKKzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787238582; c=relaxed/simple; bh=Pf7JfpDwX4+Poty5IvXCho7jfNMVaUeGZfsawai3w+Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nm/bLBs0/E4s+eql3mp9Gjs3gqs/WQtEASerBXOVf2oFZA7I0GIjQ0TTY9moaZQ+vNfeBCU3fim+Iqp4GP86Rz5zH6dgl9Lq/637zWnMP6ae7SbdjDHjyv5gmqEDAkcjyP5HVi4UkDw/SLaEDtRJNpewrG3n1ZLv+4zrqcV7xhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Lq84vHb9; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=AQ97GUsW; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lq84vHb9"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="AQ97GUsW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787238579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bdrbfrFBNKxusVF2TTjyC1jQzKOXzXeYZT+7fde0g/o=; b=Lq84vHb96TyMVCXUxY+BLYYgbasJFt1/0JmUNZm9jWVCftTla3frWO/oSVm2M400Ed8sSF oSP2ljfM/6PSBbct7zP/8zbN7NZDveWBYNAuyMysmaEx5gD4bosATsHTvjQQkgL2fQt3YW iG4uOf0PIpVcoXMdzQQia0R/uohcVvs= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-RhQM_IBhPHCd_yPLOw2A1g-1; Thu, 20 Aug 2026 11:09:38 -0400 X-MC-Unique: RhQM_IBhPHCd_yPLOw2A1g-1 X-Mimecast-MFC-AGG-ID: RhQM_IBhPHCd_yPLOw2A1g_1787238578 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c0e702df8so31226591cf.2 for ; Thu, 20 Aug 2026 08:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787238578; x=1787843378; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=bdrbfrFBNKxusVF2TTjyC1jQzKOXzXeYZT+7fde0g/o=; b=AQ97GUsWfZY3ZAu8YHlZZ/4M7/r5oVxCDC+sayCSy03SlyjGM2ROKyLakymusVQn4P uQwCaD/uWjM3HNVhO3GIyRDZU+yWnkkPg7OZYw2OUtpL337GpdGRUkXAAPDFpt3YWM+3 gg0HTLQ47p3C6/N8UjnjB/8QGiYp4e5NaYje6YcZeKmf8m8B3QqmDvb/MNPbvwtbAPDf d4u4KvY1objv6d59VbONhw3IQAxNeGVacO0ndGTPMRW+7h0kRMQhpOmMCwsXY3U3ITn2 2w+wGCI8RlQoW2aDZuDg9luevyINmPzk3Fz2VDY15abkFbLTqd/FTTnyktjH7J51f8kc IwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787238578; x=1787843378; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bdrbfrFBNKxusVF2TTjyC1jQzKOXzXeYZT+7fde0g/o=; b=TNi0OK/0uqAiAbSHf8yzOSPe2a5Ikr8iurRLVjcZjNKAI5wyvVBXwbHsrmaOJMUiCb EOyg0FxvXi8ujo4Vjkf4GVT/G3NJWz7Fh33Ahl0T2iGt6ZDsy+rWqXHO/kQSR8p1XWd7 3wYF+jhqoUZHtIyDrPVFCjhpeY0zQbbYA2qQ4GhxuFcthrzLVNgRMlfhrExMMESYHr7b la5dEZ4a+wBheQIurjmNoC8B05VObAJm/O2hCJl7UH9p6pop6Wt2O7f/sCfg5cDVwYcl GjO5G0yQwb4yYR7gQTithiQfM3SiLWVnfueU3BrnhMADATW2xz6bzv7trpqswkrY8+w0 UAyg== X-Forwarded-Encrypted: i=1; AHgh+Rr72f0eLhoHIW3ec20ptlpE5aGQ6jk5HDxP2ftknVftdwxdWe9EqDJcao2i7fPxnp2DyyM+rHlmoOURi4E=@vger.kernel.org X-Gm-Message-State: AOJu0YySvc2SD80AVZCLN27ZiHed+fcgKmlYyC7sh6Ksv1XQtCA//5r5 qbfUGAFYNFaHgZ9W1aV121AxJbt3POc/6MjLJrKGrWLkeBKM/apcBqFNGSAai8RseAUwgJlIa7T elWsXj2uadKgYVpTBxHMvAzssH3xrxzuLde6lmZVFO9tJMI1o77RREoKaCTaiI2OeKg== X-Gm-Gg: AR+sD10V8aGqIzY1iTnZIHQO6rcHhoXh4m/rDyvG3csVBKH0gd8Qrvn97CzpmlrL2q1 jyQBuXoVZV/XD4263i9DwnzD6pW8QZeoobWM4hn/H9Jyc62uE0AJlq49/Miq5DKlDDUCtrA9h14 2djIdDPKwp3H1vKb2klfkJO9ZrFQtLcLpxObJKDmrN1k0v6zyOOyz6rS/7sKLhTjqBYZwj5O7zR bNsYzLoLRsXucuvOVfkDERt0/9zuzOCkKfa3+5My1SMv8krCrcpxcqLBcGUKhqWCpcEwKQr7pgE 95jUYzUbQk3ZmQr5PxInH1ebkz6yAcPiAAKlqh8YLYylGwjtAtDnVgUNjRpwQkp9fgj/DYf+BGK 1ZWY+//RucxKde7DOB9vFdf8VOJLlsdTkkI0= X-Received: by 2002:a05:622a:38f:b0:517:87bc:9b47 with SMTP id d75a77b69052e-52dd5e04d71mr123094481cf.39.1787238577641; Thu, 20 Aug 2026 08:09:37 -0700 (PDT) X-Received: by 2002:a05:622a:38f:b0:517:87bc:9b47 with SMTP id d75a77b69052e-52dd5e04d71mr123093701cf.39.1787238577229; Thu, 20 Aug 2026 08:09:37 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c5edb5196sm40682116d6.8.2026.08.20.08.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 08:09:36 -0700 (PDT) Date: Thu, 20 Aug 2026 11:09:34 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Nuno =?iso-8859-1?Q?S=E1?= , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , Andy Shevchenko , Stephen Boyd , Brian Masney , Jerome Brunet , linux@analog.com, linux-iio@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: frequency: adf4377: Fully initialize clk_init_data and clk_parent_data Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) On Thu, Aug 20, 2026 at 11:19:52AM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > adf4377_clk_register() fills in init.parent_data, and assumes that > init.parent_names is NULL. However, the latter is uninitialized, and > thus may cause a crash. > > Similarly, adf4377_clk_register() fills in only parent_data.fw_name, > leaving other members of the clk_parent_data structure uninitialized. > > Make sure all members are fully initialized, to fix such bugs, and to > avoid future breakage when converting drivers to a different method for > specifying the parents. > > Fixes: 60e5448ddbec2dc2 ("iio: frequency: adf4377: add clk provider support") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Brian Masney