From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D8FD3876A1 for ; Thu, 20 Aug 2026 18:53:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787252029; cv=none; b=jjbcKfRttWcTuHA9CFNTO5gxJOQAbPt+SNdxLhU3uKVngzyDXDnQcr6I9Ie6VpIc0hy2Epjq1V9Fvt/pakksizhK+ZFjgmofH4V2QzLDIpAZwI/NNABSkCMre3ebzg1nX1eIwDmH6lFcSPhqAd8yNX1b0HhOMxwxVJauPqOSau0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787252029; c=relaxed/simple; bh=PiO6Ndure9FSudGc7kYMDD5AO97U2Kyb1pxQ/fIJoCQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LZ0lkU5Dd1jNzYKzJqLoyZXLb/SNePrN+X15/3W8BAsEpGtie/rPzGuvHiwysF++tQAoyrcMcssmnctUydGcc64vsj3M7aPnd9X5gEvai+Y2h9buV87MKkAp1BTxbMcqzEowRCEtyaIcbUUGvG9t4MYVIgmQge4Edvb1AUPHHzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nwuWPvI3; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nwuWPvI3" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4954dff6536so1674185e9.0 for ; Thu, 20 Aug 2026 11:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787252026; x=1787856826; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kyz2mBOTfqVwcT7DmvS07wdJb/XPjEVP7kC6KnwLamI=; b=nwuWPvI33W/DLvi351EY0+Sp4bOkgZUAVjRzxCLLxyKiiA5QztzgjSBaZdQagXjQwp SPpWZqP2yHseRPTnwaKDtY3+4fqQbiB2aPbF/4FzbPo5R+EgwrzwKcEJ2KH2o4IZP05U Divxm39G4Ivd6RTGg3I2nHoce7dthPgSO9x6Ksk8y1jwz9ApIjY7jikqYMJrHnTwFVWB qYhXaq4vTYVEQzHuanbdthRMWNZTTP3YES/vBFLL11rUO9DCMkdhBfQbdiYyhI/sZEo9 FauiB0nwF4NfKf4vmEIv4eTUn/S+hrMWzDquP3Cp86qE1URFGhsHVuHpoJ+YZDNkFXfN 1fxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787252026; x=1787856826; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kyz2mBOTfqVwcT7DmvS07wdJb/XPjEVP7kC6KnwLamI=; b=Kt5qcXExOjTO3cQJxtH/PzN3B0z9qZVUJtnmez+NlZ3uRfLBRqcJqaHdkYm0cb00ap cAL/VmxlhSEF0aYjDgBN4J71quWPn0UJU7pOzmCTwEZaX4hlhMnovLk6NbPQt5K/2h91 vS6XtE/zeCSmZqaqCyuMl75RPhy03DVx9ZM9q3HAqY4oFMZCRpeZUwK1i1vjsa9lXOp3 /cuqST6Cyk3s1YfXDfrt1uCWHmUagmaKk08OOuDgXsfsDEIa3Td6i5nsVjrpJ2uyf55H CLMMJi4ZkrOg4p0GMBRqZpT571bXl8UOCJV7VyMXG9qVKx2OVCWR8YD+9N1Z35TdcJ2N akzw== X-Forwarded-Encrypted: i=1; AHgh+Row+PvM5EcGfdohNJdzdk9FT3ccGodSXbDwWvueEm4GZS391kTAMVzE7FzVA9L05zfKp7UjH5RrKGXjw88=@vger.kernel.org X-Gm-Message-State: AOJu0YzY2yUIIT57q1NEem25xt10zocPEL+8ejHsDTY/81DpHifaYSDb AnSXG5UwGJG+7XJ1aq23WhORlcZNZ/xWSlUVizj/iZI2R47BPR2xfmBm X-Gm-Gg: AR+sD12XUpriNRlOhZ03rNHQY0KQq6whKjCKUbePymh9OR537KkHcanUCUv8jOlCGuM 79wkHWTBl4II7ekT3LonDnXHvt3MLXwmkJxy9r65reFgVykP7XYu1vx8QOkSQumN8/d7rQ5IJDf 0Ph9I+80SxhNeDDL7STRXPgaEs9CkXiYTtu2pXMugQ4znwtY6E8HKU3eV9o2SpYl5mZc+lgbMvV t+ZIuqNcB4BJ6j2gesh4aEHSpo8JBf7gOw/ii7paTuMshbAX4Hk5MpGs62RDxV7YTEfArqpV/nE YhEHKXWMf3DI3JhGCTd7iLX66vEhuH9XJXp91XV1LDh//mFFws8IbINM60VC8Nd2vrdrkLOuKY0 o0nawVgMd+kQd5nzl46MqWkgoUrHhVWN2cI3VZEENtEhHwPS//w3T63SFt5ZmD3coOcP/SwjSZJ odvvG9bZsDlSnYZCnBiWh+4l62Ma+CBAJJ0fL8SOIu0uIKW4kd85vWSFU6 X-Received: by 2002:a05:600c:6217:b0:499:8ae1:b900 with SMTP id 5b1f17b1804b1-499b8460e7fmr20628525e9.12.1787252026358; Thu, 20 Aug 2026 11:53:46 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b8f750a5sm2505875e9.1.2026.08.20.11.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 11:53:45 -0700 (PDT) Date: Thu, 20 Aug 2026 21:53:42 +0300 From: Dan Carpenter To: "myeonghyeon.park" Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: reorder conditions to avoid else branch Message-ID: References: <20260820162601.74952-1-myeonghyeon.park@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260820162601.74952-1-myeonghyeon.park@gmail.com> On Fri, Aug 21, 2026 at 01:26:01AM +0900, myeonghyeon.park wrote: > Fix the checkpatch.pl warning: > > "WARNING: else is not generally useful after a break or return" > > in core/rtw_recv.c. > > Return early when the SN_EQUAL() condition is met and break when > SN_LESS() condition is false to eliminate the unnecessary else branch. > Just ignore checkpatch when it is wrong. regards, dan carpenter