From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FFF63624CF for ; Fri, 21 Aug 2026 03:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787283697; cv=none; b=pvy2/5dSZ9KzzBZpjpLtzEor7oElpEKvobADxYmlFvgeYKSC+582v3JHZVdQffU5HU5KOxFqrYtKxeG80mMqQE//ga7gqbOkcKoKj04QZaqkYyoRUOhXAat0sb9IXgs0QhLlNbePD1uE1BncCBbsTAFjBovqOfdXnYQrzWAIZG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787283697; c=relaxed/simple; bh=KwtQAPlDRLz+zysLOqyYJDG5rPaZZS9IWD4fOl0f34k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I5LBbseG+k9nQSxlDe19qQSug14hMy1aK5Yhq/VRTyPqumC6AzYNsR23BoSePLxJuIGZYKKOcj3drHQz44YDt0GrcZmWMfqB6lskiNkUZTqfNqtgcbZcT4mRV+tZhum78rECceC3WGT50OfkJui8N6AU36NdJhZOCJ82Xm9TMlU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=XbrcYDBM; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="XbrcYDBM" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-934944f2d22so35064685a.0 for ; Thu, 20 Aug 2026 20:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1787283693; x=1787888493; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=EL37QOqkfz4M1rcSjU6ngbT0t5Oo/IwMsygbaYu8nYw=; b=XbrcYDBMl/4xQ+GSqAagHhkdPQlG4rbdSsrD4svUAXcDYPTl6sUTmvupohUayc8HCH UEy6AF1BPVslIwVEVXVKxGKaVeEQUwNJOr6TiEvaNDg7ubdjBuO8ssghYURXkU7LpRXd WVeAzjYEvBvPW11Ke7vuHyAo7o9P9tQFdFtxs7e+hK6dI10X2Bwk/7fA2Vp7xQyhWFTj Gj+dhREwXOhRFZ/tXZmsy7tVtJidtq2jiT92/SOqLB8jlhPsGGS7IjPYfMCc34iXPw+w SCCvgqqoftVslxp2/N/qT1giFaDYUle5Wmcb8o3M2uDGQ7AqZavtyJcag1D72U9saITW EktA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787283693; x=1787888493; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EL37QOqkfz4M1rcSjU6ngbT0t5Oo/IwMsygbaYu8nYw=; b=fK2/CBYn0J0fN9LN1mF6mo+Ra4pWsYjpqMFB6XE/uWra9S0c+qUq68sYJ2az97YSwS 3PQiYy5AUF6ZF2Gh4gK+e3oGxRKjTC06MBL0f9Bge8KJ4QYzFma5x1ghkRcAVdckTKd5 vkhuGPVreyxv8Y9nl7VQja4Zlu/cuMvh+S4CabzM90BsovRAGdWs4OUOZLhg8kRGEcHo FAuKEk5gzisswxWCatssqzP7YX1P877w/1bPeeEPCcfca8tU+HcKiwwHWoQwVuza4Dde i1pgGR/3ovNYgf7u8BGFECLslH1AxNeWpdw7t513nxILT41IR8Bd5nIztBk4XPtS1FbP W7wA== X-Forwarded-Encrypted: i=1; AHgh+RotPZkxBy+KyEbqpknJ/5NFHbk+wEj7ieRc9ChLU5UbuxyOTyDoRH0WwTHA5iX/wTZXT66QkPgbw+dqjJM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2d9Rn6uq/F4kvvwLmh4mXckydKqJ4QHFO+gIEh6Y71G0xWJEF 7dvYGqwtQmpX4lwwD/ooEFN+Ju9z9bY/O+AKDupD6WkasgCagCklxU2J9bKirdz2KDE= X-Gm-Gg: AR+sD11D6I//iqtcejWuSJN+Y6BS12E2Rar67kMkymyB1rvB1v64ZnXaS6w1n6yCHPq J3TRfsUyT0isqdA6GMaoXeLSNucbyQr5Bw5fcTv80aJoVdM7QEFehO8BbAu9lV3wgFbQwzEHaLX yXtHtE94B8nzIb3ijSlk8zmZf3N9V2220e2DMus4Xp7vRwxa7H3ankKpjEtRwVic7PZbkCgScah c+Wp8l4mmoXAMxTwFvh2ULM8h6e7Dj7bTjS6Vzy2rwRSHk+ZWqiiy5SyigE6sdT51h+YZdIU0QA h9VLHsjxvKikOp+jGJscNkx+iZzCUa3MPrhn/BSyYBET4Ir1SMuYNaXCLVQPJFgIuB1mS5kDhB5 vgt9Uqm4QNFOcmbBqTbGkjyAMxvE46bPk7txRBToI8ZN+CY3NdlKHI8Ll4rYGlfoiezX/MKtBwx nsfCdSdJ97r8cffB9+NbEZif2bsqY4j+72KKZGL5EPucGYc76LUC9W8F/egCU= X-Received: by 2002:a05:620a:6f02:b0:931:4b6:a9e6 with SMTP id af79cd13be357-937396f3282mr286246585a.47.1787283692603; Thu, 20 Aug 2026 20:41:32 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9372fdf59f3sm234049085a.10.2026.08.20.20.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 20:41:31 -0700 (PDT) Date: Thu, 20 Aug 2026 23:41:30 -0400 From: Johannes Weiner To: Enlin Mu Cc: akpm@linux-foundation.org, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, david@kernel.org, mhocko@kernel.org, ljs@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, enlin.mu@unisoc.com Subject: Re: [PATCH] mm/vmscan: fix comment logic in balance_pgdat Message-ID: References: <20260821005107.3416-1-enlin.mu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260821005107.3416-1-enlin.mu@linux.dev> On Fri, Aug 21, 2026 at 08:51:07AM +0800, Enlin Mu wrote: > In balance_pgdat(), when the low watermark is met, processes sleeping on > pfmemalloc_wait are woken up because they are able to safely make forward > progress. > > However, the comment incorrectly states "they should not be able", > which contradicts the actual code behavior. Fix this typo to accurately > reflect the logic. > > No functional changes are introduced. > > Signed-off-by: Enlin Mu > Signed-off-by: Enlin Mu > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 35c3bb15ae96..822f73758c42 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -7188,7 +7188,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx) > > /* > * If the low watermark is met there is no need for processes > - * to be throttled on pfmemalloc_wait as they should not be > + * to be throttled on pfmemalloc_wait as they should be Pretty sure this was supposed to be "now" instead of "not". That would make more sense than removing it, since this is about the watermark check after kswapd has performed reclaim. > * able to safely make forward progress. Wake them > */ > if (waitqueue_active(&pgdat->pfmemalloc_wait) &&