From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AF2C3D810C for ; Fri, 21 Aug 2026 09:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787303869; cv=none; b=nU/vtk27UGy1s+bG2sOgEMDNY15VZrRfvWDSscWKtZ2IUgJzSf0MIwxDx4YARdlYC9hEkvspQYssYST89Z4HQPOvZZx05XNuBDT/H6ghj3n++D5Eb98EhQWgE3thsfLUnot+B5j1kMDw72TsHdY1GHhwtPBFkdom5qkN5Fk4ngE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787303869; c=relaxed/simple; bh=lqoewANP0y1ZMpKVzWBagrpPMa9HSOu0fSxbIuWGR6Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dyXnXIiOzlERY9ejpPhrQ6Ium3XANO68kmEvxZMARWRap0xyJKBl/kXzxI6Qu9dZ1kIlgA0EUjhxvJSFvSpvIb9ZoO/oqYMkvf74syX3NTQBbf/hFyGXmS8WeyyDO5J9KH0w+5JCphNXGtKCwJjcFs6phCSKiwE9dxwP0tXzE+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=km20neO9; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="km20neO9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787303863; x=1818839863; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lqoewANP0y1ZMpKVzWBagrpPMa9HSOu0fSxbIuWGR6Y=; b=km20neO90L/bjop62SUKMVPS8dOo1Rz8t9OsMvTOgivxnbqLGx79Lb6X dGNp/0HlheGCYV2F2f9uQnlf7owV/zSIBjpqtSCRcEKRoe8Hk6Fgy6Qen AtLLXXl2UJTs7UTcwpjvng8g4pBmchHApCdmBs34GMxJu5ez+QfeSF7mb ZA7mS36pAXR0j0ZUkaNCFYnKVLf43DfO+Mlo4teg+zvRkhKYiTcYNue9V 8jb/fixHUFgJXVxtIf/VPmJ9b7qo1liw3GkAw+D0/5gvRKmw/hhNqfOqa Gcyl/wPU7IX3OfHE572DKxKaDbVNOK1OGe8McX6AEL8t6rUrADDP/KwHf Q==; X-CSE-ConnectionGUID: nLmAeQBUTuWTTd4yiesQhg== X-CSE-MsgGUID: whzZuDbWRMePKZA5Z0Jp8A== X-IronPort-AV: E=McAfee;i="6800,10657,11881"; a="87979319" X-IronPort-AV: E=Sophos;i="6.25,234,1779174000"; d="scan'208";a="87979319" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2026 02:17:39 -0700 X-CSE-ConnectionGUID: EcbkpcdrSiOeltuqLPoykg== X-CSE-MsgGUID: bB1pdnzuQJST1NOaGGUVTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,234,1779174000"; d="scan'208";a="269764692" Received: from abityuts-desk1.ger.corp.intel.com (HELO localhost) ([10.245.245.241]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2026 02:17:37 -0700 Date: Fri, 21 Aug 2026 12:17:34 +0300 From: Andy Shevchenko To: Li Jun Cc: andy@kernel.org, geert@linux-m68k.org, fourier.thomas@gmail.com, bhelgaas@google.com, u.kleine-koenig@baylibre.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management Message-ID: References: <20260820023212.2655006-1-lijun01@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260820023212.2655006-1-lijun01@kylinos.cn> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Aug 20, 2026 at 10:32:12AM +0800, Li Jun wrote: > Replace the manually defined dev_pm_ops structure with the > DEFINE_SIMPLE_DEV_PM_OPS macro to simplify the power management code. > This macro automatically handles CONFIG_PM_SLEEP configuration > and generates freeze/thaw/poweroff/restore callbacks, reducing > boilerplate code. > Changes: > -Replace SIMPLE_DEV_PM_OPS() in v1 v2 with DEFINE_SIMPLE_DEV_PM_OPS() for pm. > -Corrected grammar errors in v1 comment. As Dan (IIRC) said, please move changelog to the below '---' cutter line and address all my comments. -- With Best Regards, Andy Shevchenko