From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB6D43AC0DC for ; Fri, 21 Aug 2026 13:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787318118; cv=none; b=qldXkB6eua0oJVQRazev5E3nafq5HZF+JFpr1pn3HKebLm/HXkIMfQkYwTJ7DcN73SSIJDfuVO4H3CZZwJp5ZHQPadSSGZ/WEsGtOKPkfc/d8ekXzR8zUEa0mn1T+de/evH5xlB31jSmh747xu9BfG8xDLD8vDE25t9j4BccSJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787318118; c=relaxed/simple; bh=ZgEtJfYhvEx3RUMYzu/QeOmFo1mnqj6uqfkRQxaKdyw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Z7ukFOqxNrhQonSnPdmMRX7rmPcYisScV6v3qXLnyPeZrIoHdJoRJjMh62TyOL/PPnAKgHznSggfhCo8VqoGes66dWi3bHU3kXPWMwlUs8IcYvU0jSPDHqeFGnCwf2USLVH5gSX0qkEopbAUSDHDcjJ9eXX9h8ew/miCAa6XZ+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=c6dvQg6l; arc=none smtp.client-ip=209.85.214.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="c6dvQg6l" Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cacf17c7e0so16936715ad.0 for ; Fri, 21 Aug 2026 06:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787318092; x=1787922892; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=xbkxU3KDRFhwwjU3XLpDILLbXwo99XWxcTGCF4UGzgI=; b=c6dvQg6lTgr8WfLyCyDDpuDZqgAEBAZWBpp7fCIezykosTX8xFGBy2loYtaNYVMO2N afquEy5AbPQBlEDIibICb1Ey/1PMtRvea5T8kUdNfB9foRDFJPln+AFYfRazXR2V9o1Y 4VIGgVLrfUF2SxWfciCdNr0NRy37DtLHlOJQZhnlC2s0k2k+FZH93vLWnN/Ps4ZtOa3Y VvvuMyjYw4I2qY9VE6DHyii96mwk4wVozgJ7sHZ7X+S7xJHqjm3nE1rTLMDE6kITf3K8 GoUHQfbqES90zkGO1AoCnk65OKx4Bb560zghBv7V/utYLU+uCta1aTJk9aVlk6AELbe4 cewg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787318092; x=1787922892; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xbkxU3KDRFhwwjU3XLpDILLbXwo99XWxcTGCF4UGzgI=; b=tApLVR/11Kg/D1clwG33bAebCTSomsVCINuDK/6kgs+VBWMFUmbG9RAs5xI3cZtnYy 074DA31pP89I4pY0LlmUfcq4fFsn33DALWPV3zz2kINocF7PYzGJXCP2aA8I/qR61e64 OdTE4fLjcyMWNYXQqipVeA23qoZ7DaTq/gCBhUuHEV8TYMtSLD0tZkCJv0HpeE6m7tSH NLEQ7xFnPYYiGmii0WIY8Cylgo3VXHqzv6VxSdRYdF9gdr5BcFIZfrpaYeDMz+ETBCCU ObDWGMkj1HrUaJ/+AU/OlwGLgCKL4yktXUN0yO/sVomPtWQHck/YTK6yFfyflRHFQT3u Mkqg== X-Forwarded-Encrypted: i=1; AHgh+RrM3d7EL0IAenZzhl1fLlgbBIcCbvortz1X+Ts56MgoOtK6pXMWPOB73RhIbs6FdpLJaYlOi1CW7XnkDFw=@vger.kernel.org X-Gm-Message-State: AFuF++m/8IJzzF8DXPPewqOSe1yX09IjiB4vFT4oCT3HVnvun01wpLxt ikB6kQxo6FjVBR4YMMPypaQ6KIPgEifShWSFsZR0FXqp67P3pzW1cX5AJFOU+n1MbgacEFsmW6d RkAjoQQ== X-Received: from plrf23.prod.google.com ([2002:a17:902:ab97:b0:2ca:b907:d842]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:2c0c:b0:2d3:78c2:1f19 with SMTP id d9443c01a7336-2d64b0270b8mr122535495ad.9.1787318092128; Fri, 21 Aug 2026 06:14:52 -0700 (PDT) Date: Fri, 21 Aug 2026 06:14:51 -0700 In-Reply-To: <8f715ebf5cb0ef70803ca8c6ad462d9de7dfa8be.camel@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260819094903.3060020-1-xiaoyao.li@intel.com> <5799b5d637f6b540c45874120aa37749a7dfb955.camel@intel.com> <8f715ebf5cb0ef70803ca8c6ad462d9de7dfa8be.camel@intel.com> Message-ID: Subject: Re: [PATCH v4 0/9] KVM: TDX: Enable VM-DoS Prevention Features for TDX From: Sean Christopherson To: Rick P Edgecombe Cc: Xiaoyao Li , "kvm@vger.kernel.org" , "pbonzini@redhat.com" , "linux-coco@lists.linux.dev" , "kas@kernel.org" , "linux-kernel@vger.kernel.org" , "nik.borisov@suse.com" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 19, 2026, Rick P Edgecombe wrote: > On Wed, 2026-08-19 at 16:03 -0700, Sean Christopherson wrote: > > > To me this is not a valid reason. Sashiko is great, but we can't let = false > > > positives drive the patches. Given that the series is so big now, I'd= think > > > it would be better to leave 6 and 9 for follow up, so we can focus on= the > > > core thing. > >=20 > > Hmm, I disagree.=C2=A0 If the consolidation weren't here, I'd absolutel= y ask for > > it. This is new feature enabling.=C2=A0 Yeah, it happens to be tagged f= or stable, > > but at the end of the day, it's new feature enabling.=C2=A0 And it's st= andard > > operation procedure to do cleanups and dedup code as part of new featur= e > > enabling. > >=20 > > If anything patch 6 should be patch 1, but that's a minor detail I can = sort > > out when applying (assuming another version isn't required). >=20 > Ok. But you disagree with dropping the patch? Dropping the patch. > Or that avoiding sashiko reports of existing issues is an invalid reason = to > change the series? >=20 > I think it's good to discuss a bit how to handle sashiko scenarios. Like we do any other code review: use common sense and follow established b= est practices. If a human reviewer pointed out an existing bug, we would analy= ze the situation and make a judgment call as to whether it's better to send a standalone fix or roll a fix into a new version of the series. If we decid= ed to fix the issue separately, and then a human brought up the same pre-existing= issue in a future revision, we would point them at the fix or the previous discus= sion (or if it was the same human, (politely?) tell them to go away). The only differences is that Sashiko is noisier because is doesn't (yet?) r= emember what feedback it gave in the past, often doesn't look at the patches later = in the series, and doesn't (yet?) respond to emails so telling Sashiko to shut up = about a particular pre-existing issue isn't effective. But to be very explicit: don't include a patch *purely* to suppress Sashiko= 's rediscovery of existing issues.