From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCAF13988F8 for ; Fri, 21 Aug 2026 20:53:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787345642; cv=none; b=d5yumha+NucgHHkA4UoyrAGZklDJElYE9mKyOnZg4KMgXlDXK1e97nDSddjP+DLYtZ6UErvWek12yqe2c+WKiAbiG38hoiLWFv9srVl6f08rU+Sfr8JzGuezFt/27FMpCYAeAIA69Flt5nVshLHzIisJIcTp1jVeN94vh0RIOSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787345642; c=relaxed/simple; bh=gwGR5P/wPJadpoIZc/58/Hx7++PsDwXoa5PnmMzpgAg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NE6pBrZsQfSbTTqYfvYHzvO83spj8Kf8MQjw8+E5yU505XJh06OyGaEDeE7d6Bhw0gm7048+Lt8q3Z4vJTgG9qX4N51rh+t8XqCPhaDGHFF0Mulaek/DLcZCoJ82lB0310y2lbuXOYJyc/C4J5TnJeiQz5x99v4agjck/bE7ank= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S7uSL4yx; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S7uSL4yx" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so13153155e9.1 for ; Fri, 21 Aug 2026 13:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787345636; x=1787950436; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AHy6QNmeSnh9146Xv0VjFDiALvnInlM5eLCi0r12Lnc=; b=S7uSL4yxFBjcKHTg7KFGVoPrQJHq2+bB4BZEqqKgduruIMDu+lDR6fh501snAHkXgZ f95ea4fAkbIgyQhsymSQEh94qVJUJMRkHOcuScq27J9Bh1HrEM/lMcfq/ojiBUb7nX0i pmp5pMdT+xRw7Ka18hXh1ife//zwro1XWPTk1WBo50m3UJT3ahkGwTEISuYUNf7V8IQf +z3n9IaU739eQtaVrR53b4pMk5j9coBAO6UJhzzEP4dsdbLrSEr0e3f2eXPeRBfDOMQC WRxUw0Tip6pxhrGiKv9Z9xsMVKEofaQeMC5xofSb9yq2973ymfcGgGa7ZLPstDgaYyGu 6CyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787345636; x=1787950436; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AHy6QNmeSnh9146Xv0VjFDiALvnInlM5eLCi0r12Lnc=; b=TqWukEDGvajQ+0gkGbrayKnmHMX0xG4eUeucTiNDKKNNmLTVpHNaD9R+TUE2Ue21ZK FcB/bvlGvrL61r+efR2zOkj/IQaeZDhZtXKf9IDPAwsn5cgYiCPP8kjUlpHrDBOGUGen QCQczswMh7bIU9Db4iBFl0shm5GmJ9zAaG0BLG5KIanih+YPy5Y4laKeHSJ82it+eAd2 138AuIicQdkIzciEHnmW0nSN+iBTiFgCBfuDrCUX8Les0b2OzAQQLMSRf4rFHaEJut14 pZGmudSyBpLiH1KemUDdsM0bKGKtVXNUYQTlnSx7hdGdH4Ib1qN8tC1DDlKHBDE6wYNB /YgA== X-Forwarded-Encrypted: i=1; AHgh+Rrwu4LaAROcrcPbU4o7752WcY9fPK9+NJHiAg7UP1n0ELc3Z31bcqjTdlf0rkdC97NXwLfoPO+eVPddoas=@vger.kernel.org X-Gm-Message-State: AFuF++m3hBvRA+Oq5qJgX0jdbTOo9THAzDXZLNdrbZ1rnqlFMbtl1PYQ afBk9hJuc7EipM2b2mfDzbxpEzanChbB4H/N8iwrj6zjf9tBIvY0txQPOV9G4r3BkJyXlTrV X-Gm-Gg: AR+sD105KqObGgXMQ0nwGyDQcUypWT5CF+573iwcJOwZ1XnawT7m09gkTvsj5/fii+g lq3Lq8Kq24SkD8mFNzGQoLinI6VOfB+kCgqwnaXvFhpRec/XM/1YwM8ZupNOtNjbf8sBKoND087 lyZ4Eo9+0tZifmkesulbPxvxUkT1a+REh420zXGESU28v0L+fiv4yr/o26ciIm1E0qa5xqHJznW 7B/84TDC3zKSJRaM1Q04yk7qLp+NfM+sJ1cPXzkPEyPsC0N5DxArmxPqyVXAhbu9dLc1Nef2FUq Efyu6tMdVDydQiYsnMq91N6CgX9fq14mgGPHl6scBXtVSkNcWgaMRRYTimthkmuaBbQz9HG3zUD G5m0V2QkblcRyYIjph64j3jgF2gbgWUQcChYez4oZgkle8stV/EQui5XrqZZmzahAGcSxn/AFpa CTTOQfSGiInwXO1GquTXAiKHRIqHAukssq5YNszYFQrqPj/NPqjthh/THB X-Received: by 2002:a05:600c:a01:b0:499:795a:c5fc with SMTP id 5b1f17b1804b1-499c19bd3d7mr11744495e9.7.1787345636011; Fri, 21 Aug 2026 13:53:56 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499ba31efadsm36328525e9.3.2026.08.21.13.53.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 13:53:54 -0700 (PDT) Date: Fri, 21 Aug 2026 23:53:50 +0300 From: Dan Carpenter To: Omer El Idrissi Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: modify misleading comment Message-ID: References: <20260821195823.87471-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260821195823.87471-1-omer.e.idrissi@gmail.com> On Fri, Aug 21, 2026 at 09:58:23PM +0200, Omer El Idrissi wrote: > The comment suggests that rtw_unregister_cmd_alive is called > by the ISR, while it's called by function rtw_cmd_thread which runs in > the kernel thread context. > > Signed-off-by: Omer El Idrissi > --- > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > index b9f8cf1014ed..a4831dc145eb 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > @@ -891,7 +891,7 @@ void rtw_unregister_tx_alive(struct adapter *padapter) > } > > /* > - * Caller: ISR > + * Caller: not ISR The original comment is obviously wrong, and that's bad. But is "not ISR" useful? Probably we might as well just delete the comment. It's not like people don't have ctags. regards, dan carpenter