From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28CF9392819 for ; Fri, 21 Aug 2026 19:09:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787339378; cv=none; b=D7NVHh9HUc99GAaeTtJkTTN73ig4lxZr+74X1+SfCz463TMdBmIqkdl//GqmgjsM6UCKfZ6QpwVPx1SdDypy8I6m7nx5RixS0N6770GTKjTciG6YpURny1zgX6jLzvE/+nIk+fOA3ASHzKFye4kLRQ0fq4hjV+JEEPgph4Y1PNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787339378; c=relaxed/simple; bh=m4AbHNYOybKycCffk+1NRelRi+xxrvqfKKYJ+6qV4UY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e9T8ydLmxuNqNy/lcArbzGty3foRvKhgDqviSzQP50QAWJUJiPXLVbmXIn5QA17NVFky/4Fs/OeL1saCiBEKHTByx1JLSOhJSbFobcDHdqiWjvkBIHxJJ+EOMGHtTVKMpnDD8AowHbEKhgvHWROiuHsPD2m6+dziI28Ss/6x0Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BJ6Z36jb; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BJ6Z36jb" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-c2022323c37so223384966b.0 for ; Fri, 21 Aug 2026 12:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787339375; x=1787944175; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=m4AbHNYOybKycCffk+1NRelRi+xxrvqfKKYJ+6qV4UY=; b=BJ6Z36jbhziPKplfMzcvHV7AU56iF45AqbBsSpea8A7keRYxV5No/hpR9MIhModTvl czh0CB0pHUnn/hITfDLi0hpREthtEr+rd7joZnZbMvcvf5B+bS6OJPq1JJlyY4L6jXCY ifKWAtTcCeUlfKQHf6Q28G77DHY4x6uiAFzeF1sQM2c+m0bNlvyXYAOyK8Ycu7zHb7nz rsW76UkZFj1QSXCzHm6Dmvx4Pqq1yJ78eVeRuGtSrXv3u33eLMqCfrme+UDXkwngXcYc TmXoJAr5355T+vs+rspd/oDdWMcMAxsZQkeK+xGQCM+XOwzKyrhYg3WhEl75rJ8EesKN 6KTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787339375; x=1787944175; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=m4AbHNYOybKycCffk+1NRelRi+xxrvqfKKYJ+6qV4UY=; b=hsbtOxNuFcs2GdDEF8ucVuPMAntE54xMrEUVOZwwoiY/PBs9P4fKXWtR5IrswwPUUd lpCCBw1Y44z7rRfF5Ern00E68Pq+6tDDVPEjvdjBFWajVRA1YG7Kq7SL4P7z2OeDdAQC zmooAfVyswZJkH7A/ISHHADtqZLCXKb1D24SyG7DNZ3s5v7IWrIXaAiPkosM+vYAyzwT qYZBtSgZUoEA9rR2AaiLqGPPr/FPjNKr77bPNPtqhtUUSMGjH6PP/eVWAomNpGRSzWwM VdBBhDzmpZavhk2mtYzFQKqo9JGZOr1LGYWEhvPXF23SVRs3HqKo6up2v0xsW49Y37St NryA== X-Forwarded-Encrypted: i=1; AHgh+RoSoXuWctdiRnvL/s3Y1SqEBE/UT0ono7je7MnRiVU0wZfNz/bY4ohozyuC2mn6FvvHT9IqeD61kiTB5OU=@vger.kernel.org X-Gm-Message-State: AFuF++kdc+xCvX7e4Spm+0pqjY7eGjEQVuGtjgzwuXClgsT5EeYHV1rB s+6O3/HGAZqyKKa/2gx5ZiYOr0S1AlmqxbNcuFwQdOjoTt/NtDn+ER+s X-Gm-Gg: AR+sD11JgCsGCElLA/hD9PXiY9uRR7kDdX/LEDsf7+0DiiEe4R2DChAIkGfxWpxKjVm 1B4wo7s9yM+ztHDJvsZaa1ofiWW5/TLD4szZf6QMySJv2DhIZvGyOJBtsYIUtCjzjTFKi+76ylS BlFu78rXeWU41PeUB4s37njwxUqJimI3z018ICIrMeImQNhSbu8iDLZ9BlpXQVG6Ichbm/zKCEu wP5inxp7vPb+5arZwkmawBgdCRNEOm1w6tCcN4sB/IGyp3lxRtHsh4UX8F7f5rkokhTRteoaNfg Xs1LfrgcJ5aLhRSkKnUiurKtq0MOzu0WmcFhKCPkaEb/z1tOBCrojcTjlTA3D1nt4G+QgoSvMUo 6zPuAuVb0hNw2/Z0KSSQAhIQnZQ0HIKqsqJACWP/AH/B2PD2cVRu6svxrJIdS3oirr764Q0Q0dy Y8ag7neP8ni6Bp4E33Fz4ViW69GNgsLNNo+XUddWO5Gtl4idbklmBDQT7+WdjNkIfqN4mHws5zq hZwctJ+3Kv485rb5uXC8XlKEAUb38Yz6H0JsZ9VWrrmxHjESr0pymUtRNaBGux+UZAvqMUV2lDh meRqQ5aSskUnH8w2CFHv6M3QN6lau6StAr/IeF8+IO6cP8jtwxKfC3Bg+qq2UDnfpZFU3HW6e6Z HgA== X-Received: by 2002:a17:907:97d5:b0:c20:21be:ea75 with SMTP id a640c23a62f3a-c246a33ea8bmr796814866b.8.1787339375197; Fri, 21 Aug 2026 12:09:35 -0700 (PDT) Received: from MBP-von-Karl.localdomain (dynamic-2a02-3100-a103-bf01-4ca5-89c5-9aa3-9754.310.pool.telefonica.de. [2a02:3100:a103:bf01:4ca5:89c5:9aa3:9754]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24589e2ab2sm584196866b.7.2026.08.21.12.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 12:09:34 -0700 (PDT) Date: Fri, 21 Aug 2026 21:09:32 +0200 From: Karl Mehltretter To: Marc Zyngier Cc: Oliver Upton , kvmarm@lists.linux.dev, Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Paolo Bonzini , Shuah Khan , Eric Auger , Christoffer Dall , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 3/5] KVM: arm64: vgic-v3: Unregister redistributors before freeing regions Message-ID: References: <20260819224229.82948-1-kmehltretter@gmail.com> <20260819224229.82948-4-kmehltretter@gmail.com> <874igpp3qm.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <874igpp3qm.wl-maz@kernel.org> On Thu, Aug 20, 2026 at 09:58:57AM +0100, Marc Zyngier wrote: > The other bit of interest is in __kvm_vgic_vcpu_destroy(), and its > conditional removal of the RD iodevs. Can't we just get rid of this > whole block altogether now that we have a saner failing path? I tested removing that block. It reintroduces the use-after-free fixed by ae8f8b376102 (“KVM: arm64: Unregister redistributor for failed vCPU creation”). Karl