From: Inochi Amaoto <inochiama@gmail.com>
To: Chen-Yu Yeh <chenyou910331@gmail.com>,
chen.wang@linux.dev, inochiama@gmail.com
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Longbin Li <looong.bin@gmail.com>,
"Anton D. Stavinskii" <stavinsky@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:RISC-V ARCHITECTURE"
<linux-riscv@lists.infradead.org>,
"open list:SOPHGO DEVICETREES and DRIVERS"
<sophgo@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] riscv: dts: sophgo: cv180x: Fix internal ephy node name
Date: Sat, 22 Aug 2026 10:15:12 +0800 [thread overview]
Message-ID: <aokF9v3orE3nBz4D@inochi.infowork> (raw)
In-Reply-To: <20260803163427.74445-1-chenyou910331@gmail.com>
On Tue, Aug 04, 2026 at 12:34:24AM +0800, Chen-Yu Yeh wrote:
> The internal EPHY node is named "phy@0" while its reg property is <1>.
> The unit-address should match the first entry of the reg property, but
> this is not checked by dtc for MDIO buses. The kernel confirms the PHY
> is indeed at address 1:
>
> eth0: PHY [mdio_mux-0.0:01] driver [Generic PHY]
>
> Rename the node to ethernet-phy@1, which also follows the common naming
> convention for ethernet PHY nodes.
>
> Fixes: ba1abacc57cb ("riscv: dts: sophgo: Add mdio multiplexer device for cv18xx")
>
> Signed-off-by: Chen-Yu Yeh <chenyou910331@gmail.com>
> ---
> arch/riscv/boot/dts/sophgo/cv180x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv180x.dtsi b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> index ec3bf305274a..cf672cc6b935 100644
> --- a/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> @@ -71,7 +71,7 @@ internal_mdio: mdio@0 {
> #size-cells = <0>;
> reg = <0>;
>
> - internal_ephy: phy@0 {
> + internal_ephy: phy@1 {
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <1>;
> };
> --
> 2.43.0
>
Please send this with the same thread of PATCH 1. Otherwise, LGTM
Reviewed-by: Inochi Amaoto <inochiama@gmail.com>
Regards,
Inochi
next prev parent reply other threads:[~2026-08-22 2:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 16:34 Chen-Yu Yeh
2026-08-22 2:15 ` Inochi Amaoto [this message]
2026-08-28 13:30 ` 葉宸佑
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aokF9v3orE3nBz4D@inochi.infowork \
--to=inochiama@gmail.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=chen.wang@linux.dev \
--cc=chenyou910331@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=looong.bin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=sophgo@lists.linux.dev \
--cc=stavinsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®