From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 038C12853F3
	for <linux-kernel@vger.kernel.org>; Sun, 23 Aug 2026 07:39:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787470771; cv=none; b=TX5uNST0q+ky/8yPjxWwh5tFTGn1qFHHNJWoD6BDKVP/e7v4q2W3WlK7Vkmdf7+8ImdJfqiYTvEntYcX4OxS2tEd8LTYbDX6R5kPCK5VIVh6CSALxTOVb0HxE+HBBsIq2YvAzuZjmkCIPJCEuKQIrDfeGLCVb22Rt/MCIjSzEEU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787470771; c=relaxed/simple;
	bh=OQ1UdRWdoVBtx7MB87nv0dfoUg85oOGEDyhIgA1XY7I=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=Hv6S9JxvYYwAX1Sz7vVVpQnQGnPphPOTgx778TenbuXAVB0iU7+lUitl+oD4L+42Bjk88eWxVrfThKsp1lk6EVQz63OFR+o3/i+7BCMSvUaqr8JgxW0TY4E/6+oPeVb/7gns7w1m9pDm2PvMoXeXdxjcxRw5dumKH5WCnGqD5U0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L6f2iutO; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L6f2iutO"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D153B1F000E9;
	Sun, 23 Aug 2026 07:39:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1787470769;
	bh=rB1jsGUuojkYKJwh0qxzHjSNA7rq8zyf57JSD5x6cWw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=L6f2iutOGFtzKX/8ZblKNBsANqnd1qU3V5YpH2wDSEsWH5BqFLyO4B8k8BAPvGqPQ
	 iz3MvD3068uGj13pWR7sry2GGrz/XslSwWhNA0xjWe9tZL5ta6M7PPKc9UUafjzeZx
	 MYvufbZV6GWEnzPctWCfg7Rxd3uhn3umK77Z1mWhyMzFCYVr3eY8pDOlOpPWwNX7Do
	 yc37a6mDloeb5J/1GfpBy764i4o255JbtM8Utnd2WQUsb7fK71vCQpc9S+mTC/lL6Z
	 9VkOkWdXLPlfXGp2LRywoFyd14TpU5OvO5fL1/1ndIji5etYlabWI9jqQ1R52+Obtc
	 IUitXeXLRcZ5Q==
Date: Sun, 23 Aug 2026 10:39:23 +0300
From: Mike Rapoport <rppt@kernel.org>
To: LongWei27 <longwei27@huawei.com>
Cc: Alexander Graf <graf@amazon.com>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Pratyush Yadav <pratyush@kernel.org>, kexec@lists.infradead.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	hewenliang4@huawei.com
Subject: Re: [PATCH] kho: Convert error handling to immediate return pattern
Message-ID: <aoqjq4kLCCSJtdP8@kernel.org>
References: <20260822064127.498411-1-longwei27@huawei.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260822064127.498411-1-longwei27@huawei.com>

Hi,

On Sat, Aug 22, 2026 at 02:41:27PM +0800, LongWei27 wrote:
> From: Long Wei <longwei27@huawei.com>
> 
> Replace the chained error accumulation (err |= func()) with immediate
> per-step error checking and early return in kho_out_fdt_setup().

You didn't explain *why* are you doing it.
 
> Signed-off-by: Long Wei <longwei27@huawei.com>
> ---
>  kernel/liveupdate/kexec_handover.c | 32 +++++++++++++++++++++---------
>  1 file changed, 23 insertions(+), 9 deletions(-)

-- 
Sincerely yours,
Mike.