From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCE213D524C
	for <linux-kernel@vger.kernel.org>; Sun, 23 Aug 2026 14:30:19 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787495421; cv=none; b=ZZCN34Rr6HXv7lqBNvGiPBy0fF0H047ZpGFPL6LKvAw7nTp2Yog1WSjx1HCEf/dDpSXZsGx1nkYdxG+4gVB4fxcriSM6CQYBeL8wxm3dPvgO1/H6QuKLGWuq8chxXjWosBDFSe6/BhymspRS/Ii3+V2rBfweSfqLUDvSNH1qYV8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787495421; c=relaxed/simple;
	bh=6f6pOCJSRCFZuGE7fUPBxQr2g4joc0POaqK4vbmBdHY=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=iMFIAkzYvw/bEkx7ZBO5X+phSUXGJrqOcYDg84twd/iVvz/MVovMRP2XGXrdSeyx1VvJVGnoGOTIsqWHIGkZCuDc0xcSHtX8M7ITMP+u6oc9a1v+9mSTWIbISRgh7MhDswYPnv8uQbikNHkXPVXUnSe7j20AKaXxd3Ziut5Gf3U=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iaVTKTig; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iaVTKTig"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 201FB1F000E9;
	Sun, 23 Aug 2026 14:30:15 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1787495418;
	bh=TplePkvwxXwaIo8VD5LQPXlaM4B5k2qGrj3Fbwy9i/Y=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=iaVTKTigpTYRL3cvVH30nbiAFwLl6f2MDf1sQBKJMyNgwfanbvYVmxCUxSPMqZeWE
	 afAkfdTjNpfhH7E+keuUSbR4jKFb3TB6jQDS7//a1yUkrnm3jzT0PMGO7Pe/rJXqIW
	 VP6GgPfJOaUI0kUz6Fxf2TpBC4tPA68Zqa3f9plxf6t6zrWtWvjovkUIwmtIRgmdsg
	 RsMcCZCR+H6ClumRCi7QK1IVC47kUlqwDLEmvaDyXBhriu8alaVA6eGj7Z5Xl98n66
	 Nl/N4lTVC7Hhr5P9gcTFSMdnNtphrIyfWEQ6b6sGPvoRSKsFdwbnfjjsIzfsY3VNB5
	 koggEg3H/e9YA==
Date: Sun, 23 Aug 2026 17:30:12 +0300
From: Mike Rapoport <rppt@kernel.org>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: Hongfu Li <hongfu.li@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Graf <graf@amazon.com>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Hongfu Li <lihongfu@kylinos.cn>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memblock: simplify reserve_mem_init error handling
Message-ID: <aosD9E8ntZF1RLxz@kernel.org>
References: <20260821033230.55210-1-hongfu.li@linux.dev>
 <20260822032327.3548986-1-ekffu200098@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260822032327.3548986-1-ekffu200098@gmail.com>

On Sat, Aug 22, 2026 at 12:23:23PM +0900, Sang-Heon Jeon wrote:
> On Fri, Aug 21, 2026 at 11:32:30AM +0800, Hongfu Li wrote:
> > Return prepare_kho_fdt() directly instead of assigning to a local and
> > returning it on both success and failure paths.
> 
> Thanks for the patch, but the same change was already posted [1].
> As mentioned in the cover letter, I can send it as a separate patch
> if needed.

Please send it as as separate patch, as Mark requested.

Hongfu, I'm planning take that one because he was the first.
 
> [1] https://lore.kernel.org/all/20260723184538.3888637-37-ekffu200098@gmail.com/
> 
> Best Regards,
> Sang-Heon Jeon

-- 
Sincerely yours,
Mike.