From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from casper.infradead.org (casper.infradead.org [90.155.50.34])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6466E2BEC5F
	for <linux-kernel@vger.kernel.org>; Mon, 24 Aug 2026 02:54:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787540074; cv=none; b=UWiv3RLOI6QlH9pLDcNgYgLCp5QqTKNt54CKxdhcwvbn6kIaCa4Wx1YSAehlaKdVTALb+ZADgIFIE3JEpgfWYOkSseTC5g2E2Rw9svDT1cglmEoIZw8a/M5Ncqnx8NscBSd6PdhngcSgRe39Yx8H9vY7lIcykLMlyTLSv8q3nB0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787540074; c=relaxed/simple;
	bh=sO3DlEpRPic3t2vdh6Iu/QpbD4F4fO169Az5wdr0qiQ=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=ZIAtX9bTycHrtwIFbEITPe900cdY/ENrbY2S7Ky2Pw+miXUw8xDdNZBuoKDLYDVfr9mfQI7TNz5fg2h615ykh7ZEGxoZQ5mwRons13yduLhS8/xOvRh6eRJfgcieeSEqOYy5dp1UVRdRzB/6eWFZ23gKB7eFQGTRnXwiqb/8/38=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=I3Zhc/oD; arc=none smtp.client-ip=90.155.50.34
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="I3Zhc/oD"
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
	References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=wFdw7194L4fQEjhILHsILl9N8tSIJ2MhybMqVmE6L9c=; b=I3Zhc/oDSZneTHNYEcBzwB7KwE
	IgYOz6SYVEGwUZ7c7+eWBOnZo9sC47x0//cEJTiJNJimNS/yaFJIEj0kOPCEbCeNSJ0qtky6x5nRa
	8kHHPfRVtdYOjj5aI/fxWHSDypOawBjXjd+asw8mys0PcX0Vc8c7XASu1eZC3qt7PngTkkZ1nxzGq
	kGFkdtg63vEEGnjaeuYAAjTUurHJDo9mnW0ofEYxNsVvKEDXbmjuJmOWQDs494gIsoah1JWuQpI4V
	bWSFipWf2u//ng+3KHQVKsJz5ZCxV+BBUkaRWYnLJlRC9uXFWliYif8pg6/7QrH+h6mNhuNuBaefT
	o8m2mUFA==;
Received: from willy by casper.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux))
	id 1wyKpG-000000058gY-2yd1;
	Mon, 24 Aug 2026 02:54:18 +0000
Date: Mon, 24 Aug 2026 03:54:18 +0100
From: Matthew Wilcox <willy@infradead.org>
To: LongWei27 <longwei27@huawei.com>
Cc: Alexander Graf <graf@amazon.com>, Mike Rapoport <rppt@kernel.org>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Pratyush Yadav <pratyush@kernel.org>, kexec@lists.infradead.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	hewenliang4@huawei.com
Subject: Re: [PATCH V2] kho: Convert error handling to immediate return
 pattern
Message-ID: <aouyWs39qxGI7CP0@casper.infradead.org>
References: <00c96a62-f783-497c-a7ac-1de495e4af06@huawei.com>
 <20260824024448.550552-1-longwei27@huawei.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260824024448.550552-1-longwei27@huawei.com>

On Mon, Aug 24, 2026 at 10:44:48AM +0800, LongWei27 wrote:
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -1438,20 +1438,34 @@ static __init int kho_out_fdt_setup(void)
>  	int err;
>  
>  	err = fdt_create(root, PAGE_SIZE);
> -	err |= fdt_finish_reservemap(root);
> -	err |= fdt_begin_node(root, "");
> -	err |= fdt_property_string(root, "compatible", KHO_FDT_COMPATIBLE);
> +	if (err)
> +		return err;
> +	err = fdt_finish_reservemap(root);
> +	if (err)
> +		return err;
> +	err = fdt_begin_node(root, "");
> +	if (err)
> +		return err;
> +	err = fdt_property_string(root, "compatible", KHO_FDT_COMPATIBLE);
> +	if (err)
> +		return err;

Less verbose:

 	err = fdt_create(root, PAGE_SIZE);
-	err |= fdt_finish_reservemap(root);
-	err |= fdt_begin_node(root, "");
-	err |= fdt_property_string(root, "compatible", KHO_FDT_COMPATIBLE);
+	if (!err)
+		err = fdt_finish_reservemap(root);
+	if (!err)
+		err = fdt_begin_node(root, "");
+	if (!err)
+		err = fdt_property_string(root, "compatible",
+				KHO_FDT_COMPATIBLE);

up to the maintainer which one they prefer ...