From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F59F757EA for ; Mon, 24 Aug 2026 06:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787554405; cv=none; b=MWgzTTvfRkv3T25mHopJ2OcTsTxk/5n7+PljfhqDtvZ32xJehTIFvhVmlv40yWJY/qXeY6ZYf7JPN71s5+EL9P1UnFTatjdIzxhFWm3Sbu/S992IcPlYlc2d+txblY8kglV604NB56OllfABIenNzliEy91hAdwkElueppPKjyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787554405; c=relaxed/simple; bh=pO4KxckqlmOau10oim4Efs8550QkOWuJvAT7+QzfHKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IExDWLITVi2zXkbxpkFQVWdFw2Bi+oyUCM+tY25/6ioQ7tN2m7oncmfKFz7qT+0rOxFf6bSb0PVHHPVM5O3cj7HYZacQedcovR218fhMJIdsgsVxRtac4tBexztdVUL6DjsdyfyKG2UOaNO+WHSLg7cgbbL5VSJN32tjfm1V+Jw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rp+gfc6N; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rp+gfc6N" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4954dff6536so23298995e9.0 for ; Sun, 23 Aug 2026 23:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787554402; x=1788159202; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=w1tc7P+DJ2q/zsatiojt2TmU1wmqNBXKru1RDam6Ht8=; b=Rp+gfc6NwgA+NrTUctxTLGBFtyfQle4ijZU3f6JPCM6NWwHvRCmAk1SpseE7CvRjKP GnrVhX+iDOsWb9hiW6mGV0lM9rOmersPI55SlcdiODNtGFS6vFGQ730YpDofxlhQjHjJ /0YFRmUm2wI2KdfVlWtYf3tEYadCLkED3teWsuCNzY8lV/jclQ6cfWHQzSpQDNijkC3O p7g3lx28R7Z8xDu9pcVNRnveIqxpNzlEne+nBK5naDifKXLDpx7Z/U7Jk00xlN4Kns8J cpwR8kYfprBxdekgJOOo9J2w6EXzRzHCPGja9VBwBpxaN2BSVwgowqz8+pEYHNiAmRxh t9lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787554402; x=1788159202; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=w1tc7P+DJ2q/zsatiojt2TmU1wmqNBXKru1RDam6Ht8=; b=n+klpS5bj8U31irHcPoWoU++JVlN8cb/DNXiG/KzglSydHuwvZHUu/Es/DMa2gffRi lhLd24q0StF0XX+J34ZMeiZErjuJGnma0laQW9cl+Ka2e23jI/VyQs8+looQdA5mcy2k cwQ6s84CC2mqVhywOhvj6H0tiNu9jcnzkjXx99O2RUhsJQmGfHoyU3EnaKvNRRPYgDxi kxb2afPwq0uUh9KUdRIUvVQZNkRtz44uQeRUEzNyhsLnPqmIsRvUmij0o136IjGyBZNY CC3wGRVXIU0ega5fX/w9mU7XrFrI/k0+drUm1yR6zLkHNjWgyY1dUEYLW5zCCdZtU5Sk 76bQ== X-Forwarded-Encrypted: i=1; AHgh+Rok7xaqHGFo4JMiYNW5B9wcmfOd4wjmedRQG8DAnfSujM0TrYhSernCmZKcGUQwDzhizDduw/QQuBA5yvA=@vger.kernel.org X-Gm-Message-State: AFuF++kjGklbAmnRlfb6enZ3T2vM4MtTRWy3GSMPimxs7AuE15MV907u Roh6ilSE4gVcapcyetBDbs+pP7ZpuDfYaNMjpglYTWFXd3V+1kMEhkIM X-Gm-Gg: AR+sD13rA0WOUW1gwOYuycsCblPfFUzATvLlJUONkLtsqKFEyx6FSfKpMlFle4e8OQx cfiJHYw1di9feh/4cglRpIoCCAH9xdXyjUHibhDzJvgiuQ2E3kJZOnfGM5OTLgs654CUv9M6ic5 ePex3jjtB5dQyeFgpHV1DLWV7SFlwFtjyaL0POLggUfRtQ0ve1HnDcr7csbm89Gd4hKs7KJ4Zvd YzetC6BzGnNZ2/t6lO+hfwvGvzGmguyvihlO5UFklRaJkCmQ7qS1StA9Uw0gS4ZA7uro4UNMXJM cHAPvrO5rEUxHbnf1Oz1Uygf44S7/Pp88cJrfJ6YWKS2X6l0QUusm5v5UAW356B/3UUOtwHWh6D 8dc+nzn6drRbcNEw+6xxYFoTYZkNwSaeskgWsTnYhEU9ZbJrru+feM6kJDS3ZCmeVItI1a2/HIi yGEr3P1E61h7QaKru1Xca17HGR1AknYaW05TYjTyGRwon9h+mnHTNzvPS+ X-Received: by 2002:a05:600c:4e47:b0:499:60bf:c6f7 with SMTP id 5b1f17b1804b1-499b8464503mr298725135e9.13.1787554402293; Sun, 23 Aug 2026 23:53:22 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499d2e7a8f9sm4908765e9.10.2026.08.23.23.53.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 23:53:21 -0700 (PDT) Date: Mon, 24 Aug 2026 09:53:17 +0300 From: Dan Carpenter To: Samrudh Nelli Cc: gregkh@linuxfoundation.org, ethantidmore06@gmail.com, azpijr@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] staging: rtl8723bs: modernize locking with cleanup.h Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Aug 22, 2026 at 11:53:45PM +0530, Samrudh Nelli wrote: > This series modernizes the mutex locking in rtw_pwrctrl.c by utilizing > the guard() and scoped_guard() macros introduced in cleanup.h. > > Patch 1 converts functions where the lock is held until returning. > Patch 2 converts functions where the lock is dropped mid-execution. > > Samrudh Nelli (2): > staging: rtl8723bs: use guard(mutex) to simplify locking > staging: rtl8723bs: use scoped_guard() for mid-function locking We're not doing this sort of change to existing code unless it's part of a bugfix. It's just a lot of churn. regards, dan carpenter