From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 566FB137750 for ; Mon, 24 Aug 2026 07:08:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787555329; cv=none; b=TrSafnJAg4xIZScOt/Xx6keixgojT5DeJ3hkK3sVdk9p4R19KOzA774+odlrHNPcpCi/4vn1q8PqxvL1EDBDRjp1dOwojwt7lm0LdSEREyzbWlCvts8+vyp3UDNbbhWOF6z55aRjq5A8PXQykJOCfOLK3jtM6ONBWpJCpqTjARE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787555329; c=relaxed/simple; bh=1CuRtmpb8VEj2j9q83La3hC/CxtkpmssA4kaLk8iY40=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mbkb01eLySgstET44wN7yq2ZZlZJglG7eeOnDekNUTe/QKuS5bLc6myvQZTEfKZ40W5A670AiS9e1dS9snqvMcXqcE5sMJ8pCh3IhkOrdVZcna8PQhdJ01Iqq0S+SDRYOU6CtxSH4Dj5ofqeuplx+9rIDZW6BgypxzsxhIrOG0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nEmYBC0Q; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nEmYBC0Q" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4996f1ee4a4so20292285e9.2 for ; Mon, 24 Aug 2026 00:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787555326; x=1788160126; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wJfaLrDf5XZY2pXU/P43cPJ1i0a1rovzINLp1pW1sik=; b=nEmYBC0Q7ricz/CgG/XtCcK1eO5OrBwChU5WmI4OJfC5ANwqtB1S/uyZy+yM6Xzerk ZwumvuaIOHFLIrxLj8NWfxcwHaAUzSkGT4VUlEr/TACZAtGS4Pf1L4SKm2PeXycGK4rm Wk+oOtJt1PRIzHMwEb6rPsPwAFSmp/fnHQRrzpRV1272zkYC6m5E7xWy50G57VfPfrE1 cK9diHtK3oIovRG7fzIlVo/f35C9AFsjGXPV2LvWbCV3G/LMBarsGmeyQl8aZZU7CHYD 32+KHeGivowgcCUH/yu35HkpaEjP3D2r02nb/iDfCu+m8eCFXUI7AJdgg6whMw46JQdL FFMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787555326; x=1788160126; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wJfaLrDf5XZY2pXU/P43cPJ1i0a1rovzINLp1pW1sik=; b=diOjVS5p8Co6uyXAqDapmtREtLdnUFNzMLWzhL4wo3Uty29jfJ9OUaPtG+gngFKlqD z0XKQc9BuXD+re/SHu9XSCSgpxfWnVxzapLBVYZQCTesj5Z9hFyaZZlz00aj5bqq/GRj im4fQ8yNNvobQkOnKvCa2/r3lsiZwcnXpXjsaNnkdKrTFR+99rYIVhbTmnXvX+TuwZhU iT8YxBStVRBeAR03ZfaQ9Jw/+OZgpmnjHaqlwnq/RSComIkxd6bC5k3JignIkrO0dhuS HcLke6a8TmAHOrbI7yQabFnSF4v07s4payBqND4vYFM3TjtQgQeprhspwwTvoXkQd2nS yCwQ== X-Forwarded-Encrypted: i=1; AHgh+RpxMvGyFNyCY5rVetirqrtRL0KqTYCojQg9sGyDDG6wcWy+RwLnOSixnznlIGrpgaHQyShIUaoX9ldU67Q=@vger.kernel.org X-Gm-Message-State: AFuF++nB5QiJo387gWWmBI92SRwKSE9HbwRPDi0ScNZHwe3i8CjWYI2S jvOWkMW/NMPx1X0EWWX6IRfTScW+ej5bMzAWqagiZp+HpwqLXwlejtgJ X-Gm-Gg: AR+sD120H52vt54UYrO0Bwo0I03IrmsVcIKH+g9Jl8gps0ep7x03OJv0NQUaVJKjLJ0 bNRLavkk0JT79/x2cjFUg6F+DtIXe+OetNGyNoUNLdbD1oyKPyQF5idSnCBAWQ4qofOFxtH/3hm bErR4hJpr0YG5zBGpNuCvhVFdL0FHHuiJIBwnMEo+E2yI6I/q9UHSK4qVlKXuc6XwcXsJEpJcFE s//6z7vVSopVeBYLt9xoMdPitjFUoxnBO0txqrI97GoUTJnPMdikBMwgTNdrAhkiPUWaB715L+d X3V8Gm+qwmHY9SQy72c7lYqlz8bxb5zTsgwmM5zRqsTv4CQkYdyDkUjh9dxdod8MG+YzBmyv+5q ruswhf2PREKV7lQ1TIyJY5+OslG+Mj0BIomJwEQp1d7j6iQf8JJMAhrS/YWVHMKzm0bYmFk0EfX GoyzR6zfuuDssK0IjCXvSMRs+pdkqrs+0/gqHScmZ3f7IujXf3mjReuyi2 X-Received: by 2002:a05:600c:638d:b0:497:fecd:5b00 with SMTP id 5b1f17b1804b1-499b8457084mr316416545e9.9.1787555326336; Mon, 24 Aug 2026 00:08:46 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499c355e1ddsm73590055e9.5.2026.08.24.00.08.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 00:08:45 -0700 (PDT) Date: Mon, 24 Aug 2026 10:08:42 +0300 From: Dan Carpenter To: Kosugi Souta Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: audio_manager: add missing newlines in sysfs show Message-ID: References: <20260823011424.30697-1-k.souta0926@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260823011424.30697-1-k.souta0926@gmail.com> On Sun, Aug 23, 2026 at 10:14:24AM +0900, Kosugi Souta wrote: > sysfs show functions should terminate output with a trailing > newline. Add the missing '\n' to the six show functions in > audio_manager_module.c. > > Compile tested only. > > Signed-off-by: Kosugi Souta > --- For old code, search on lore.kernel.org to see this has already been discussed. https://lore.kernel.org/all/?q=gb_audio_module_name_show regards, dan carpenter