From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Jacky Huang <ychuang3@nuvoton.com>,
Shan-Chun Hung <schung@nuvoton.com>
Subject: Re: [PATCH v1 2/4] gpio: shared: Replace open coded fwnode_is_gpiochip()
Date: Mon, 24 Aug 2026 11:37:18 +0300 [thread overview]
Message-ID: <aowCvk7Em-8AoJ0d@ashevche-desk.local> (raw)
In-Reply-To: <20260824074427.3226457-3-andriy.shevchenko@linux.intel.com>
On Mon, Aug 24, 2026 at 09:42:33AM +0200, Andy Shevchenko wrote:
> Since GPIOLIB provides a helper, no need to open code it, hence
> replace that piece by fwnode_is_gpiochip().
...
> - np = args.np;
Ah, this one is important.
It seems that
struct device_node *np __free(device_node) = NULL;
needs to be replaced with
struct fwnode_handle *node __free(fwnode_handle) = NULL;
or something alike between the lines.
> - if (!of_property_present(np, "gpio-controller"))
> + fwnode = of_fwnode_handle(args.np);
> + if (!fwnode_is_gpiochip(fwnode))
> continue;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-24 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 7:42 [PATCH v1 0/4] gpio: Unify the GPIO controller node check Andy Shevchenko
2026-08-24 7:42 ` [PATCH v1 1/4] gpio: Split fwnode_is_gpiochip() helper Andy Shevchenko
2026-08-24 7:42 ` [PATCH v1 2/4] gpio: shared: Replace open coded fwnode_is_gpiochip() Andy Shevchenko
2026-08-24 8:37 ` Andy Shevchenko [this message]
2026-08-24 7:42 ` [PATCH v1 3/4] pinctrl: ma35: " Andy Shevchenko
2026-08-24 7:42 ` [PATCH v1 4/4] pinctrl: pistachio: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aowCvk7Em-8AoJ0d@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®