From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
"David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Martin KaFai Lau <martin.lau@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH net v2] net/socket: remove unused do_sock_{set,get}sockopt() exports
Date: Mon, 24 Aug 2026 01:49:59 -0700 [thread overview]
Message-ID: <aowDuGnk58kEwqO6@gmail.com> (raw)
In-Reply-To: <20260822123957.694f2812@kernel.org>
On Sat, Aug 22, 2026 at 12:39:57PM -0700, Jakub Kicinski wrote:
> On Fri, 21 Aug 2026 01:28:32 -0700 Breno Leitao wrote:
> > do_sock_setsockopt() and do_sock_getsockopt() have been exported since
> > they were split out of the syscall handlers for io_uring to reuse.
> >
> > io_uring is the only caller outside net/socket.c, and it is never
> > modular: cmd_net.o is built under obj-$(CONFIG_NET), and both CONFIG_NET
> > and CONFIG_IO_URING are bool. The declarations in <net/sock.h> are all
> > it needs, so no module has ever been able to use these exports.
>
> FTR I'd prefer this export (or something along these lines) to having
> to add individual helpers for every sockopt for in-kernel networking
> socket users. Maybe other maintainers disagree.
Fair — you and Christoph disagree here, and the nvme-tcp series needs it
modular.
I'll park this until that settles. If we decide to keep it, I would
suggest we change it to EXPORT_SYMBOL_GPL, at least.
--
pw-bot: rejected
prev parent reply other threads:[~2026-08-24 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 8:28 Breno Leitao
2026-08-21 8:58 ` Eric Dumazet
2026-08-22 19:39 ` Jakub Kicinski
2026-08-22 21:46 ` David Laight
2026-08-24 8:49 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aowDuGnk58kEwqO6@gmail.com \
--to=leitao@debian.org \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®