From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Kyle Hsieh <kylehsieh1995@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] iio: adc: ti-ads112c04: Add support for TI ADS112C04
Date: Mon, 24 Aug 2026 11:46:34 +0300 [thread overview]
Message-ID: <aowE6mvlRw8RrGl_@ashevche-desk.local> (raw)
In-Reply-To: <CAF7HswOMH2FGEZR+ZASDrSQjgi_YCd=6ZUoxTdTBfwsec3Y5YA@mail.gmail.com>
On Mon, Aug 24, 2026 at 04:09:14PM +0800, Kyle Hsieh wrote:
> On Fri, Aug 21, 2026 at 6:59 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Thu, Aug 20, 2026 at 03:51:52PM +0800, Kyle Hsieh wrote:
...
> > > + /*
> > > + * Datasheet: td(RSSTA), the delay from the RESET rising edge to the
> > > + * first I2C START, is 100ns minimum.
> >
> > This is order of magnitude delay. Do you mean 100 盜? (Actually would be good to
> > use Greek letter in the units, looks much cleaner in the comments.)
> >
> > > + */
> > > + fsleep(1 * USEC_PER_MSEC);
> >
> > Otherwise this should be simply 1 (no multiplier).
> The datasheet says 100ns minimum, so the comment was right but the delay
> was far longer than needed. Changed to fsleep(1) and used µs in the
> comment.
Note, we have ndelay(), so using it as ndelay(100) might be even better.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-24 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 7:51 [PATCH v6 0/2] iio: adc: Add support for Texas Instruments ADS112C04 Kyle Hsieh
2026-08-20 7:51 ` [PATCH v6 1/2] dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04 Kyle Hsieh
2026-08-20 7:51 ` [PATCH v6 2/2] iio: adc: ti-ads112c04: Add support for TI ADS112C04 Kyle Hsieh
2026-08-21 10:59 ` Andy Shevchenko
2026-08-24 8:09 ` Kyle Hsieh
2026-08-24 8:46 ` Andy Shevchenko [this message]
2026-08-23 0:06 ` David Lechner
2026-08-24 8:00 ` Kyle Hsieh
2026-08-21 1:25 ` [PATCH v6 0/2] iio: adc: Add support for Texas Instruments ADS112C04 Jonathan Cameron
2026-08-21 3:37 ` Kyle Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aowE6mvlRw8RrGl_@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kylehsieh1995@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®