mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: xiaoyueyoqwq <xiaoyueyoqwq@gmail.com>,
	andi.shyti@kernel.org, westeri@kernel.org,
	linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: acpi: Add DELL0A86 to i2c_acpi_force_100khz_device_ids
Date: Mon, 24 Aug 2026 18:00:03 +0300	[thread overview]
Message-ID: <aoxcc4tkTcgv5is_@ashevche-desk.local> (raw)
In-Reply-To: <20260824102221.GE893316@black.igk.intel.com>

On Mon, Aug 24, 2026 at 12:22:21PM +0200, Mika Westerberg wrote:
> +Andy

We need to convert the ID table to use C99 initialisers and drop the unused
driver_data. It may be done either before or after this change.

> On Sun, Aug 23, 2026 at 08:33:10PM +0800, xiaoyueyoqwq wrote:
> > The ELAN 04F3:3185 touchpad exposed as DELL0A86 on the Dell Inspiron
> > 13 5310 intermittently exhibits excessive smoothing when the I2C bus
> > runs at 400 kHz. During an affected period pointer movement becomes
> > severely sluggish and sticky for tens of seconds.
> > 
> > The ACPI firmware configures the touchpad bus for 400 kHz. Add DELL0A86
> > to i2c_acpi_force_100khz_device_ids so that the bus runs at 100 kHz, as
> > is already done for other touchpads exhibiting the same excessive
> > smoothing problem.
> > 
> > With the quirk applied, the kernel reports that the firmware requested
> > 400 kHz and that the bus is forced to 100 kHz. The problem did not recur
> > during extended heavy use, including an S4 hibernate/resume cycle.

Is here any bug report somewhere publicly made?

> > Assisted-by: Codex:ChatGPT-5.6-Sol
> > Assisted-by: OpenCode:Ox Alpha (x-preview-f-free)
> > Signed-off-by: xiaoyueyoqwq <xiaoyueyoqwq@gmail.com>
> 
> You should use your full name here.
> 
> Anyway looks good to me.
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Otherwise agree with Mika's judgement.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-08-24 15:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 11:56 [PATCH] " xiaoyueyoqwq
2026-08-23 12:33 ` [PATCH v2] " xiaoyueyoqwq
2026-08-24 10:22   ` Mika Westerberg
2026-08-24 15:00     ` Andy Shevchenko [this message]
2026-08-24 11:18   ` [PATCH v3] " YuXin Xiao
2026-08-24 18:15     ` [PATCH v4] " YuXin Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoxcc4tkTcgv5is_@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=westeri@kernel.org \
    --cc=xiaoyueyoqwq@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®