From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B5031F3D56 for ; Mon, 24 Aug 2026 20:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787602618; cv=none; b=P8uFKPKHuCDHGljF2N9r8HDBTPbKQ2UoPSv8+5G1O/z8gM0OPNvefpJTXa4tpyIw/SvDBs9UMUu23QLkeGFBtWBNrZCDpqrssXnph2tdh6Gl/jxgIeb4/hKLVM+U3TUT0auyT4YwkhC9sVz2lD+3tnRZXaKfuiGhwQkIxMVwqd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787602618; c=relaxed/simple; bh=hQjlGuZlCnDHfkbrg+tQFOHCoJBhwQJXTENokNCYpwI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mZNktKA9hQG3nC41IisFiJhlksPwfT1qSzwPu+BZ94M4vwRgdun+jljn76sylAIXvak2U/jz3jWTngtY2a+WYuE5GEiLgChNx4mpWcXwyQObBT/i5LDXsfiAFxnn9GhcFG7+aWGkjYcDt7b8kehqvdA2eS/dReAhTsMky2RV7EQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=u1kJfFje; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u1kJfFje" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38deea72eebso4604678a91.1 for ; Mon, 24 Aug 2026 13:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787602616; x=1788207416; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/UVYXaYGpqOjS4wy3Xiwfv8E1t/SazvgREqms2nJdOQ=; b=u1kJfFjeX5oFqFookgth1QWuJfUwok/5XqPn+10Hiuig05MQd4qqwy0hZn668UQLc2 XsEzegKs/vGs+SXDYLDcYx2RvgCehiI+nCToZOPYAjzuH8H3tvasFG01Y6nCmCZIvhqX i8Ueq1JdlKCTPP//YhGV6eQxL+l9xxOFzGzd13hNF0D0riwkmrWV6UINM097j983faG1 KdKh8eqt3gUgviys/sYp+7hV1ZZBE3jfNl8VFnb10kTA2mDnsYLlx8wJ3KAjlGT4omV1 TRYwMHGt2i7Z4Eg0tNcLsWhJowtNMtt7YcPmDLY3TQJUbSFpr3eg7O22AZXLk50JEVMl OSFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787602616; x=1788207416; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/UVYXaYGpqOjS4wy3Xiwfv8E1t/SazvgREqms2nJdOQ=; b=CTnNEqLFVfPLzFJ+LQxnghcYDcUN+NPSbZ6Fea7XA9q+PcOkynxiDIP8ExKiY461Lo 59hY5amecWfoLqSw/ECjr0iplaJAGTrTkXIFuBiPdeiek3nQp+ta3HLJzTi7wwSSNztB MBj5zCgVeD59BDUzraxNa9kJV1FXpg24vJax157F1H+WVeqfpF7SdYnobma78UG2nZtK zqAjCEDnsHLvVkPz2sa95SOVx+LRFsZLxQKilUHXRC+QETeUeUme9UWxLGgxV/w7qUfb uO4BqWWdj2mykcnCRKWbwCA1HoOrVmLQ6/MxrXtproz4LCIBncxGZ71/CQn83gSwoqnO B8wA== X-Forwarded-Encrypted: i=1; AHgh+Rrp66HNtUkNNXhJNj5gvkoevfJpmcGYD8j9sGlG25KyFMd9eFBy+R3nB/+sVW5Xv59PMQRVO6kkBFIVsf8=@vger.kernel.org X-Gm-Message-State: AFuF++kHjcQ3gM+FXnHcJ0Me+P4atl+fc0sIZ7auOA9Yp7gjgDKJBGbe nwGRT6e/GpCT6Wtv7wzeA/MI4QXpz2fxvx+jPSws4utn5gX2FuqnxhGCYk2wbG1OkA== X-Gm-Gg: AR+sD10f+g5ej4PNnUa+5r/oQZctFwR5Fm/h8h6YTmlbTGSc6vbzTZ24TH2BTKd3T9q nmbUeTNg/End9h37CA8oBoaAlWZ32y8OvQOfsw8wIDAy9x/il3CZvE/WwZRVhzsUaTPF46gbS76 JiU0gQI/4hReU1Tox381M0Izk222W920fFhftF6peADkaFIMzRnubXTL8UvyPZxrewHE8yaRP7l BNzX43I25J9glSNum+EsA6tAGmALC0lm8MF79h02eDZGHqcTLz1cOjrmkqmC78pzwwmW0/6A+w0 +EtbRaHgSUsflSNzMIgRQibwr2na4vZXcqqSbTW6cp9IZM6iYACLtpFPY05LGl4S8/rqAY2XJAG DKrW1ObP+aHH8S6wyHhFigPx1qBHPZVmmE+C3eUxvWbhu/lS3THdBfpcjgFtyrpKepjfeCHsMgJ wZmAFh1ngd5RuhG2yjHoe5l96KIHMDLSQfRzjbjUhze9uoxRew3SsyxDdWnqYvakI1ab/Z0uzg+ waezjM4rPXhrKLvk+2GytQtkSxKyQ186LLqq+Ta X-Received: by 2002:a17:90b:1801:b0:38d:b36e:9813 with SMTP id 98e67ed59e1d1-395df25998dmr35769803a91.11.1787602615899; Mon, 24 Aug 2026 13:16:55 -0700 (PDT) Received: from google.com (132.200.185.35.bc.googleusercontent.com. [35.185.200.132]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39645bbf59csm809431a91.15.2026.08.24.13.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 13:16:54 -0700 (PDT) Date: Mon, 24 Aug 2026 20:16:50 +0000 From: David Matlack To: Hisam Mehboob Cc: kvm@vger.kernel.org, alex@shazbot.org, shuah@kernel.org, seanjc@google.com, jrhilke@google.com, rananta@google.com, vipinsh@google.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/vfio: Include for basename() on non-glibc builds Message-ID: References: <20260821122110.902382-2-hisamshar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260821122110.902382-2-hisamshar@gmail.com> On 2026-08-21 05:21 PM, Hisam Mehboob wrote: nit: "vfio: selftests: ..." > sysfs.c calls basename() but does not include its declaration. > Glibc exposes basename() through with _GNU_SOURCE, while > musl declares it in . > > With musl, this results in an implicit-function-declaration error and > subsequent type-mismatch errors at the callers. > > Include so the declaration is available on both glibc and > musl. This is safe at both call sites: the arguments are local writable > char[PATH_MAX] buffers filled by readlink_safe(). > > Link: https://lore.kernel.org/kvm/CALzav=fs4bqMM7BXNPXqhtbqGzA+LW5fgx2-1Q5=sTN5+krYhw@mail.gmail.com/ > Fixes: a262fc49e0aa ("KVM: selftests: Build and link selftests/vfio/lib into KVM selftests") > Signed-off-by: Hisam Mehboob Reviewed-by: David Matlack > --- > tools/testing/selftests/vfio/lib/sysfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/vfio/lib/sysfs.c b/tools/testing/selftests/vfio/lib/sysfs.c > index 11415448b2e2..daf117a299a6 100644 > --- a/tools/testing/selftests/vfio/lib/sysfs.c > +++ b/tools/testing/selftests/vfio/lib/sysfs.c > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > #include > +#include > #include > #include > #include > -- > 2.51.0 >