From: Carlos Maiolino <cem@kernel.org>
To: Hemanth Selam <hemanth.selam@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: fix repeated words in comments
Date: Mon, 7 Sep 2026 08:20:50 +0200 [thread overview]
Message-ID: <ap5XvVR9nbI1vaRC@andromeda.toxiclabs.cc> (raw)
In-Reply-To: <20260907042402.12893-3-hemanth.selam@gmail.com>
On Mon, Sep 07, 2026 at 09:53:59AM +0530, Hemanth Selam wrote:
> Please drop this patch, one of its hunks is wrong.
>
> fs/xfs/xfs_zone_alloc.c
> "Stash our zone in the inode so that is is reused for future
> allocations."
>
> This is not a doubled "is"; it is "it is" misspelt. My change leaves
> "so that is reused", which has no subject. The correct fix would be
>
> "so that it is reused for future allocations"
>
> Carlos, you also asked me to fold the two patches together and drop the
> mechanical wording from the changelog - I will do that in v2 and include
> this correction, unless you would rather not see the series again.
>
Sounds good to me
prev parent reply other threads:[~2026-09-07 6:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 11:29 [PATCH 0/2] xfs: fix typos and " Hemanth Selam
2026-09-04 11:29 ` [PATCH 1/2] xfs: fix typos " Hemanth Selam
2026-09-04 16:06 ` Darrick J. Wong
2026-09-04 11:29 ` [PATCH 2/2] xfs: fix repeated words " Hemanth Selam
2026-09-04 13:16 ` Carlos Maiolino
2026-09-04 16:06 ` Darrick J. Wong
2026-09-04 16:06 ` Darrick J. Wong
2026-09-07 4:23 ` Hemanth Selam
2026-09-07 6:20 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap5XvVR9nbI1vaRC@andromeda.toxiclabs.cc \
--to=cem@kernel.org \
--cc=hemanth.selam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®