From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FAB74156DA for ; Mon, 7 Sep 2026 08:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788769219; cv=none; b=F+lrZbu24qfDv0BcuS6krSqatc15DLkhbt+7+mNuXogmbBD6gKEwXZuJ111N9FO8Bx66WAZqS6maLEH8fBUouTviW9i93cfSBuiZZFU4lsHgXpkDVfbhMt8nQiyKSzCcv/no5oWgwaDJVdQHdgwdbPRC/sOFQHC8CtxsLs04KJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788769219; c=relaxed/simple; bh=+rKOQJFFm5bYnGcGZ6XGvUk+Etwa8kXtuvtSPF9Nyzs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OB+5IK2lvpdK/goSLoVrjfwRraxtV/NifGglhlL53wdki57q2xUL04f3ruFawuJFlkfanc4dIG0MMv7doHlPe3nRePiYxhkcFnsbDgCa0L3D91AW85HR/5ZKYCSGVf0++r90G4C0OBGce/cpDhQH1U6oe5kWQiZYKy+aG7gT6n8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=PYz5b3+X; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="PYz5b3+X" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-49a97714f5dso30676705e9.0 for ; Mon, 07 Sep 2026 01:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1788769215; x=1789374015; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+rKOQJFFm5bYnGcGZ6XGvUk+Etwa8kXtuvtSPF9Nyzs=; b=PYz5b3+XLrSHetXQeEcJBtGmPDmPtcKkRkHvBQNZR4Yyolb/GOBpPsimvRPTVAJe80 h/bzeQTg7G9yoECPCCSGlL6EinfzFSHoKy7N5dzdPCoPHIbvjn9wtbqfeEYwPrq0+RaT YufpVWj9dj1+J/zSmR6pBxUNSKahi5t08gvi/+oCjSD9VoT5h45MwzecTcZ9SIURFzHO xYVrI/PcGzkHtQt6fNXfHcxNFqF5m1xeeanUUV1sM1S0ivSkialpMKf6SJ5XttRJilLP NGbJSG5h3HfjbYrqonfjN7FAHRkvWupRZEeNhwcAorcuIJXw60LGEHuUiBOAqXzgMNhQ MkvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788769215; x=1789374015; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+rKOQJFFm5bYnGcGZ6XGvUk+Etwa8kXtuvtSPF9Nyzs=; b=DyudQ0gQbYLr5yscF3P3xuBplwkmLQWRZGAuh/TBZ40qCID5ZQjVqcdxOFqK3vv2wl 12Z7KEovrophm5R1v5qkkmHkZBtOF5cKA80sOm9MFBr4joFXWfx1ITzo9T1B/STVFDuZ 1ah5ROIcwkOEyvV36y5nHXiI/uGSrDKjMpGK3J8s+M++r/TKdvqDGgRdEpjVxlg0WbOT JJu4hcq6ufY0O0OCC0q5SbuQ1K1PWfHYvUWof278MT2HbOQsFdkCYfX9cQ6MZR7Rkr+j I4073URvB2lZqRtWnrBC+ei4a0CjDtLA0JZnzWsvDSbh5DUpdpk5uCY9vBf2U6Ikkpxi CKXg== X-Forwarded-Encrypted: i=1; AKwUvBzb4Z/4IZtuykyH3gkcVoOrWQmytC6b9yemS3l93ntESObAai3NYAm3g3B3JtzQ80tiu0Z1FLfBJ9l8bzQ=@vger.kernel.org X-Gm-Message-State: AFuF++kmEnAveGyxXp+yb8MdMUJoJR/kpK3v1wbmhNjPaBAQPNBhTvvs FrLZOsjXxkusNuzDsZtCOJirFRaI23s0HwkPXOWnB3Qt+PX0CxIWo0o1AOGASkOOxbw= X-Gm-Gg: AYBFou2b/vtQqCB6gy69IHJIkyjWU+4N5ppXrR9KAYNDn1RdgPE2lsu1jwpeySJpjG4 pEtURMdktjOMDFKP9ddUCmGdo7KF9y/1BhlA6ylm9OaNDBdIzWa9rnGwckBqXQZ6JcAn+Nx6VKC ZDca9rt+oZmwgnLuN5SrGIEHf+GMHiMlzRrM9Jbt+ifhtsp99zc/kALE2clq6FCuIDpbFDHprFX IXQjwAvPyZWtFHdMDeZGHAjIBDOL4N/DN1JH3+jvyEwyAluZvw65sn7oxeT78fEDya0jDtR49Xe S9E0AbFN03yIjm1v2a3W3gpwxK/DF3pxj/F6zr8i5RexvvuKZFQrToKCGrc4Eaw33LBpFZDt8pf uSshQ/sMJbgL1LSZ0lGIgI3cVVx3Hii0M+9PSmo5X0kZ8UUtAsVZM8bQCIvn4CAiEVlU8TCPqNH WGOtPsrDo0u0T4vtk1BUZtZsgLNZ8fGZHr2UR96FaTOOxANuOilr0iJz2EM+ber2pOwQw/ZoYoU snFiAEV+Y1jyUEEZVDbAr2O8McwDebTVSZAwjZOr9udq2VHREiiFsJiNx4WvQ== X-Received: by 2002:a05:600c:524b:b0:49c:fa20:cc08 with SMTP id 5b1f17b1804b1-49cfa20cd2cmr189791795e9.31.1788769214222; Mon, 07 Sep 2026 01:20:14 -0700 (PDT) Received: from localhost (p200300f65f19a9047ae53bb37ada872a.dip0.t-ipconnect.de. [2003:f6:5f19:a904:7ae5:3bb3:7ada:872a]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-49ce58da3acsm802919035e9.0.2026.09.07.01.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 01:20:13 -0700 (PDT) Date: Mon, 7 Sep 2026 10:20:12 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: zjzhao Cc: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] serial: wk2xxx: Add WK2xxx SPI UART driver Message-ID: References: <20260904072027.67473-1-zjzhao@edatec.cn> <20260904072027.67473-2-zjzhao@edatec.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jcsnrjlgqtppepvx" Content-Disposition: inline In-Reply-To: <20260904072027.67473-2-zjzhao@edatec.cn> --jcsnrjlgqtppepvx Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 1/2] serial: wk2xxx: Add WK2xxx SPI UART driver MIME-Version: 1.0 On Fri, Sep 04, 2026 at 03:20:26PM +0800, zjzhao wrote: > +#include > ... > +#include Please rely on to provide spi_device_id and of_device_id and don't include . (Or include and if you prefer.) shouldn't be used as it pulls in too many things and thus introduces many unneeded build dependencies. Best regards Uwe --jcsnrjlgqtppepvx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqec7kACgkQj4D7WH0S /k6lwggAtl11TJBXSFbUtG1oE2b5lhT1yEeiEK6ibargxChJaR+TK7r7SrBtfe81 Xy9gJRVsa6vWh5N5auS7Sb2+k4rbYiFghuSnO7v4q6pMi5zAnh+iCYi9hzlB2yuU a5TCmhNg1vlEL6eLSK/Zs2IEXsrzfndIjjHUS06+6ypgxHgGJ2+EAUw+lgDb4MUN LGTsyEUrOsF4q/0GmLqRXld/VciDVAWNkDvubKROM3aTgo/WULivvvZSibfQqjLD KtG+CMmviDvLI3NyCCv7wjML2jLeOFhGQS+3gdxfoUP5LK9Prr4IFWoVJjzbR4pX J9QIFiOyMIec8yjX8Z6TUwbPPs4zgA== =VgUt -----END PGP SIGNATURE----- --jcsnrjlgqtppepvx--