From: Feng Tang <feng.tang@linux.alibaba.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Thomas Gleixner <tglx@kernel.org>,
John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
Miroslav Lichvar <mlichvar@redhat.com>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched_clock: Add option to use absolute time against hardware clock reset
Date: Mon, 7 Sep 2026 18:57:41 +0800 [thread overview]
Message-ID: <ap6Ypbz4wkftPgBa@U-2FWC9VHC-2323.local> (raw)
In-Reply-To: <86h5k14d34.wl-maz@kernel.org>
On Mon, Sep 07, 2026 at 10:37:03AM +0100, Marc Zyngier wrote:
[...]
> > - pr_info("sched_clock: %u bits at %lu%cHz, resolution %lluns, wraps every %lluns\n",
> > - bits, r, r_unit, res, wrap);
> > + /* Calculate the time since last counter resetting to 0 */
> > + reset_ns = mul_u64_u64_div_u64(new_epoch, NSEC_PER_SEC, rate);
> > +
> > + pr_info("sched_clock: %u bits at %lu%cHz, resolution %lluns, wraps every %lluns, has run %lluns since counter reset\n",
> > + bits, r, r_unit, res, wrap, reset_ns);
> >
> > /* Enable IRQ time accounting if we have a fast enough sched_clock() */
> > if (irqtime > 0 || (irqtime == -1 && rate >= 1000000))
> >
>
> Which is what people have done locally since the beginning of times.
> And the only time this is actually useful is when bringing up new
> HW/FW that is broken.
>
> So why the need to put that in an upstream kernel, instead of being as
> part of your debug toolbox? I don't think the kernel shouldn't be the
> recipient of this sort of stuff.
I see your point now, thanks!
- Feng
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2026-09-07 10:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 8:21 Feng Tang
2026-09-02 15:32 ` Marc Zyngier
2026-09-03 6:51 ` Yao Yuan
2026-09-03 7:38 ` Marc Zyngier
2026-09-03 8:07 ` Feng Tang
2026-09-03 10:20 ` Yao Yuan
2026-09-03 7:45 ` Feng Tang
2026-09-05 20:39 ` Thomas Gleixner
2026-09-07 9:05 ` Feng Tang
2026-09-07 9:37 ` Marc Zyngier
2026-09-07 10:57 ` Feng Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap6Ypbz4wkftPgBa@U-2FWC9VHC-2323.local \
--to=feng.tang@linux.alibaba.com \
--cc=daniel.lezcano@kernel.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mlichvar@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=sboyd@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®