From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D61F328640B for ; Mon, 7 Sep 2026 11:20:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788780063; cv=none; b=nKHVaY5eouUhWHUh8Rs+nScFnsXS3LgpTowJf82fwO1YSTEfazS65Wcq7MmVqhTQJf1ayR1Wbc7/WqoK0QRdxjnvZdH9NwKUsP93LOSn+9WgL+EkLUAeAfkVEum0ezYiP16W+5l3ovN0nhEI2FWDjjtIXJ2ogARw494ejxhw0EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788780063; c=relaxed/simple; bh=3xYwyiFqI+oPMMxVQR36OSf5t9Nu6Dp63Jwgu+jol4c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rmqiHEheYEbbxNhDMjEt6Gn9wKxAn/EThfkG+SztmTQNF+a4CWcmUPemkyAKsFdVly2/qCP/IWgRdD5gSkck2de+yJJHPp+uu9qAdFtPNAcMQSIk9qAVTWeKsfj5vEsKC+VyOJ5msexcDBoDJpoqcpnPmDo4B0g0QPKonTsAD2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RI5BZCPD; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RI5BZCPD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788780057; x=1820316057; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3xYwyiFqI+oPMMxVQR36OSf5t9Nu6Dp63Jwgu+jol4c=; b=RI5BZCPDkPA0BLhP5BQRBykGgi6ksC7XaqjHz/rEi7g8e4Fq3g3tUuPv 0SfrtiYY5IFtWocVCCThR1Gq9qMNJ/q5MinrRcb1W6NqsAk4HelmKyuS7 V61tBTNzFs/92uJi8i/0VNN2Hd9syazR9a1c5s1QixqzTBXnQnQeIOC79 vo/O3q/tNT82fj9LVdHJDlG3Y3oqKyR49742yJvqR4pq/kE/rAEDoOL2O /c0gBcGb29OlBrKeh7xbYKS0bp7HFW3dfz5dkeWgslQ9PHjdM+xPModq7 DKpbH76BIXelf4EECymsfSh+b4ENIksPdl/481IqIbDNCkIcMW4PMVS6U A==; X-CSE-ConnectionGUID: MHFzHSNNTPWR4RowBs+sbw== X-CSE-MsgGUID: EdWmUpbCSzKEwPB3RPivIg== X-IronPort-AV: E=McAfee;i="6800,10657,11898"; a="89200836" X-IronPort-AV: E=Sophos;i="6.25,267,1779174000"; d="scan'208";a="89200836" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2026 04:20:53 -0700 X-CSE-ConnectionGUID: 0etPjfBVRy2LZBwfgJq9cg== X-CSE-MsgGUID: fMzm8kKRQwi0is0pY2vqPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,267,1779174000"; d="scan'208";a="274836654" Received: from bradocaj-mobl.ger.corp.intel.com (HELO localhost) ([10.245.246.57]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2026 04:20:50 -0700 Date: Mon, 7 Sep 2026 14:20:46 +0300 From: Tony Lindgren To: Xu Yilun Cc: dave.hansen@intel.com, dave.hansen@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, kas@kernel.org, nik.borisov@suse.com, rick.p.edgecombe@intel.com, yilun.xu@intel.com, linux-coco@lists.linux.dev Subject: Re: [PATCH v5] x86/virt/tdx: Formalize SEAMCALL leaf version encoding support Message-ID: References: <20260901105436.461823-1-yilun.xu@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260901105436.461823-1-yilun.xu@linux.intel.com> On Tue, Sep 01, 2026 at 06:54:36PM +0800, Xu Yilun wrote: > --- a/arch/x86/include/asm/shared/tdx.h > +++ b/arch/x86/include/asm/shared/tdx.h > @@ -122,9 +122,11 @@ > #include > > /* > - * Used in __tdcall*() to gather the input/output registers' values of the > - * TDCALL instruction when requesting services from the TDX module. This is a > - * software only structure and not part of the TDX module/VMM ABI > + * Used in __tdcall*() to gather the input/output parameters of the TDCALL > + * instruction when requesting services from the TDX module. "version" is > + * encoded in RAX along with the leaf number. Others are raw input/output > + * registers' values. This is a software only structure and not part of the TDX > + * module/VMM ABI. > */ For better readability and a few less lines of changes, you could just add a one-liner to the existing comments: Note that "version" gets encoded into RAX along with the leaf number. Anyways, I'm happy with the current version without changes. The patch cleans up the version encoding issue nicely, so: Reviewed-by: Tony Lindgren