From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF26B3812ED for ; Thu, 27 Aug 2026 11:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787830953; cv=none; b=cSqH0tXdyM9xdYQZiBvUPWp77bUObw9Q6akihzhnBYGmryTfI1ocgUrNT04xuQG7gEpiIYa2VzwJrPx6cT9jWznSKfn+lL2YdlY93/YCIOmfkOCDmXL7bTGHa+koyDpolcqeKjH+cPAIl0h7KKQKs7Ej2bFiamdCyYt0fTyVQWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787830953; c=relaxed/simple; bh=HfczaBEIeRcH5RSOIJyuVs9L3ILxl3LXvTn5FoFJ760=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oc4EtA/snUsggosVfcqDTtXnvoDfHfyWLebakPS1Cplq2ByWw/l/qS0msvMo1TxQM6tmZRCgOGjqk6EZ3O7jNi3P3GqgGIhb0bjdXKcH42Q9Nsby7VO0IS6Kxw6OrL09Cxko2mIPyhxo9VkIQznQUomc28wZ4B4ruivGYcWropY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T5skCl0S; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gXOKGSVu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T5skCl0S"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gXOKGSVu" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67R9HHk43090923 for ; Thu, 27 Aug 2026 11:42:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=1wwrKlt9+TZD++ZfuGZ3Nrsi +gQaVMa+KeHyXcEKbLo=; b=T5skCl0SWih5GmnQySXiFpi+EyO6eo8VFqon8BOF yTVKYWPcXAmWwRfvwXsQvSp/CYfUE9vTp50RgwTrLXTAFqWxnDSEhWWTyl/Z1Rrp 8RWKq3BAgWRpC9ccqQd1ogTHdpHgddkfbuKiQUelC2+zmnLW9qMMO09bbgKgJNpg CErPxvXpuEGm/59wua+ZxrxUD1FL1i3lwXXyVb5pqgvBq67oClTeYnokh/S8zuw4 T+C6rh941paqNs/uh7tmj/OaLrDEAZA+NzqLw2R7rB7hUSwPm2F+q1z5/S24w3/c QQFGlhbwmwM7iwLKI5yhE+tTgzRSCgqcS2UqsV3LtysU1g== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ga4fwkkts-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Aug 2026 11:42:29 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e11baa66eso3993146a91.2 for ; Thu, 27 Aug 2026 04:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787830949; x=1788435749; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1wwrKlt9+TZD++ZfuGZ3Nrsi+gQaVMa+KeHyXcEKbLo=; b=gXOKGSVuCqQ8IXnUGz7rKGOZBloC/V/OnxYXEW6XZwEKx+yniImhL00Hu0djYIKS21 TCV0sgqzmj4Jkh9FSPJw8LN110LenSC55WPMuFzaTyniaaf/Hd2fEVlLejK7UpLILcl+ 2pMD9bZ4AJkY6vrBQBiXOZ2zeThKeVkisLYry+kGmZ15WTI0OTnTs20fygY6UNpEgfCZ IGdre+lsCxgtlqPmK35ds1oTcf7RWXjpwqdp5V6ipp0uEdF+ne6j2mG963EZMmDYZ2iJ zvAl7xwWHDpxidK3tMlA4I0kIwmYEAd0l667S7VM6Bl06oXivw1SDHM0sRICCdFlACeb zo9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787830949; x=1788435749; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1wwrKlt9+TZD++ZfuGZ3Nrsi+gQaVMa+KeHyXcEKbLo=; b=FbNfG9ECW2VPwq/zAU6CFxr1gsf+Sc70HuNUEHuWUD4lRQyVWV7vaBI/06snx1DFr1 KMcGoHUdeEcN/yFNtE5K2egaCtCZIVF1EIPR3iEQkjkJLZ5z+83KlBLEPBoFEB7iLFrb QSaL9HH5zHlxBHBX0uqlKi3EDgoWxhrZ8kS/onEuL+7gwI6QgLgFuED09fLqudnwly+a cn4NHjiHkz+UhZCbLhuxVyaRsOJLLYfK0Izfg0y4cQ8Rwdpu17VMX3HvKlt2lX67j+wh q30tZdHsoXVoN5rAoCZZovKKP5/ZqpKGW4p62rfwKvRhDOmgddYtwnCRaI8xNUKGmQ34 hirg== X-Forwarded-Encrypted: i=1; AHgh+RrYqzvfXjyMGTOyPdEWkPnSrjYENOxLY2BaO1e+GGsWNNCm+Kho+pdqPYu8LiuDjHna0mQViC+E6CJy+vc=@vger.kernel.org X-Gm-Message-State: AFuF++mk79whiESh0DgFsBAbguxdBFYArINdcYKjSe8aw5Fs+xB1dITM ZP2VD441zrJpiTImtu3V1VagXIHSib4VIzdyBMwy/HZ1HzEiUhcyUjwG1C8slr1vkZtMpmSQRIZ HQX3tzoCm9zGhy2gxPlNIL7QqaazAu9osAkuVQGK3rbD4Xi1/NCervAi5E8W5C3AI3pY= X-Gm-Gg: AR+sD13OjlJJVgBy7LammIqFnNMRnCuDm7fEU0zfFx/2tJ4j3gNgKCIkYBdvLJDTATw W7wSdeRaOJ80N2Z8YxiCE9QDmHUv/iB90TEmcC5aMiTvgLurldVQ2dlVAJx8L9WkqdPSmonQxag cyaagkvFOsbyIM5WxD0kMfWfTBMUaIcftt4+XPyjTWvz4ciz3KQE6DbRGjj8slEKD6A5cEPEpXD NQtkO5bWpc5EBfCGTEZO7QOhiokB8BEeWAbzz3HEsQ5rwbAjDAeKIQjA1uvuF8ruJv/HabYCPDF pauMkibrEKzQtUZIlTS61NN4xEw0B/K6JGczt7g4IZ8dN0/dO/IfhO1gcHyvr803NWLjBvdly46 mChOhwckW2pjn9gA/0hllhizHWwMhASjXyMgYwudyhynYJQOlwRAv1k3+zF7N3MyvzqIb6ubpsp 8QTTLpTbbujaAKkPXdVaPGIBfu33l3Nw== X-Received: by 2002:a17:90a:e70e:b0:38e:524:8797 with SMTP id 98e67ed59e1d1-3966d4503ccmr30898820a91.13.1787830948906; Thu, 27 Aug 2026 04:42:28 -0700 (PDT) X-Received: by 2002:a17:90a:e70e:b0:38e:524:8797 with SMTP id 98e67ed59e1d1-3966d4503ccmr30898684a91.13.1787830948341; Thu, 27 Aug 2026 04:42:28 -0700 (PDT) Received: from hu-varada-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141a8eefd98sm30723893c88.3.2026.08.27.04.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 04:42:27 -0700 (PDT) Date: Thu, 27 Aug 2026 17:12:20 +0530 From: Varadarajan Narayanan To: george.moussalem@outlook.com Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Thinh Nguyen , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/9] usb: dwc3: qcom: Add support for selecting UTMI as reference clock Message-ID: References: <20260825-ipq-flatten-usb-v1-0-5c1f3170bbe9@outlook.com> <20260825-ipq-flatten-usb-v1-3-5c1f3170bbe9@outlook.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260825-ipq-flatten-usb-v1-3-5c1f3170bbe9@outlook.com> X-Proofpoint-GUID: 6URyM1rxFmZxrTBtb0oP64IOkuiP9QRt X-Authority-Analysis: v=2.4 cv=OtZ/DS/t c=1 sm=1 tr=0 ts=6a9022a5 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=L3BjEaeBWuRv9D3tqyQA:9 a=CjuIK1q_8ugA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: 6URyM1rxFmZxrTBtb0oP64IOkuiP9QRt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDA5NyBTYWx0ZWRfX3GsPB0lQ8OFb IVPFekEyt+xTZMjXcDec8ib9ETY0KbEqAZDOS7JtwjcmI1Q72HOabOQiNweftMQMbhifQcFggWl 3HE1hq0NCWbQoa4OcktiC9cDlBtcJeZI3OH8qDY9k9T2eIUakz2eeWv3WqWFnFWELqAMAsAdk5z 9wQb4SZdz/JoF0gJ2u+ZxkgMaBb38EOUPs5/j9zO9qxj1ELYphp3pufsDh80yDRaHGQ9BVvWTCP 2Xg3m4Tklz4/7TQMtmjOGwxWMsBuhTS4goO3sYa94urtpc+QDducPy4G/mr6rCzyk/13s2Wxa/s sPRSSAsWGpTEwrualdIeKIemcbuyAbyHjPpcTA7Gpyp929Qn97OTYuwYUqUma3BepuAg24DsEI5 ZvLcvvyU1OK9NXpa2dbDEW6DmRNc0iFkPa7Qvj/3I1Osz6DnlbKMd579kiHfQTCZrfI6yQejhQl mbmZg8mxrwvG3QZe91g== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDA5NyBTYWx0ZWRfX4/XPumUitSa2 c8Tw3b5OtaPNfOCnZLgKTS/gmIZGv/okZtlHDKp7srhpXnfgxkPbTyehk55Zzk8VtmVWPQN/vE2 kbmCamct47Y8QYJyFZuCYUNvag/77iY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_04,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270097 [...] > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index ac68b4218b56..17292517c594 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -617,6 +617,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > int ret; > bool ignore_pipe_clk; > bool wakeup_source; > + bool select_utmi_as_ref_clk; > + struct clk *ref_clk; Any reason why glue layer can't send the ref_clk_rate directly? -Varada > qcom = devm_kzalloc(&pdev->dev, sizeof(*qcom), GFP_KERNEL); > if (!qcom) > @@ -698,6 +700,18 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > qcom->current_role = USB_ROLE_DEVICE; > } > > + select_utmi_as_ref_clk = device_property_read_bool(dev, > + "qcom,select-utmi-as-ref-clk"); > + if (select_utmi_as_ref_clk) { > + ref_clk = devm_clk_get_optional(dev, "mock_utmi"); > + if (IS_ERR(ref_clk)) { > + ret = PTR_ERR(ref_clk); > + dev_warn(dev, "failed to get ref clock: %d\n", ret); > + } else { > + probe_data.ref_clk = ref_clk; > + } > + } > + > qcom->dwc.glue_ops = &dwc3_qcom_glue_ops; > > qcom->dwc.dev = dev; > > -- > 2.53.0 > >