From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB7333DA7F1 for ; Thu, 27 Aug 2026 14:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787840940; cv=none; b=MnFVkvqlpNWlb1ySGRCRt/12niFs5M5/MzopvGM7uR5yfbA52mlt1CwAr8Euxl69flmShCV4s/DSJkbHnGn/3/UCcU2fqz8NDB+j0K51BfAe59LseiuWocXODkIjHk0AEbHYZJ7yz11OjxvzBfnkQoV36Z8Ejapo0MEoNRDdDNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787840940; c=relaxed/simple; bh=nKAx+rvAzxQ2/kf2GcBVYLAy8Xi8kdNaL+EwFmlkcWU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZgxPLR6WSLFq3n3g5XwDPoYffFiJ36N2Fd6mTYXnsLD6ELcXtRj49n/yPU+eEapsSK/LF2FUvStGjfybwgMMShhfw7/wnHG5GNlo+rv4h2/iSAGTT2X2pHIO9HE46MVn/u6Fcp3CUKXT/Zd6ULe0Klkbg1p/3HjLQVcsvxoDcXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gTYm8g/9; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gTYm8g/9" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49b8e527d63so5829825e9.2 for ; Thu, 27 Aug 2026 07:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787840937; x=1788445737; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=PI7Nz8d3HH69nhtcQsyOVYUPwrNGYdNUTrVZkR05tbE=; b=gTYm8g/9KbfqyhipbgSGeThEFgXOcXxabdTWb5EEzOyxnxM2hflSJOx4ResaUX8kz1 4cr6raNb4sWtBDJ0XXGta9HHjOI80JJEc2evQQDeYTTzhHhduH8/Qjxth86M7KifOLeq xhKk6iHQBqb4ld2cH4KAMc9zDDwQL9sqXD2/zLlucOqp03reBjW5F19Y5bE94lO9soJe PlhaXia87Mm34L9DGhRSftRPmAivW36q371pLAhAJJ72ApY85FzVUSXup6rCGXJvB6Gw qvCRk852/11G5ToUy0fDscvA527YEdvHPQuozbr85VBlr0RoIa7qhPPuTxa4tKBAJveW AI9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787840937; x=1788445737; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=PI7Nz8d3HH69nhtcQsyOVYUPwrNGYdNUTrVZkR05tbE=; b=XcJ+0LYHrngsh9xzUicQPl5xqW1UYtKKJA4xRoFAFIQxtSNwun2G1ZZoxQGUP5zo8U ASjL6gv1UroieDMOF4DGv0ErMZdp+ESsNGfomt/f90djmUR/zGOZombv4iqXL4kCTfwF zSVyqk/Um0VmnCtUSh9t9uXsBU8eAscdm66a4FdI3HAvcHtHlnAxjZ2xongoShUgyIju vsaFkNgSp1xIuABKqv5ACUtlanQPq+MKWk251s3+UcSHKSpIYiF1mSsspKYg++H6RTyP PEN6ptB2R55wtJnyk3omr8EsbBioF9+MgFo4TBvCShLMuTDAjFtI54hjnhW9tgp0PGgk dBTA== X-Forwarded-Encrypted: i=1; AHgh+RrCVlFcbQhLtk6I5x/kVMVvxSYEhhQHEiqnTdyxy2r/+Y7Rf1ktgJXOneSOhO21yM1qJoZSJ6uo3lVg44Q=@vger.kernel.org X-Gm-Message-State: AFuF++kt0098luKzicojA5nKOG+q2TYCgAItCPcOEi8Th9E3Pb1TtFw2 0aEn0KNtMCFgxWFW7RIB7Tp3xDXFjsgU3cUBdtKXnrVZ5FlDEIV8C4ebZwTZMG2UMSs= X-Gm-Gg: AR+sD126Z1M193yV3vHqDcX1YztvODi89xmloogS0qxNGSDh8ygsO3n5IdV3BU9csUM Ux+JZzXebOHwGLdhUzKTyiWCyLp22mQQb+koUY90R9jzSXisJVLVHocwM90mCmaEMDZNbffypnK hCgTJtSO1tkzufKJpymsIOxUikvUTk1IdhaTQT2Jck+xnwxCJToplNQ/3I8Rg8uvwSf2+MWHf/6 v2s9/OIbhGSI5tom97ljJx+GTtFikqY6rsSj02/d/pQ/QJtvUhmdqnimfZpNRJ4ND0IqKnZ/0jh g22mcyb1BrYP5m1TNOwLFhxijg1Qt3ZcwbHn/soQZvJmz3PP1DmlbEr1WgNnGwEHOVq4EbZbRSK WN7dZIz6rGJKOWAFFBmD1mUtLlOvTsFa4aZ1LD8Wxn/ekk+84bGo9AhPDlInvuX9wUnQxRYjElD 88/KIekglvAZKhBkVscpQdIT8sFira8erbRyjigKCC6eP6mcrmKho= X-Received: by 2002:a05:600c:698c:b0:493:cefc:d113 with SMTP id 5b1f17b1804b1-499dc6f5dcdmr215984745e9.5.1787840936850; Thu, 27 Aug 2026 07:28:56 -0700 (PDT) Received: from blackbook2 ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b494228bfsm54431465e9.2.2026.08.27.07.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 07:28:23 -0700 (PDT) Date: Thu, 27 Aug 2026 16:28:02 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Wilson Felipe Pereira Cc: Andrew Morton , Johannes Weiner , Yosry Ahmed , Nhat Pham , Chengming Zhou , Tejun Heo , Shuah Khan , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] selftests/cgroup: test_zswap: fix implicit unsigned promotion bug in test_no_kmem_bypass Message-ID: References: <20260827034807.2822234-1-wfelipe@google.com> <20260827034807.2822234-3-wfelipe@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260827034807.2822234-3-wfelipe@google.com> On Thu, Aug 27, 2026 at 03:47:42AM +0000, Wilson Felipe Pereira wrote: > In test_no_kmem_bypass(), delta (stored_pages * page_size - zswapped) is > checked against stored_pages * page_size / 4 to verify that the pages > pushed to zswap belong to the test memory cgroup. > > Due to slight stat update timing differences, delta can evaluate to a small > negative number (e.g. -5MB out of 1GB). Because delta is declared as a > signed int and stored_pages is an unsigned size_t, C's usual arithmetic > conversions implicitly promote a negative delta to a large unsigned 64-bit > integer, causing `delta < stored_pages * page_size / 4` to falsely evaluate > to 0 and fail the test. > > Fix this by declaring zswapped and delta as signed longs and comparing > against a signed threshold, ensuring negative deltas correctly evaluate > to true. > > Fixes: a549f9f31561a ("selftests: cgroup: add test_zswap with no kmem bypass test") > Signed-off-by: Wilson Felipe Pereira > --- > tools/testing/selftests/cgroup/test_zswap.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Thanks! Acked-by: Michal Koutný