From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 528C131E832 for ; Thu, 27 Aug 2026 21:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787865113; cv=none; b=aW3wm1JQ9VtgpXRT/drmFfCU99wsaBgI3r2zSXeHddxUME8TCWJafq/PQG5YURd2hTyLuvLEzNz7y1rsOO32PuOPqITnCKNlCIHoYsuZyM75kNUT8yGZRthPyhLeYLG5LywHvbXIcxcviHDPGgOtcyQqhGdbtOTkq2wiNOm5yVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787865113; c=relaxed/simple; bh=5DiTONfLGfzVRBMIwWQ+35enC6CcVIcxY6kW47nLHjM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CyZ6d4FCLIe2pCbwI7DC5PdruqFzj97NDWoEc+NotnA8hur9uTZnTcxKOwgUHY/bJIcoB0CRl/T11mBdJukNBlQhfPFsyEU7ONr98ZjaN1hNdhJE9JYud1JtQD9A59aMz7EwGA0lTR9chyxKVhMP/gZw5Q23lBkGbtPG0v7nVII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QsxacJvx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XXU7XOHI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QsxacJvx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XXU7XOHI" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67RJLoPG547154 for ; Thu, 27 Aug 2026 21:11:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=b4qSUBRWwKynQruKg+4d/vg2 0odJ4RqXuTZyRs4vdw8=; b=QsxacJvx+dPTgQNyyBE5KeO2KP+t/kNcNazm9/+y vwwEH4yaSuEdezsV9Y6Z4W6Fgh4980zebKRwQUdZqqr0HWOX0prWhOo7B3C5gJIC VVJ++4cJNAH4Xqngu6VcwsN8O/SXETnsVGds3f378AhHvfHlTuL0HOe4Yahy5ars QQ7P3jGeFtinxAHYVVCwIMzK8lH5j6WVbNYiHP4//G0+WFGoNndhDysEBhMp33ow gzT4DcxOB1e6ObT0QRcfkNeWyYZdI7tGJ8tQ1b+n6vZBM0LefFKl+JGq3sjg/rtc GBc67qjWe9bwO20/eeU9DXmEoVyPqZq8S58KPGTMWJl67g== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gak562kgu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Aug 2026 21:11:50 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2d6f75c1219so5726215ad.3 for ; Thu, 27 Aug 2026 14:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787865110; x=1788469910; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=b4qSUBRWwKynQruKg+4d/vg20odJ4RqXuTZyRs4vdw8=; b=XXU7XOHIVcqS7VH+GMf9iX4dt//5uGkjtIcRfIr+zQen6LM/Ae2GMJFyiFCD+r39hG jY49mFrDtBTcg4IqEi0co5F2G/Loe6ZZrgaL+/M+KCy1CVznZF98HQ+80V01UpTD2ID8 rLklnkICSmbH6Nf/25YOt9iz6NDDxzcSTpTsAGBl+SfhREDNvJ0OGfUgfVi0pFsJBypM 9LYcLOkFs2ezyGk4ma6yQARQuKhaSY+2Q6Jlsms50Co6C3F4351GLB3yRlWQGUWLwSZJ RYjrqmlUhxrloN5YCYLW7zX776wYEMU/Wgf4J+zmrk10FEQoiNimkeXLo3uhBH7jmDbl qRpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787865110; x=1788469910; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=b4qSUBRWwKynQruKg+4d/vg20odJ4RqXuTZyRs4vdw8=; b=JjgD4zNnNPdEeWDTn5cQbzcz1iVaLtCF++PyzyoEhFNzGqAaWw6U1tIi0FiHV3gQV0 1W3e29F3xE1ufypV1+6jUxODfVXsp2+Bap/J19h5tB+I9DkLiD1WMWCSWWJJBQhXeC1I Sho2aiyqMRZ8/5flqAZZ7pJJJ/dNmJ1bDLYxJeUSoUj/4LcdGfou7uKEcp2xhc3WEwK4 FuyS2tUMK4KFgcjZpKhOh+sydbawSPnXCThk8BYsIWvQhQbCn8GeZneiab5ANWVFRd98 k1jHh0OGoA3jB3CeCO/x4GJRIP82qzpyPrLAOrb+vPdKJMe+LQtQ+bxjyuz7ITQa/lFb UQSQ== X-Forwarded-Encrypted: i=1; AHgh+RoCPg212b0Nx87kEN1BS1oC9NapuUbzQAY6ihJNX/wk5ZHRdq1/9lx2/xG5RTV1a33QJ0HPsXPlYw6PIo0=@vger.kernel.org X-Gm-Message-State: AFuF++l5cc0vdzA7eCWvbF2fQh8CE9GF72aEq734TYpgGMx3HytC40p0 8tk0KbKmigNL1qqR9M2mjIPDxIp1d0VOkyeTGUAixAv5D6tqIu9gC2rC92+vEEsIoaXKLprZGot XHHXXz0ILRKNbVqxwBItofD6g8ldUIcdrLww9Jfiszdha2S7/3xvrmMcUbIpgbO7imgQ= X-Gm-Gg: AR+sD12xyLwPB5s2gu/wgbQjBWGo2uCTrTcxFSD2gLMRcXriM3eUotYyYiRgWDVY/I3 BCnnSfvNt10b5IECVMnkQdfV4cZQ88GmjxiwSSvjTFxkjgFvnNYVh4Q4GnLTh1sS+jQ2eEHzF2A tUHGYOFJW9QyN+AL3doNQ+EMdqrKNU4guepMJmL3xi+8zqZjk5B9tfH/L1tDr5rg3LTF9I/IJsC iHsjKRCSqmc07bG2nXHc90hKdphEZT+7DQOGMghrWBvM1eVxM13R57TDONZMdA6RcBw9itNCl3+ VWmBGH0IzhvS8YfXIfBcSeSrMLXDR0mfbVUFSqj2yC0Psfls/Nx/aWjdNhk0I6bDFzCVAm4WD2b PqkItfzYgTLh4/35me80x5M17J6NsVQ6amSnyTg== X-Received: by 2002:a17:903:b06:b0:2bf:dd0:c8b1 with SMTP id d9443c01a7336-2d74ce16d3bmr35880735ad.0.1787865109884; Thu, 27 Aug 2026 14:11:49 -0700 (PDT) X-Received: by 2002:a17:903:b06:b0:2bf:dd0:c8b1 with SMTP id d9443c01a7336-2d74ce16d3bmr35879605ad.0.1787865109415; Thu, 27 Aug 2026 14:11:49 -0700 (PDT) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3285f3cd3b0sm7758654eec.12.2026.08.27.14.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 14:11:48 -0700 (PDT) Date: Fri, 28 Aug 2026 02:41:41 +0530 From: Abhinaba Rakshit To: Kuldeep Singh Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Adrian Hunter , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neeraj Soni , Harshal Dev , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v12 1/6] soc: qcom: ice: Add OPP-based clock scaling support for ICE Message-ID: References: <20260824-enable-ice-clock-scaling-v12-0-09271f583dc6@oss.qualcomm.com> <20260824-enable-ice-clock-scaling-v12-1-09271f583dc6@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDE3OSBTYWx0ZWRfX+RwjsAQoP4G+ DCLXZMBSUagW0sq6aBReYlrpR3NbSWj8r3udD7wfJIkRDTHeuNgwMO2bGT9aV65VWMAZx+eKcri j8bTdkgRZbDEWyusN9Gei3IXYr17v1w= X-Proofpoint-ORIG-GUID: Z13LCz-CHWNPj4FPC_LSmeZ_8A2Q2McB X-Proofpoint-GUID: Z13LCz-CHWNPj4FPC_LSmeZ_8A2Q2McB X-Authority-Analysis: v=2.4 cv=G+Ms1dk5 c=1 sm=1 tr=0 ts=6a90a816 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=AC2Mn6xCbOXL0dGbV_AA:9 a=CjuIK1q_8ugA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDE3OSBTYWx0ZWRfX8HbAXtwRCUbE kgwMYkEjjPOiGQlesdpXemBMHCtzoZEZQL6Kp4E1wq+iV42ol9O3MUHwXhJkD4S6SLkEUuJqz0U c+4ptKNaLS1d8UNujmidEtYjSW8SN0FpkHsV3X8dNNa6TF//H0D5GnbdHZ9koaZviLiuiOQkW/F 6ZUYysuDkTofLuNuqRquGSPKFyL4tyTdAXLoCYMbpWj2Mbd7G1emKQ3N19T6JxVfelA3VlD7oMV 3z72JZB8ZLOSRodeOFDE81SDxtOOXgMpCCy/Bmo2Ya01Bp1ffNvCvi83rJN/wSgPuNhQqgXDZt1 saPn3NcNMbT1e3CT7vKAiH7Yd9LbO9y2ArMh3c6FKhreSSsOh12L6rQzLwN6/0H4tJULmDtoKiJ igo35FAA1+iDOsXPlZQAVWs17jN/8shyyjmtrLW/puyid5veEEm6FD8dTkLlH8dUiCSjXWq/QB+ lRPtizvrHMgWv3KTsNg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_08,2026-08-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 clxscore=1015 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270179 On Thu, Aug 27, 2026 at 12:17:02PM +0530, Kuldeep Singh wrote: > On 24-08-2026 01:17, Abhinaba Rakshit wrote: > > Register optional operation-points-v2 table for ICE device > > during device probe. Attach the OPP-table with only the ICE > > core clock. Since, dtbinding is on a transition phase to include > > iface clock and clock-names, attaching the opp-table to core clock > > remains optional such that it does not cause probe failures. > > iface clock and corresponding dtbindings are merged for v7.3 and your > change will land post that. > We can drop this from commit message? > > I think we should scale only core clock and for iface clock should rely > on ufs/eMMC controller maitained frequency. > The idea here is to scale only the core clock and I am achieving it by using dev_pm_opp_set_clkname() API. However, for that clock-names needs to be as required property under DT bindings for qcom ICE. As the comment mentioned here: https://lore.kernel.org/all/b32c7091-b2c4-443d-b58e-759b471f67db@oss.qualcomm.com/, the current dtbindings supports backward compatibility with iface being optional, hence it is expected that driver should be backward compatible as well. Once, we plan to break this backward compatibility and make iface clock and clock-names property as required, we can say its out of transitional phase. Abhinaba Rakshit