Re: [PATCH v2] i2c: core: fix debugfs UAF on adapter removal

[Andi Shyti <andi.shyti@kernel.org>]

Hi Vasileios,

On Wed, Aug 12, 2026 at 11:14:48AM +0200, Vasileios Almpanis wrote:
> i2c_del_adapter() frees the adapter's debugfs directory before it
> unregisters the adapter device, but the new_device sysfs attribute
> stays writable until device_del(). A write racing with removal still
> reaches i2c_device_probe(), which passes the freed adap->debugfs to
> debugfs_create_dir() as the new client's parent:
> 
>   BUG: KASAN: slab-use-after-free in lookup_noperm_common+0x407/0x430
>   Read of size 4 at addr ffff88803ef87810 by task syz.0.61/6090
>    lookup_noperm_common+0x407/0x430
>    simple_start_creating+0x9c/0x110
>    debugfs_start_creating+0xdb/0x1a0
>    debugfs_create_dir+0x24/0x350
>    i2c_device_probe+0x814/0xbf0
> 
> Its technically possible to create a client after i2c_deregister_clients
> has run. That client will never be unregistered and making
> wait_for_completion hang.
> 
> Close the window by removing the new_device attribute at the start of
> i2c_del_adapter(). device_remove_file() will drain any clients left.
> 
> Fixes: 73febd775bdb ("i2c: create debugfs entry per adapter")
> Reported-by: syzbot+23ad911c819b923238b7@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=23ad911c819b923238b7
> Tested-by: syzbot+23ad911c819b923238b7@syzkaller.appspotmail.com
> Signed-off-by: Vasileios Almpanis <vasilisalmpanis@gmail.com>

with a few fixes in the commit messages, I pushed your patch to
i2c/i2c-fixes.

Thanks,
Andi