From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Chang Yu <marcus.yu.56@gmail.com>
Cc: "Andy Shevchenko" <andy@kernel.org>,
"Anshul Dalal" <anshulusr@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: light: ltr390: Remove stale TODOs
Date: Fri, 28 Aug 2026 10:47:11 +0300 [thread overview]
Message-ID: <apE8_yrAGt__Nl9N@ashevche-desk.local> (raw)
In-Reply-To: <apE0dwvpW6Yl8yzz@gmail.com>
On Fri, Aug 28, 2026 at 12:10:47AM -0700, Chang Yu wrote:
> Remove stale TODOs from ltr390.c. All features have already been
> implemented by Abhash Jha<abhashkumarjha123@gmail.com>'s patches:
>
> Configurable gain and resoluion: commit 13fad2607dad ("iio: light:
Misspelled 'resolution'.
> ltr390: Add configurable gain and resolution")
Here is trailing white space. Also you can do it in a way
[1] Configurable gain and resolution
[2] Suspend/resume support
[3] Support for reading the ALS
[4] Interrupt support
Link: https://git.kernel.org/torvalds/c/13fad2607dad [1]
Link: https://git.kernel.org/torvalds/c/288ce72fb5fc [2]
Link: https://git.kernel.org/torvalds/c/14e0d914a855 [3]
Link: https://git.kernel.org/torvalds/c/7ca4b8957066 [4]
> Suspend/resume support: commit 288ce72fb5fc ("iio: light: ltr390:
> Suspend and Resume support")
>
> Support for reading the ALS: commit 14e0d914a855 ("iio: light: ltr390:
> Add ALS channel and support for gain and resolution")
>
> Interrupt support: commit 7ca4b8957066 ("iio: light: ltr390: Interrupts
> and threshold event support")
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-28 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 7:10 Chang Yu
2026-08-28 7:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apE8_yrAGt__Nl9N@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=anshulusr@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.yu.56@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®