From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sg-2-4.ptr.blmpb.com (sg-2-4.ptr.blmpb.com [71.18.227.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E5403C10BD for ; Fri, 28 Aug 2026 10:16:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=71.18.227.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787912196; cv=none; b=Y3zl77bYyxD3K4gk9dPW25yHiDQW/QRMKXQyy0kB6qXxQQySLQHo+QClEENGujRiNLKbJSrmPlQMgbr/KowJIIHu8kH2aah2MdA5stfPLQNT9oevSAx5euVDj8qs797+xIQnca/cy2RIbvmLQ4GpfVXtn6ROIug9Ve7yVlgxmnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787912196; c=relaxed/simple; bh=mL5wXhAUA17zffxtD/O8nf+NAAh7PCUWFmHkdCtDct0=; h=To:Date:Message-Id:Content-Disposition:References:Cc:From:Subject: Mime-Version:Content-Type:In-Reply-To; b=lRiYTQDKkKj6IAUDtWpM/eQWhxKQJs/NJ3DimYdWpf7Mb/wJf3oi65U8tG2Q3W5w8CI2eVbCsoliwD+9teEbOqhdV9AG4E/Ma1stv5l0FTj2SyEz0C0MYAkdE2fGvH6AbXb01dluzEVFV/U2evFCMuX3rKCLkMNUp0j6AMJCrGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cherr.cc; spf=pass smtp.mailfrom=cherr.cc; dkim=pass (2048-bit key) header.d=cherr.cc header.i=@cherr.cc header.b=sIOSlB7w; arc=none smtp.client-ip=71.18.227.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cherr.cc Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cherr.cc Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cherr.cc header.i=@cherr.cc header.b="sIOSlB7w" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2604220257; d=cherr.cc; t=1787912188; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=NTtymu3QcPJIr6UXvu2by4+Uusv1ReFlqWLnM3no9vA=; b=sIOSlB7wXVavq5vFrcAy+N4undITotsFoaH6tF50slmOUkM1PK1JneJOMhp7e5fh0ToZZ8 Ciyvm7JT3jYRHYvRJKcnTahEickR8A+LVssuffE2cxYRwI0nQVMPMgz+JaQS05ZpXMfLdZ wJw9n68hHxiJtJVzRBxjxXGZ+ySUzAMB05iZOaNO3X/QWm1sdu6baivP9rxfSyP7VdwROr qIP3/PGxK15O2dbBl3g5hY6ckDINu/oUyzh+o/FOtQC+r1pg8LjKFoFXHn8TH0IbbahfqF XJWtgSsnCWETjy1++vvJblqVygZDx8Lmxvo54NzwCbMTnOIpm6zk16oMJP8IQg== To: "Breno Leitao" X-Original-From: Shengzhuo Wei X-Lms-Return-Path: Date: Fri, 28 Aug 2026 18:16:22 +0800 Message-Id: Received: from pve ([111.42.148.146]) by smtp.feishu.cn with ESMTPS; Fri, 28 Aug 2026 18:16:25 +0800 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20260828-atl1-cancel-reset-work-v1-1-9a2140dab074@cherr.cc> Cc: "Shengzhuo Wei" , "Chris Snook" , "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Tony Zelenoff" , , , From: "Shengzhuo Wei" Subject: Re: [PATCH] atlx: atl1: cancel reset and link works on remove Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: On 2026-08-28 02:49, Breno Leitao wrote: > Is 03662e41c7cf the right commit to blame? > > Both works, and the unregister_netdev()/free_netdev() sequence with no > cancel, came in with the initial driver in f3cc28c79760 ("Add Attansic > L1 ethernet driver."), no? You are right, thanks. 03662e41c7cf only renamed tx_timeout_task to reset_dev_task; the link_chg_task, and the remove path with no cancellation of either work, are already in the initial import. v2 points Fixes at f3cc28c79760. -- Shengzhuo Wei