From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Song Liu <song@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>, Harry Hsu <x90613@gmail.com>,
mbenes@suse.cz, joe.lawrence@redhat.com, jikos@kernel.org,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] livepatch: Move code for updating livepatch object relocations
Date: Fri, 28 Aug 2026 10:41:09 -0700 [thread overview]
Message-ID: <apHH5-VsffdBQtuX@jpoimboe> (raw)
In-Reply-To: <CAPhsuW72hqxThCfDWY=gXffwcGvGL62pwhwMgE-39AGEv7DvCw@mail.gmail.com>
On Fri, Aug 28, 2026 at 10:02:09AM -0700, Song Liu wrote:
> On Fri, Aug 28, 2026 at 5:53 AM Petr Mladek <pmladek@suse.com> wrote:
> >
> > klp_free_object_loaded() is supposed to clear changes made by
> > klp_init_object_loaded(). It should call klp_clear_object_relocs()
> > which is currently defined later.
> >
> > Move the code for updating object relocations up.
> >
> > This is just a preparation step. No functional changes.
> >
> > Signed-off-by: Petr Mladek <pmladek@suse.com>
>
> Do we really need to move them? I think adding a function
> declaration is cleaner for git log/blame, etc.
Personally I prefer a cleaner end result (put the function where it more
naturally belongs), though I wouldn't object to combining them into a
single patch.
--
Josh
next prev parent reply other threads:[~2026-08-28 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 6:07 [PATCH v2] livepatch: Reject livepatches with aliased old_func Harry Hsu
2026-08-23 6:23 ` sashiko-bot
2026-08-27 15:45 ` Petr Mladek
2026-08-28 12:52 ` [PATCH 0/2] livepatch: Clear relocations when klp_init_object_loaded() fails Petr Mladek
2026-08-28 12:52 ` [PATCH 1/2] livepatch: Move code for updating livepatch object relocations Petr Mladek
2026-08-28 17:02 ` Song Liu
2026-08-28 17:41 ` Josh Poimboeuf [this message]
2026-08-28 17:52 ` Song Liu
2026-08-28 12:52 ` [PATCH 2/2] livepatch: Clean up klp_init_object_loaded() when fails Petr Mladek
2026-08-28 17:44 ` Song Liu
2026-08-27 14:42 ` [PATCH v2] livepatch: Reject livepatches with aliased old_func Petr Mladek
2026-08-27 22:57 ` Josh Poimboeuf
2026-08-28 9:25 ` Miroslav Benes
2026-08-28 16:17 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apHH5-VsffdBQtuX@jpoimboe \
--to=jpoimboe@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=song@kernel.org \
--cc=x90613@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®