From: Shakeel Butt <shakeel.butt@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Kairui Song <kasong@tencent.com>, Qi Zheng <qi.zheng@linux.dev>,
Barry Song <baohua@kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Meta kernel team <kernel-team@meta.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-7.4 0/9] memcg: remove the v1 soft limit
Date: Fri, 28 Aug 2026 20:13:31 -0700 [thread overview]
Message-ID: <apJOJ2PWwmo7KMYW@linux.dev> (raw)
In-Reply-To: <20260828194322.0556dcbd1c261c23a1f6efec@linux-foundation.org>
On Fri, Aug 28, 2026 at 07:43:22PM -0700, Andrew Morton wrote:
> On Fri, 28 Aug 2026 19:23:19 -0700 Shakeel Butt <shakeel.butt@linux.dev> wrote:
>
> > On Tue, Aug 11, 2026 at 01:31:54PM -0700, Shakeel Butt wrote:
> > > Syzbot reported [1] a set_mm_walk() warning from kswapd. Soft limit
> > > reclaim is the only thing that runs shrink_lruvec() from kswapd with a
> > > target memcg set, and thus the only way kswapd can reach
> > > lru_gen_shrink_lruvec() and in turn set_mm_walk(). The offender,
> > > mem_cgroup_shrink_node(), has long carried a "Only used by soft limit
> > > reclaim. Do not reuse for anything else." comment and a priority hack,
> > > and it simply never got taught about MGLRU.
> > >
> > > Rather than teach it, let's delete it. The v1 soft limit was deprecated
> > > in v6.12 by commit 569c4f62d84a ("memcg: initiate deprecation of v1
> > > soft limit"). Nobody has reported depending on it in the ~21 months
> > > since, and v2 has covered the same ground for a long time with
> > > memory.low and memory.min.
> > >
> > > Link: https://lore.kernel.org/all/6a7a6929.b50370da.49fe0.005e.GAE@google.com/ [1]
> >
> > Andrew, should I resend this series (without the first patch) or will you pick
> > it up?
>
> I added the series, thanks.
>
> The [1/9] has already been queued in mm-hotfixes as a backportable
> hotfix. So I added it as an 8-patch series. Because of this the cover
> letter of that series is now irrelevant, so could you please prepare a
> brief replacement for me to paste in?
>
> Sashiko suggests that there's more that can be removed:
> https://sashiko.dev/#/patchset/20260811203203.3456029-1-shakeel.butt@linux.dev
>
> So maybe an 8-patch v2 series is appropriate, your call.
I will send 8-patch v2 series with Sashiko's comments resolved by next week.
prev parent reply other threads:[~2026-08-29 3:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 20:31 Shakeel Butt
2026-08-11 20:31 ` [PATCH 1/9] memcg: make the v1 soft limit knob inert Shakeel Butt
2026-08-12 22:50 ` Andrew Morton
2026-08-12 23:40 ` Shakeel Butt
2026-08-13 8:22 ` Michal Hocko
2026-08-15 0:50 ` Shakeel Butt
2026-08-11 20:31 ` [PATCH 2/9] memcg: remove v1 soft limit reclaim Shakeel Butt
2026-08-13 8:24 ` Michal Hocko
2026-08-11 20:31 ` [PATCH 3/9] memcg: remove mem_cgroup_shrink_node() Shakeel Butt
2026-08-13 8:24 ` Michal Hocko
2026-08-11 20:31 ` [PATCH 4/9] memcg: remove the soft limit reclaim tracepoints Shakeel Butt
2026-08-13 8:25 ` Michal Hocko
2026-08-11 20:31 ` [PATCH 5/9] memcg: remove the soft limit rbtree Shakeel Butt
2026-08-13 8:25 ` Michal Hocko
2026-08-11 20:32 ` [PATCH 6/9] memcg: remove lru_gen_soft_reclaim() Shakeel Butt
2026-08-13 8:26 ` Michal Hocko
2026-08-19 15:17 ` T.J. Mercier
2026-08-11 20:32 ` [PATCH 7/9] memcg: remove the per-node soft limit tree fields Shakeel Butt
2026-08-13 8:27 ` Michal Hocko
2026-08-11 20:32 ` [PATCH 8/9] memcg: remove mem_cgroup->soft_limit Shakeel Butt
2026-08-13 8:27 ` Michal Hocko
2026-08-11 20:32 ` [PATCH 9/9] memcg: simplify v1 event ratelimiting Shakeel Butt
2026-08-13 8:28 ` Michal Hocko
2026-08-13 9:27 ` [PATCH for-7.4 0/9] memcg: remove the v1 soft limit Lorenzo Stoakes (ARM)
2026-08-15 0:48 ` Shakeel Butt
2026-08-29 2:23 ` Shakeel Butt
2026-08-29 2:43 ` Andrew Morton
2026-08-29 3:13 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apJOJ2PWwmo7KMYW@linux.dev \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=qi.zheng@linux.dev \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®