From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.muc.de (mail.muc.de [193.149.48.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 699DE2DC783 for ; Sat, 29 Aug 2026 11:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.149.48.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788004294; cv=none; b=LAmNeHOAuIjj+78fHnamBH2rQm2cp21Gkxd+VsfP/qMk3SK7glNvJOnw4VEvcFmWju7qP/WkhIonGnuzJ641CH4xYE/oEfKvp+Pjt/KXcGsjKLc1gjV9tEhwKDgC5793D92BhXYZqTr6B/TB2tmIxcuLSXvUWcqnhcvKiKqj/B0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788004294; c=relaxed/simple; bh=Rz7tNKQneggBbq3w6Xb4rPN+HyBfUCe9wTuhzdC5sWI=; h=Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To:From; b=qmVPETjeOHOL5gDoCnRIysRupCeg5FvFeAWf2HstuZIf7J6N83q7U9Uu9FhPOQ5u2fUDF25GD4nGri2b4v/DYVMEQhCsfJtuFVLHcf/KZPApUyWf1unXZj3lgEp8OBZWmJjNyxmMpIMWOIfFEY11Ak+m/Y4+bJBlnDkqnQFdO+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=muc.de; spf=pass smtp.mailfrom=muc.de; arc=none smtp.client-ip=193.149.48.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=muc.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=muc.de Received: (qmail 17894 invoked by uid 3782); 29 Aug 2026 13:51:22 +0200 Received: from muc.de (p4fe15d93.dip0.t-ipconnect.de [79.225.93.147]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 29 Aug 2026 13:51:21 +0200 Received: (qmail 56114 invoked by uid 1000); 29 Aug 2026 11:51:20 -0000 Date: Sat, 29 Aug 2026 11:51:20 +0000 To: Jiri Slaby Cc: Greg Kroah-Hartman , Simona Vetter , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Helge Deller , Thomas Zimmermann , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Patch 1/9]: Make consolemap.c handle Unicode planes outside BMP Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de Thanks for trying the patch out. On Fri, Aug 28, 2026 at 06:57:04 +0200, Jiri Slaby wrote: > On 27. 08. 26, 20:42, Alan Mackenzie wrote: > > vt: 32b glyph: 1. Make consolemap.c handle Unicode planes outside BMP > > For this, add a fourth layer "planes" onto the sparse map in > > this file. Also handle glyph numbers up to 2^21 rather than > > 256/512. Move the conversion between __user and kernel data > > from consolemap.c to vt_ioctl.c. > > Signed-off-by: Alan Mackenzie > > diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c > > index 3fa89a2dbeba..2f695d97f0eb 100644 > > --- a/drivers/tty/vt/consolemap.c > > +++ b/drivers/tty/vt/consolemap.c > > @@ -34,11 +34,11 @@ > > #include > > #include > > #include > > -#include > > #include > > +#include > Why do you do this? That's a remnant of a struggle to put in new declarations such that the kernel would build at all. I've just tried restoring the original order of the #includes for consolemap.h and vt_kern.h, and it builds equally well. So that change could/should be undone. > > #include > > -static unsigned short translations[][E_TABSZ] = { > > +static u1632 translations[][E_TABSZ] = { > This breaks the build at this point, right? I'm assuming your error message was "symbol u1632 undeclared". I don't understand yet what's happened here. u1632 gets declared in consolemap.h, so should be avaiable throughout consolemap.c. > u1632 is a bad name though. Possibly. It's the best I could come up with, given it should be concise and thus not cause a lot of refilling of the source code. I'm not sure what would be better instead of u1632. > See also what Sashiko thinks: > https://sashiko.dev/#/patchset/apCEDM2sWv_M354-%40MAC.fritz.box Sashiko has pointed out a number of errors I'll need to fix. I got nine emails directly from it. > thanks, > -- > js > suse labs -- Alan Mackenzie (Nuremberg, Germany).