From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 820AB282F06 for ; Mon, 31 Aug 2026 05:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788154371; cv=none; b=Ofj1eyF+IvikcdwcRkJlZQI242sDG3kZ9fJCMBawzFwZKjYN9R9ncTIju4AbwBNsqcv/gmR66Cbz+/7tN1LIHi06ITmmwYLHrr/fz5mxfnFIs4XVZPVIozB1Yokyy5JLqfboFrvOQuKXIhWFPMCtePb6qwcy22y3GilgMuELlRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788154371; c=relaxed/simple; bh=DbE10ieYAAPdZ/aMj7Jha3L88yCriiIiyuo63Lm7PCU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NL+EafFUZ55W1LZxubdmjp25tfIr4r9Vj4xyjGdJYEscKdBfVJV+GpHlUOhgHXLCOe9YcSyXqD5J/vHNZx1e47qyODR16LJHh7ldqNEzHAC+lnT9tPxYrs58/K19dB3p5EJOr3ugmCdiWnE71NgVI8EQqtWadqkbiGUgtFIrqTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yUOn5QLc; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yUOn5QLc" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381b831d535so5295804a91.0 for ; Sun, 30 Aug 2026 22:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1788154370; x=1788759170; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Z3oEOL/HCSYn6nVXIxkFld926tCj7R+jnIQrhk3OHvk=; b=yUOn5QLcKIShaSFftZdQbmyej5/roTsoUwXl6MliySgXKrmvEh3m0snZd6vqjY42yA qaxdf7D3k6ESk59InZzH3Xfa4eMXDGsUO/tZIuhD9a+mxYsmlsg128qoRZHuZVpFYnYv gZdQzRjj3anUtg9sugk5TwYjUHACrfq6T2D7OYI/ZYoysueMZuuzusWBqG/TuGxqF+FK Kfa/yEeKKIKH/pukEPB70eWmlQar4Gze+r1gj13OLewshMgrlIB1RiqVTOlkcPMuOiUL vp9O6TaAo8ND6WosT5+RLiLtkkLZykywg8qnkQEH6/Azm2mJQItT7+EyVg8CIRhffB4q P1Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788154370; x=1788759170; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z3oEOL/HCSYn6nVXIxkFld926tCj7R+jnIQrhk3OHvk=; b=Qhht9t2ihoq2WxFdhUVa4AFgp6UuBDsTOE6CPDRH99R2iGiohxQ0vNhbSidyNR30Kc qTs7XrKds4rPgKZIRWLIm2HLFZ+ZR9wQAn1lngmXnL04pFNNFkBPfvJ8dx57cnSIYOQm uvMeUubdPP+Zp1eeGdzBpvS4okkqTWDD+WiZt++9GcXfDFJKgqGUlhpCVd5CbbQlqluU z6wRmbSXP6r3qipj/lLtyxj+YMCn4R6pcdryxIjrTw9LMu3X8k/JYL2aac07FH42izA8 zFdurVuOX0xxrQZVIc6XQygSMAr02MJoPdG10uzHXXux4Rb94y4seIHl/Dt8dYt+07rE INkw== X-Forwarded-Encrypted: i=1; AKwUvBwo9OFhr8W2mNDp7r23ekUNOp73VceRiwJyzXrNrQ8QkyK9iu+Dn1zgEt3l2zaCAULylrHa0F9hMK4soL4=@vger.kernel.org X-Gm-Message-State: AFuF++ma72odx1baje+3+RdXqwERnsT4YlX8uGjSM1Yp1YNhNlHH7Im8 Jvo04EKuCdgWtpxNGCp1L66tCdQvM91jK4DDf44vNY592USPks4KlxTGs/KThzMOYQhywC7dhWM vKMN9cRU= X-Gm-Gg: AYBFou3kLFJK5NKAUDkh/3dDZMfAki5U/2EdfnOWpaZ6iFBiioDhcFOIenizbl38yJp ZM7YyThF20pnf6R9K53L6Zdpc40FpvegQrc482iLUKmkkqWqp0mryEeqpkyf8WoQ/mwLTcmdrQV XOrWy/bMJnoA+/wKGf3xKD5/AD0G01lrKheey4EmVJ0ro4cgcuOIxdc+bwVxwReCqB2MNkBO9rX qs+YN47nUxKI00dE9P7gJG/QY3/TeQaMuc6J1LAb42YV8OKVLjsXvLJQzUIQLfPRT6DGDWeMIKZ IjY2z+62LzXRksEfilbCrKS+sA59TpfaP6RtwwUYSeM3ei+oIH5bEQmWzSjTrfcJVjrCpPT2XFQ Q7mxUeKjfIET6bG4ZSraOc5xXGLR4ln8+v/S6nHLl4DGzXv9drTbEFpWKKSREk+m3y+A9mnKwUY 8JrG/IQKhDSdO6Ow0vPBbeE2VFA4bLESoTzKR6VllbO4YN0+UCEPpRBDdHlMLBi5Q= X-Received: by 2002:a17:90b:388c:b0:396:5f7f:52f5 with SMTP id 98e67ed59e1d1-396d0e2466fmr36959506a91.3.1788154369601; Sun, 30 Aug 2026 22:32:49 -0700 (PDT) Received: from localhost ([122.172.87.224]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-32bdfd03e71sm9171326eec.1.2026.08.30.22.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2026 22:32:48 -0700 (PDT) Date: Mon, 31 Aug 2026 11:02:46 +0530 From: Viresh Kumar To: Christian Marangi Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Schwierzeck , stable@vger.kernel.org Subject: Re: [PATCH] cpufreq: airoha: fix probe failure with correct error check Message-ID: References: <20260821084541.139703-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260821084541.139703-1-ansuelsmth@gmail.com> On 21-08-26, 10:45, Christian Marangi wrote: > From: Daniel Schwierzeck > > dev_pm_domain_attach_list() returns the number of attached PM domains > on success (a positive count), or a negative error code on failure. > The driver checks "if (ret)" which treats a successful attachment of > one or more PM domains as an error, causing the probe to fail with > return code 1. > > Fix by checking "if (ret < 0)" like all other users of this API. > > Cc: stable@vger.kernel.org > Fixes: 84cf9e541ccc ("cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver") > Signed-off-by: Daniel Schwierzeck > Signed-off-by: Christian Marangi > --- > drivers/cpufreq/airoha-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied. Thanks. -- viresh