From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
"Linus Walleij" <linusw@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] platform/x86: x86-android-tablets: fix Arizona and Crystal Cove GPIO lookups
Date: Mon, 31 Aug 2026 12:11:46 +0300 [thread overview]
Message-ID: <apVFUoSmLmj51zJh@ashevche-desk.local> (raw)
In-Reply-To: <20260830-x86-android-lenovo-swnode-v1-0-066a91acb4ba@gmail.com>
On Sun, Aug 30, 2026 at 04:15:04AM -0700, Dmitry Torokhov wrote:
> When gpiolib dropped name-against-label matching in favor of firmware node
> identity mapping, lookups referencing unattached software nodes (such as
> arizona and gpio_crystalcove in x86-android-tablets) stopped working.
>
> This series fixes the lookups and cleans up redundant software node
> registrations on Lenovo tablets:
> - Point Arizona GPIO property entries directly to the codec device software
> node, which is attached to the parent device.
> - Hold a device reference in gpio_secondary_fwnode_init() to ensure safety
> during devres action teardown.
> - Generalize gpio_secondary_fwnode_init() to accept a node group argument
> and use it to attach crystalcove_gpiochip_node as a secondary firmware
> node to INT33FD:00 on Lenovo Yoga Tab 2 models.
> - Drop redundant swnode group registrations on Lenovo Yoga Tab 3 and
> Yoga Tab 2 models where codec software nodes are already registered when
> attached to their respective devices.
Nice series, thanks!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-31 9:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 11:15 Dmitry Torokhov
2026-08-30 11:15 ` [PATCH 1/6] platform/x86: x86-android-tablets: fix Arizona GPIO swnode references Dmitry Torokhov
2026-08-30 11:15 ` [PATCH 2/6] platform/x86: x86-android-tablets: hold device reference for secondary fwnode teardown Dmitry Torokhov
2026-08-30 11:15 ` [PATCH 3/6] platform/x86: x86-android-tablets: pass node group to gpio_secondary_fwnode_init() Dmitry Torokhov
2026-08-30 11:15 ` [PATCH 4/6] platform/x86: x86-android-tablets: add Crystal Cove GPIO swnode support Dmitry Torokhov
2026-08-30 11:15 ` [PATCH 5/6] platform/x86: x86-android-tablets: drop redundant swnode group on YT3 Dmitry Torokhov
2026-08-30 11:15 ` [PATCH 6/6] platform/x86: x86-android-tablets: use shared battery swnode group on Yoga Tab 2 Dmitry Torokhov
2026-08-31 8:45 ` [PATCH 0/6] platform/x86: x86-android-tablets: fix Arizona and Crystal Cove GPIO lookups Linus Walleij
2026-08-31 9:11 ` Andy Shevchenko [this message]
2026-08-31 9:42 ` Hans de Goede
2026-08-31 12:47 ` Dmitry Torokhov
2026-08-31 20:20 ` Hans de Goede
2026-08-31 20:21 ` Hans de Goede
2026-08-31 20:17 ` Hans de Goede
2026-08-31 20:37 ` Dmitry Torokhov
2026-09-01 13:11 ` Hans de Goede
2026-09-02 11:46 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apVFUoSmLmj51zJh@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®